Skip to content

New test: [iOS] webaudio/require-transient-activation.html is consistently timing out #6612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2022
Merged

New test: [iOS] webaudio/require-transient-activation.html is consistently timing out #6612

merged 1 commit into from
Nov 18, 2022

Conversation

@cdumez
Copy link
Contributor

@cdumez cdumez commented Nov 18, 2022 •
edited by webkit-early-warning-system
Loading

3bc2bb6

New test: [iOS] webaudio/require-transient-activation.html is consistently timing out
https://bugs.webkit.org/show_bug.cgi?id=248061
rdar://102488833

Reviewed by Darin Adler.

runWithKeyDown() doesn't work on iOS apparently so rely on
internals.withUserGesture() instead.

* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/webaudio/require-transient-activation.html:

Canonical link: https://commits.webkit.org/256859@main

0fd0e27

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ❌ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 watch ❌ 🧪 mac-AS-debug-wk2
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@cdumez cdumez self-assigned this Nov 18, 2022
@cdumez cdumez added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Nov 18, 2022
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Nov 18, 2022 •
edited
Loading

EWS run on previous version of this PR (hash 517a166)

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ❌ 🛠 ios ❌ 🛠 mac ❌ 🛠 wpe ❌ 🛠 🧪 win
❌ 🛠 ios-sim ❌ 🛠 mac-debug ❌ 🛠 gtk ❌ 🛠 wincairo
❌ 🧪 webkitperl ❌ 🧪 ios-wk2 ❌ 🛠 mac-AS-debug ❌ 🧪 gtk-wk2
❌ 🧪 api-ios ❌ 🧪 api-mac ❌ 🧪 api-gtk
❌ 🛠 tv ❌ 🧪 mac-wk1
❌ 🛠 tv-sim ❌ 🧪 mac-wk2
❌ 🛠 watch ❌ 🧪 mac-AS-debug-wk2
❌ 🛠 watch-sim ❌ 🧪 mac-wk2-stress

@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Nov 18, 2022 •
edited
Loading

EWS run on previous version of this PR (hash 517a166)

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ⏳ 🛠 ios ⏳ 🛠 mac ⏳ 🛠 wpe ⏳ 🛠 🧪 win
⏳ 🛠 ios-sim ⏳ 🛠 mac-debug ⏳ 🛠 gtk ⏳ 🛠 wincairo
❌ 🧪 webkitperl ⏳ 🧪 ios-wk2 ⏳ 🛠 mac-AS-debug ⏳ 🧪 gtk-wk2
⏳ 🧪 api-ios ⏳ 🧪 api-mac ⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc ⏳ 🛠 tv ⏳ 🧪 mac-wk1 ⏳ 🛠 jsc-armv7
⏳ 🛠 tv-sim ⏳ 🧪 mac-wk2 ⏳ 🧪 jsc-armv7-tests
⏳ 🛠 watch ⏳ 🧪 mac-AS-debug-wk2 ⏳ 🛠 jsc-mips
⏳ 🛠 watch-sim ⏳ 🧪 mac-wk2-stress ⏳ 🧪 jsc-mips-tests

@cdumez cdumez force-pushed the 248061_audio_transient_activation_ios branch from 517a166 to 0fd0e27 Compare November 18, 2022 03:03
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Nov 18, 2022 •
edited
Loading

EWS run on current version of this PR (hash 0fd0e27)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ❌ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 watch ❌ 🧪 mac-AS-debug-wk2
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Nov 18, 2022 •
edited
Loading

EWS run on current version of this PR (hash 0fd0e27)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ⏳ 🛠 ios ⏳ 🛠 mac ⏳ 🛠 wpe ⏳ 🛠 🧪 win
⏳ 🛠 ios-sim ⏳ 🛠 mac-debug ⏳ 🛠 gtk ⏳ 🛠 wincairo
✅ 🧪 webkitperl ⏳ 🧪 ios-wk2 ⏳ 🛠 mac-AS-debug ⏳ 🧪 gtk-wk2
⏳ 🧪 api-ios ⏳ 🧪 api-mac ⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc ⏳ 🛠 tv ⏳ 🧪 mac-wk1 ⏳ 🛠 jsc-armv7
⏳ 🛠 tv-sim ⏳ 🧪 mac-wk2 ⏳ 🧪 jsc-armv7-tests
⏳ 🛠 watch ⏳ 🧪 mac-AS-debug-wk2 ⏳ 🛠 jsc-mips
⏳ 🛠 watch-sim ⏳ 🧪 mac-wk2-stress ⏳ 🧪 jsc-mips-tests

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 18, 2022
@cdumez cdumez added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merging-blocked Applied to prevent a change from being merged labels Nov 18, 2022
@cdumez
New test: [iOS] webaudio/require-transient-activation.html is consist…
3bc2bb6 
…ently timing out

https://bugs.webkit.org/show_bug.cgi?id=248061
rdar://102488833

Reviewed by Darin Adler.

runWithKeyDown() doesn't work on iOS apparently so rely on
internals.withUserGesture() instead.

* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/webaudio/require-transient-activation.html:

Canonical link: https://commits.webkit.org/256859@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the 248061_audio_transient_activation_ios branch from 0fd0e27 to 3bc2bb6 Compare November 18, 2022 23:28
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented Nov 18, 2022

Committed 256859@main (3bc2bb6): https://commits.webkit.org/256859@main

Reviewed commits have been landed. Closing PR #6612 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 3bc2bb6 into WebKit:main Nov 18, 2022
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darinadler darinadler darinadler approved these changes

@youennf youennf Awaiting requested review from youennf

@eric-carlson eric-carlson Awaiting requested review from eric-carlson

@jernoble jernoble Awaiting requested review from jernoble

Assignees

@cdumez cdumez

Labels

New Bugs Unclassified bugs are placed in this component until the correct component can be determined.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cdumez @webkit-early-warning-system @webkit-commit-queue @darinadler @webkit-ews-buildbot