Skip to content

Fix internal build after 258484@main #8243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix internal build after 258484@main #8243

wants to merge 1 commit into from

Conversation

@achristensen07
Copy link
Contributor

@achristensen07 achristensen07 commented Jan 5, 2023 •
edited by webkit-early-warning-system
Loading

089d887

Fix internal build after 258484@main
https://bugs.webkit.org/show_bug.cgi?id=250143
rdar://103925489

Unreviewed.

Calling pairIntHash with uint64_t parameters not only ignores 32 bits of the uint64_t, but it caused a compiler warning in an internal file that includes Int128.h

* Source/WTF/wtf/Int128.h:
(WTF::DefaultHash<UInt128>::hash):
(WTF::DefaultHash<Int128>::hash):

089d887

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 🧪 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 gtk-wk2
  🧪 api-ios   🧪 mac-wk1   🧪 api-gtk
✅ 🛠 🧪 jsc ✅ 🛠 tv   🧪 mac-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch   🧪 mac-wk2-stress ✅ 🛠 jsc-mips
✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests
❌ 🛠 🧪 unsafe-merge

@achristensen07
Fix internal build after 258484@main
089d887 
https://bugs.webkit.org/show_bug.cgi?id=250143
rdar://103925489

Unreviewed.

Calling pairIntHash with uint64_t parameters not only ignores 32 bits of the uint64_t, but it caused a compiler warning in an internal file that includes Int128.h

* Source/WTF/wtf/Int128.h:
(WTF::DefaultHash<UInt128>::hash):
(WTF::DefaultHash<Int128>::hash):
@achristensen07 achristensen07 self-assigned this Jan 5, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 5, 2023 •
edited
Loading

EWS run on current version of this PR (hash 089d887)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 🧪 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 gtk-wk2
  🧪 api-ios   🧪 mac-wk1   🧪 api-gtk
✅ 🛠 🧪 jsc ✅ 🛠 tv   🧪 mac-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch   🧪 mac-wk2-stress ✅ 🛠 jsc-mips
✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests
❌ 🛠 🧪 unsafe-merge

@chirags27 chirags27 self-requested a review January 5, 2023 21:27
@achristensen07 achristensen07 added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jan 5, 2023
@webkit-commit-queue
Copy link
Collaborator

@chirags27 does not have reviewer permissions according to https://raw.githubusercontent.com/WebKit/WebKit/main/metadata/contributors.json.

If you do have reviewer permmissions, please ensure that your GitHub username is added to contributors.json.

Rejecting 089d887 from merge queue.

@webkit-commit-queue webkit-commit-queue added merging-blocked Applied to prevent a change from being merged and removed unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels Jan 5, 2023
@achristensen07 achristensen07 added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merging-blocked Applied to prevent a change from being merged labels Jan 5, 2023
@webkit-commit-queue
Copy link
Collaborator

@chirags27 does not have reviewer permissions according to https://raw.githubusercontent.com/WebKit/WebKit/main/metadata/contributors.json.

If you do have reviewer permmissions, please ensure that your GitHub username is added to contributors.json.

Rejecting 089d887 from merge queue.

@webkit-commit-queue webkit-commit-queue added merging-blocked Applied to prevent a change from being merged and removed unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels Jan 5, 2023
@chirags27 chirags27 removed their request for review January 5, 2023 21:36
@achristensen07 achristensen07 added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merging-blocked Applied to prevent a change from being merged labels Jan 5, 2023
@webkit-commit-queue
Copy link
Collaborator

@chirags27 does not have reviewer permissions according to https://raw.githubusercontent.com/WebKit/WebKit/main/metadata/contributors.json.

If you do have reviewer permmissions, please ensure that your GitHub username is added to contributors.json.

Rejecting 089d887 from merge queue.

@webkit-commit-queue webkit-commit-queue added merging-blocked Applied to prevent a change from being merged and removed unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels Jan 5, 2023
@achristensen07
Copy link
Contributor Author

Unable to land, making new PR in #8246

@achristensen07 achristensen07 deleted the eng/Fix-internal-build-after-258484main branch January 5, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chirags27 chirags27 Awaiting requested review from chirags27

Assignees

@achristensen07 achristensen07

Labels

merging-blocked Applied to prevent a change from being merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@achristensen07 @webkit-early-warning-system @webkit-commit-queue @chirags27