REGRESSION (258521@main): Can end up scrolled to an invalid offset, blank space above page #8412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hortont424
added
the
WebKit Misc.
Collaborator
|
EWS run on current version of this PR (hash 86827bd)
|
megangardner
approved these changes
Jan 9, 2023
grorg
approved these changes
Jan 9, 2023
…lank space above page https://bugs.webkit.org/show_bug.cgi?id=250335 rdar://103977580 Reviewed by Dean Jackson and Megan Gardner. * Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm: (-[WKWebView _updateScrollViewForTransaction:]): Ensure that we don't scroll to an invalid offset, the same way we do elsewhere. Canonical link: https://commits.webkit.org/258687@main
webkit-early-warning-system
force-pushed
the
eng/REGRESSION-258521main-Can-end-up-scrolled-to-an-invalid-offset-blank-space-above-page
branch
from
86827bd to
6e41546
Compare
Collaborator
|
Committed 258687@main (6e41546): https://commits.webkit.org/258687@main Reviewed commits have been landed. Closing PR #8412 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6e41546
86827bd
🛠 wincairo🧪 ios-wk2🧪 api-mac🧪 gtk-wk2🧪 api-ios🧪 api-gtk