Skip to content
Permalink
Browse files

Web Inspector: Add Inspector.targetCrashed event to Inspector protocol.

https://bugs.webkit.org/show_bug.cgi?id=112669

Added Inspector.targetCrashed event and handled it on the front end.
Showing a modal dialog similar to the one displayed when the remote
debugging target is disconnected.

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-03-19
Reviewed by Pavel Feldman.

* English.lproj/localizedStrings.js:
* inspector/Inspector.json:
* inspector/front-end/HelpScreen.js:
(WebInspector.HelpScreenUntilReload):
(WebInspector.HelpScreenUntilReload.prototype.willHide):
* inspector/front-end/inspector.js:
(WebInspector.targetCrashed):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146198 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information...
commit-queue@webkit.org
commit-queue@webkit.org committed Mar 19, 2013
1 parent ebc2634 commit 255ba17d1d7e0ad1530d503f28ee5d93d7c5351e
@@ -1,3 +1,22 @@
2013-03-19 Vladislav Kaznacheev <kaznacheev@chromium.org>

Web Inspector: Add Inspector.targetCrashed event to Inspector protocol.
https://bugs.webkit.org/show_bug.cgi?id=112669

Added Inspector.targetCrashed event and handled it on the front end.
Showing a modal dialog similar to the one displayed when the remote
debugging target is disconnected.

Reviewed by Pavel Feldman.

* English.lproj/localizedStrings.js:
* inspector/Inspector.json:
* inspector/front-end/HelpScreen.js:
(WebInspector.HelpScreenUntilReload):
(WebInspector.HelpScreenUntilReload.prototype.willHide):
* inspector/front-end/inspector.js:
(WebInspector.targetCrashed):

2013-03-19 Mario Sanchez Prada <mario.prada@samsung.com>

[GTK] Wrong guard USE(GLX) in RedirectedXCompositeWindow
@@ -239,6 +239,8 @@ localizedStrings["Inherited from"] = "Inherited from";
localizedStrings["Initiator"] = "Initiator";
localizedStrings["Inspected worker terminated"] = "Inspected worker terminated";
localizedStrings["Inspected worker has terminated. Once it restarts we will attach to it automatically."] = "Inspected worker has terminated. Once it restarts we will attach to it automatically.";
localizedStrings["Inspected target crashed"] = "Inspected target crashed";
localizedStrings["Inspected target has crashed. Once it reloads we will attach to it automatically."] = "Inspected target has crashed. Once it reloads we will attach to it automatically.";
localizedStrings["Install Timer"] = "Install Timer";
localizedStrings["Invalid property value."] = "Invalid property value.";
localizedStrings["KB"] = "KB";
@@ -35,6 +35,10 @@
"parameters": [
{ "name": "reason", "type": "string", "description": "The reason why connection has been terminated." }
]
},
{
"name": "targetCrashed",
"description": "Fired when debugging target has crashed"
}
]
},
@@ -122,3 +122,32 @@ WebInspector.HelpScreen.prototype = {

__proto__: WebInspector.View.prototype
}

/**
* @constructor
* @param {string=} title
* @param {string=} message
* @extends {WebInspector.HelpScreen}
*/
WebInspector.HelpScreenUntilReload = function(title, message)
{
WebInspector.HelpScreen.call(this, title);
var p = this.contentElement.createChild("p");
p.addStyleClass("help-section");
p.textContent = message;
WebInspector.debuggerModel.addEventListener(WebInspector.DebuggerModel.Events.GlobalObjectCleared, this.hide, this);
}

WebInspector.HelpScreenUntilReload.prototype = {
/**
* @override
*/
willHide: function()
{
WebInspector.debuggerModel.removeEventListener(WebInspector.DebuggerModel.Events.GlobalObjectCleared, this.hide, this);
WebInspector.HelpScreen.prototype.willHide.call(this);
},

__proto__: WebInspector.HelpScreen.prototype
}

@@ -982,6 +982,13 @@ WebInspector.detached = function(reason)
(new WebInspector.RemoteDebuggingTerminatedScreen(reason)).showModal();
}

WebInspector.targetCrashed = function()
{
(new WebInspector.HelpScreenUntilReload(
WebInspector.UIString("Inspected target crashed"),
WebInspector.UIString("Inspected target has crashed. Once it reloads we will attach to it automatically."))).showModal();
}

WebInspector._updateFocusedNode = function(nodeId)
{
if (WebInspector._nodeSearchButton.toggled) {

0 comments on commit 255ba17

Please sign in to comment.
You can’t perform that action at this time.