Permalink
Browse files

DragController should ascertain dragClient to be non-null

https://bugs.webkit.org/show_bug.cgi?id=92474

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-07-27
Reviewed by Tony Chang.

The DragController must always ensure a valid dragClient object. Hence
adding the ASSERT to assure that.

No new tests. Added assertion for PageClient.dragClient.

* page/DragController.cpp:
(WebCore::DragController::DragController):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123927 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information...
1 parent 8492fa1 commit ecf9dfb8d1c14f03c8842db3a8d27471d7e44862 commit-queue committed Jul 27, 2012
Showing with 16 additions and 0 deletions.
  1. +15 −0 Source/WebCore/ChangeLog
  2. +1 −0 Source/WebCore/page/DragController.cpp
View
@@ -1,3 +1,18 @@
+2012-07-27 Vivek Galatage <vivekgalatage@gmail.com>
+
+ DragController should ascertain dragClient to be non-null
+ https://bugs.webkit.org/show_bug.cgi?id=92474
+
+ Reviewed by Tony Chang.
+
+ The DragController must always ensure a valid dragClient object. Hence
+ adding the ASSERT to assure that.
+
+ No new tests. Added assertion for PageClient.dragClient.
+
+ * page/DragController.cpp:
+ (WebCore::DragController::DragController):
+
2012-07-27 Adrienne Walker <enne@google.com>
[chromium] Clean up LayerRendererChromium::drawTexturedQuad
@@ -101,6 +101,7 @@ DragController::DragController(Page* page, DragClient* client)
, m_isHandlingDrag(false)
, m_sourceDragOperation(DragOperationNone)
{
+ ASSERT(m_client);
}
DragController::~DragController()

0 comments on commit ecf9dfb

Please sign in to comment.