Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
branch: master
Commits on Apr 18, 2015
  1. Web Inspector: All sans-serif font family rules should be set the sam…

    jonowells@apple.com authored
    …e way.
    
    
    https://bugs.webkit.org/show_bug.cgi?id=143909
    
    Reviewed by Timothy Hatcher.
    
    Update styles so that all uses of sans-serif font use -webkit-system-font consistently.
    
    * UserInterface/Views/DefaultDashboardView.css:
    (body.mac-platform.legacy .toolbar .dashboard.default > .item):
    * UserInterface/Views/ObjectTreePropertyTreeElement.css:
    (.object-tree-property .prototype-name):
    * UserInterface/Views/ObjectTreeView.css:
    (.object-tree-outline li .empty-message):
    * UserInterface/Views/RenderingFrameTimelineOverviewGraph.css:
    (.timeline-overview-graph.rendering-frame > .divider > .label):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182982 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  2. Clients sometimes block for 500ms in waitForPossibleGeometryUpdates

    timothy_horton@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=143901
    <rdar://problem/20488655>
    
    Reviewed by Anders Carlsson.
    
    * Platform/IPC/Connection.cpp:
    (IPC::Connection::waitForMessage):
    InterruptWaitingIfSyncMessageArrives already cancels waitForMessage if
    a sync message arrives while waiting, but it should also avoid waiting
    if there's a sync message already in the queue when the waiting starts,
    as that will have the same nasty effect.
    
    * UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
    (WebKit::TiledCoreAnimationDrawingAreaProxy::waitForPossibleGeometryUpdate):
    If a synchronous message comes in from the Web process while we're waiting,
    cancel our synchronous wait for DidUpdateGeometry. This will cause the size
    change to not synchronize with the Web process' painting, but that is better
    than pointlessly blocking for 500ms.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182980 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  3. Possible null pointer dereference in WebDiagnosticLoggingClient::logD…

    cdumez@apple.com authored
    …iagnosticMessageWithValue()
    
    
    https://bugs.webkit.org/show_bug.cgi?id=143899
    <rdar://problem/20584215>
    
    Reviewed by Anders Carlsson.
    
    WebDiagnosticLoggingClient::logDiagnosticMessage*() methods failed to
    check that m_page.corePage() was non-null before dereferencing, thus
    causing crashes when it is null.
    
    * WebProcess/WebCoreSupport/WebDiagnosticLoggingClient.cpp:
    (WebKit::WebDiagnosticLoggingClient::logDiagnosticMessage):
    (WebKit::WebDiagnosticLoggingClient::logDiagnosticMessageWithResult):
    (WebKit::WebDiagnosticLoggingClient::logDiagnosticMessageWithValue):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182979 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Commits on Apr 17, 2015
  1. Use ASan poisoning to taint moved-out-of Refs

    ap@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=143894
    rdar://problem/19443723
    
    Reviewed by Darin Adler.
    
    * wtf/Ref.h: (WTF::Ref::~Ref):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182977 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  2. Web Inspector: Have better inactive window color for pixel borders

    timothy@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=143888
    
    Reviewed by Joseph Pecoraro.
    
    * UserInterface/Views/FindBanner.css:
    (body.window-inactive .find-banner):
    * UserInterface/Views/Main.css:
    (body.window-inactive.docked.bottom):
    (body.window-inactive.docked.right):
    (body.window-inactive #split-content-browser):
    * UserInterface/Views/NavigationBar.css:
    (body.window-inactive .navigation-bar):
    * UserInterface/Views/QuickConsole.css:
    (body.window-inactive .quick-console):
    (.quick-console.showing-log):
    * UserInterface/Views/Sidebar.css:
    (body.window-inactive .sidebar.left):
    (body.window-inactive .sidebar.right):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182976 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  3. WebKit client should be able to add view controller for link preview.

    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=143686
    
    Add delegate methods to WKUIDelegatePrivate so that a WebKit client can prepare a view controller
    for link preview and react to the dismissal of this view controller. Also connect WKContentView to
    preview gesture recognizer and forwards the delegate callbacks to corresponding delegate methods
    in WKUIDelegatePrivate.
    
    Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2015-04-17
    Reviewed by Beth Dakin.
    
    * Platform/spi/ios/UIKitSPI.h:
    * UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
    * UIProcess/ios/WKContentView.mm:
    (-[WKContentView willMoveToWindow:]):
    * UIProcess/ios/WKContentViewInteraction.h:
    * UIProcess/ios/WKContentViewInteraction.mm:
    (-[WKContentView cleanupInteraction]):
    (-[WKContentView gestureRecognizer:canPreventGestureRecognizer:]):
    (-[WKContentView gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):
    (-[WKContentView gestureRecognizerShouldBegin:]):
    (-[WKContentView previewViewControllerForPosition:inSourceView:]):
    (-[WKContentView commitPreviewViewController:]):
    (-[WKContentView willPresentPreviewViewController:forPosition:inSourceView:]):
    (-[WKContentView didDismissPreviewViewController:committing:]):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182975 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  4. Large values for line-height cause integer overflow in RenderStyle::c…

    bjonesbe@adobe.com authored
    …omputedLineHeight
    
    
    https://bugs.webkit.org/show_bug.cgi?id=143863
    
    Reviewed by Rob Buis.
    
    Source/WebCore:
    
    When we compute huge values for line-height through percentage or CSS
    calc, we'll overflow the integer and later on
    ShapeOutsideInfo::computeDeltasForContainingBlockLine will ASSERT
    because it expects non-negative line height.  So for the computed
    line-height, clamp to an integer range to avoid overflow. Note that
    the code path for percentages here is safe because LayoutUnit clamps
    to an int on conversion.
    
    This is based on a Blink patch by Rob Buis.
    
    Test: fast/shapes/shape-outside-floats/shape-outside-negative-line-height-crash.html
    
    * rendering/style/RenderStyle.cpp:
    (WebCore::RenderStyle::computedLineHeight): Clamp line-height to an
        int to avoid overflow.
    
    LayoutTests:
    
    Simplified test from a fuzzer.
    
    * fast/shapes/shape-outside-floats/shape-outside-negative-line-height-crash-expected.txt: Added.
    * fast/shapes/shape-outside-floats/shape-outside-negative-line-height-crash.html: Added.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182974 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  5. Web Inspector: Unexpected background at top of console when rubber-ba…

    commit-queue@webkit.org authored
    …nding with selection
    
    
    https://bugs.webkit.org/show_bug.cgi?id=140710
    
    Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-04-17
    Reviewed by Timothy Hatcher.
    
    * UserInterface/Views/LogContentView.css:
    (.console-messages):
    Remove the focus ring on the console's log view, only visible when rubber-banding.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182973 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  6. Remove unused BoundsCheckedPointer

    ap@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=143896
    
    Reviewed by Geoffrey Garen.
    
    Source/JavaScriptCore:
    
    * bytecode/SpeculatedType.cpp: The header was included here.
    
    Source/WTF:
    
    * WTF.vcxproj/WTF.vcxproj:
    * WTF.vcxproj/WTF.vcxproj.filters:
    * WTF.xcodeproj/project.pbxproj:
    * wtf/BoundsCheckedPointer.h: Removed.
    * wtf/CMakeLists.txt:
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182971 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  7. [ES6] Fix name enumeration of static functions for Symbol constructor

    utatane.tea@gmail.com authored
    https://bugs.webkit.org/show_bug.cgi?id=143891
    
    Reviewed by Geoffrey Garen.
    
    Source/JavaScriptCore:
    
    Fix missing symbolPrototypeTable registration to the js class object.
    This patch fixes name enumeration of static functions (Symbol.key, Symbol.keyFor) for Symbol constructor.
    
    * runtime/SymbolConstructor.cpp:
    
    LayoutTests:
    
    Add property names tests for Symbol constructor, Symbol object and Symbol.prototype.
    
    * js/Object-getOwnPropertyNames-expected.txt: Removed.
    * js/script-tests/Object-getOwnPropertyNames.js:
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182967 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  8. Not able to build WebKit against iOS Simulator 8.3 SDK

    dbates@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=143883
    
    Reviewed by David Kilzer.
    
    Tools:
    
    Copy libraries libWebKitSystemInterfaceIOS{Device, Simulator}8.3.a to the built product directory
    so that Xcode uses them.
    
    * Scripts/copy-webkitlibraries-to-product-directory:
    
    WebKitLibraries:
    
    Add WebKitSystemInterface for iOS 8.3.
    
    * libWebKitSystemInterfaceIOSDevice8.3.a: Added.
    * libWebKitSystemInterfaceIOSSimulator8.3.a: Added.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182964 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  9. Force mouse events should go through normal mouse event handling code…

    bdakin@apple.com authored
    … paths
    
    
    https://bugs.webkit.org/show_bug.cgi?id=143749
    -and corresponding-
    rdar://problem/20472895
    
    Reviewed by Dean Jackson.
    
    Source/WebCore:
    
    This patch moves all of the code to dispatch mouseforcedown, mouseforceup, and 
    mouseforcechanged into normal mouse event dispatching code. This patch leaves 
    behind the cancel and click events because we plan to remove those, and it also 
    leaves mouseforcewillbegin because that is necessarily a very different event more 
    tied to the NSImmediateActionGestureRecognizer than these other events which are 
    tied to NSResponder’s pressureChangeWithEvent.
    
    New helper functions.
    * dom/Document.cpp:
    (WebCore::Document::hasListenerTypeForEventType):
    * dom/Document.h:
    * dom/Element.cpp:
    (WebCore::isForceEvent):
    
    Move the code to ensure the force events have listeners in order to fire to 
    dispatchMouseEvent, and delete the old implementations.
    (WebCore::Element::dispatchMouseEvent):
    (WebCore::Element::dispatchMouseForceChanged): Deleted.
    (WebCore::Element::dispatchMouseForceDown): Deleted.
    (WebCore::Element::dispatchMouseForceUp): Deleted.
    * dom/Element.h:
    
    Perform a hit test and pipe the events through dispatchMouseEvent(). 
    * page/EventHandler.cpp:
    (WebCore::EventHandler::handleMouseForceEvent):
    * page/EventHandler.h:
    
    New types for the new events.
    * platform/PlatformEvent.h:
    
    Forward to EventHandler. 
    * replay/UserInputBridge.cpp:
    (WebCore::UserInputBridge::handleMouseForceEvent):
    * replay/UserInputBridge.h:
    
    Source/WebKit2:
    
    This patch makes pressureChangeWithEvent create NativeWebMouseEvents with the 
    NSEventTypePressures that is gets and sends those down to the web process.
    
    Re-name pressureEvent to lastPressureEvent. Now that event can sometimes be an 
    NSEventTypePressure, the new name makes it clear how the second parameter differs 
    from the first.
    * Shared/NativeWebMouseEvent.h:
    
    New event types for the new types of events.
    * Shared/WebEvent.h:
    * Shared/WebEventConversion.cpp:
    (WebKit::WebKit2PlatformMouseEvent::WebKit2PlatformMouseEvent):
    * Shared/mac/NativeWebMouseEventMac.mm:
    (WebKit::NativeWebMouseEvent::NativeWebMouseEvent):
    * Shared/mac/WebEventFactory.h:
    
    All of the square-peg, round-hole problems of massaging the NSEventTypePressures 
    events into WebMouseEvents is taken care of here.
    * Shared/mac/WebEventFactory.mm:
    (WebKit::mouseButtonForEvent):
    (WebKit::globalPointForEvent):
    (WebKit::pointForEvent):
    (WebKit::WebEventFactory::createWebMouseEvent):
    
    Instead of calling the old inputDeviceForceDidChange, create a NativeWebMouseEvent 
    and handle it.
    * UIProcess/API/mac/WKView.mm:
    (-[WKView pressureChangeWithEvent:]):
    
    Handle the new types.
    * UIProcess/WebPageProxy.cpp:
    (WebKit::WebPageProxy::didReceiveEvent):
    
    Can delete inputDeviceForceDidChange since it’s no longer used.
    (WebKit::WebPageProxy::inputDeviceForceDidChange): Deleted.
    * UIProcess/WebPageProxy.h:
    
    Handle the new types of mouse events properly.
    * WebProcess/WebPage/WebPage.cpp:
    (WebKit::handleMouseEvent):
    
    Delete inputDeviceForceDidChange() and m_lastForceStage.
    * WebProcess/WebPage/WebPage.h:
    * WebProcess/WebPage/WebPage.messages.in:
    * WebProcess/WebPage/mac/WebPageMac.mm:
    (WebKit::WebPage::inputDeviceForceDidChange): Deleted.
    
    Handle new WebEvent types.
    * WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
    
    Tools:
    
    Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner. 
    Since there is not a way to create an NSEventTypePressure from scratch, we 
    subclass NSEvent and override all of the critical methods.
    
    * WebKitTestRunner/EventSenderProxy.h:
    * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
    * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
    (WTR::EventSendingController::mouseForceDown):
    (WTR::EventSendingController::mouseForceUp):
    (WTR::EventSendingController::mouseForceChanged):
    * WebKitTestRunner/InjectedBundle/EventSendingController.h:
    * WebKitTestRunner/TestController.cpp:
    (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
    * WebKitTestRunner/mac/EventSenderProxy.mm:
    (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
    (-[EventSenderPressureEvent timestamp]):
    (-[EventSenderPressureEvent type]):
    (-[EventSenderPressureEvent locationInWindow]):
    (-[EventSenderPressureEvent location]):
    (-[EventSenderPressureEvent stage]):
    (-[EventSenderPressureEvent pressure]):
    (-[EventSenderPressureEvent phase]):
    (-[EventSenderPressureEvent eventNumber]):
    (WTR::EventSenderProxy::mouseForceDown):
    (WTR::EventSenderProxy::mouseForceUp):
    (WTR::EventSenderProxy::mouseForceChanged):
    
    LayoutTests:
    
    Just a few new tests. More to come.
    * fast/events/mouse-force-changed-expected.txt: Added.
    * fast/events/mouse-force-changed.html: Added.
    * fast/events/mouse-force-down-expected.txt: Added.
    * fast/events/mouse-force-down.html: Added.
    * fast/events/mouse-force-up-expected.txt: Added.
    * fast/events/mouse-force-up.html: Added.
    
    Right now the new tests will only work on Mac 10.10.3 and beyond.
    * platform/efl/TestExpectations:
    * platform/gtk/TestExpectations:
    * platform/ios-simulator/TestExpectations:
    * platform/mac-mavericks/TestExpectations:
    * platform/win/TestExpectations:
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182963 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  10. RenderTableCell::computeCollapsed*Border() should check if the cell i…

    zalan@apple.com authored
    …s still attached to the render tree.
    
    
    https://bugs.webkit.org/show_bug.cgi?id=143887
    rdar://problem/20568989
    
    Reviewed by Simon Fraser.
    
    Detached table cell has no access to its parent table. This is a speculative fix to
    avoid dereferencing the invalid table pointer.
    
    * rendering/RenderTableCell.cpp:
    (WebCore::RenderTableCell::computeCollapsedStartBorder):
    (WebCore::RenderTableCell::computeCollapsedEndBorder):
    (WebCore::RenderTableCell::computeCollapsedBeforeBorder):
    (WebCore::RenderTableCell::computeCollapsedAfterBorder):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182962 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  11. build.webkit.org/dashboard still shows obsolete results for out of or…

    ap@apple.com authored
    …der builds sometimes
    
    
    https://bugs.webkit.org/show_bug.cgi?id=143885
    
    Reviewed by Tim Horton.
    
    Fixed a case where we have two builds with the same revision(s). An in order build
    is one for which the revision is strictly higher.
    
    * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
    (BuildbotQueue.prototype._checkForInOrderResult):
    (BuildbotQueue.prototype.compareIterationsByRevisions):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182960 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  12. Inline JSFunction allocation in DFG

    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=143858
    
    Patch by Basile Clement <basile_clement@apple.com> on 2015-04-17
    Reviewed by Filip Pizlo.
    
    Followup to my previous patch which inlines JSFunction allocation when
    using FTL, now also enabled in DFG.
    
    * dfg/DFGSpeculativeJIT.cpp:
    (JSC::DFG::SpeculativeJIT::compileNewFunction):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182959 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  13. Update fullscreen button visibility on fullscreen change.

    roger_fong@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=143861.
    <rdar://problem/20143218>
    
    Reviewed by Eric Carlson.
    
    * Modules/mediacontrols/mediaControlsApple.js:
    (Controller): There is no need for hasVisualMedia to be a class variable.
    (Controller.prototype.handleReadyStateChange):
    (Controller.prototype.handleFullscreenChange):
    (Controller.prototype.updateFullscreenButtons):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182958 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  14. REGRESSION: SVG does not support link dragging

    dbates@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=141597
    
    Reviewed by Darin Adler.
    
    Source/WebCore:
    
    Fixes an issue where a SVG hyperlink cannot be dragged. We should support
    dragging an SVG A element just as we support dragging an HTML A element.
    
    Test: fast/events/drag-and-drop-link.html
    
    * page/DragController.cpp: Removed explicit include of header Element.h as it will
    be ultimately included by HTMLAnchorElement.h, among other headers.
    (WebCore::isDraggableLink): Added. Extracted code from HitTestResult::isLiveLink().
    (WebCore::DragController::draggableElement): Call WebCore::isDraggableLink() to
    determine whether a element is a hyperlink that can be dragged.
    * page/DragController.h:
    * page/EventHandler.cpp:
    (WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent): Write code in terms of
     WebCore::isDraggableLink().
    * rendering/HitTestResult.cpp:
    (WebCore::HitTestResult::isLiveLink): Deleted.
    * rendering/HitTestResult.h:
    
    Source/WebKit/mac:
    
    Write -[WebElementDictionary _isLiveLink] in terms of WebCore::isDraggableLink().
    
    * Misc/WebElementDictionary.mm:
    (-[WebElementDictionary _isLiveLink]):
    
    LayoutTests:
    
    Add a test to ensure we do not regress dragging of a HTML hyperlink or a SVG hyperlink.
    
    * fast/events/drag-and-drop-link-expected.txt: Added.
    * fast/events/drag-and-drop-link.html: Added.
    * platform/efl/TestExpectations: Mark the test as "failure" since EFL does not support drag-and-drop.
    * platform/gtk/TestExpectations: Mark the test as "failure" until we implement drag-and-drop support for
    GTK+ as part of fixing <https://bugs.webkit.org/show_bug.cgi?id=42194>.
    * platform/ios-simulator/TestExpectations: Skip the test since iOS does not implement
    drag-and-drop support.
    * platform/mac-wk2/TestExpectations: Skip the test until we implement drag-and-drop support in EventSender
    for Mac as part of fixing <https://bugs.webkit.org/show_bug.cgi?id=42194>.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182957 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  15. Unreviewed, rolling out r182912 and r182920.

    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=143881
    
    Build breakage in some configurations (Requested by ap on
    #webkit).
    
    Reverted changesets:
    
    "Force mouse events should go through normal mouse event
    handling code paths"
    https://bugs.webkit.org/show_bug.cgi?id=143749
    http://trac.webkit.org/changeset/182912
    
    http://trac.webkit.org/changeset/182920
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182956 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  16. Fix review comments for https://bugs.webkit.org/show_bug.cgi?id=143590

    said@apple.com authored
    following http://trac.webkit.org/changeset/182876.
    
    Reviewed by Daniel Bates.
    
    * ChangeLog:
    Fixed typo.
            
    * style/StyleFontSizeFunctions.cpp:
    (WebCore::Style::computedFontSizeFromSpecifiedSize):
    Fixed a typo in an enum definition and changed the name of an argument.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182955 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  17. Network Cache: Read resource record and body in parallel

    antti@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=143879
    
    Reviewed by Chris Dumez.
    
    We currently first fetch the record file and then fetch the body blob if needed.
    We can do both operations in parallel to reduce latency.
    
    * NetworkProcess/cache/NetworkCacheFileSystemPosix.h:
    (WebKit::NetworkCache::traverseCacheFiles):
    
        Do all validation in the client.
    
    * NetworkProcess/cache/NetworkCacheStorage.cpp:
    (WebKit::NetworkCache::Storage::synchronize):
    
        Maintain a bloom filter that contains the body blobs to avoid unnecessary IO attempts.
        Delete any unknown file in cache directory.
    
    (WebKit::NetworkCache::Storage::addToRecordFilter):
    
        More informative name for record filter.
    
    (WebKit::NetworkCache::Storage::mayContain):
    (WebKit::NetworkCache::Storage::readRecord):
    (WebKit::NetworkCache::Storage::storeBodyAsBlob):
    (WebKit::NetworkCache::Storage::dispatchReadOperation):
    
        Start record read IO and body blob read IO in parallel.
    
    (WebKit::NetworkCache::Storage::finishReadOperation):
    
        The read is finished when we have both the record and the blob.
    
    (WebKit::NetworkCache::Storage::dispatchWriteOperation):
    (WebKit::NetworkCache::Storage::retrieve):
    (WebKit::NetworkCache::Storage::store):
    (WebKit::NetworkCache::Storage::traverse):
    (WebKit::NetworkCache::Storage::clear):
    (WebKit::NetworkCache::Storage::shrink):
    (WebKit::NetworkCache::Storage::addToContentsFilter): Deleted.
    (WebKit::NetworkCache::Storage::decodeRecord): Deleted.
    * NetworkProcess/cache/NetworkCacheStorage.h:
    (WebKit::NetworkCache::Storage::ReadOperation::ReadOperation):
    
        ReadOperation is now mutable and gathers the read result.
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182954 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  18. Stop installing WebKit2.framework

    andersca@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=143860
    rdar://problem/18298491
    
    Reviewed by Dan Bernstein.
    
    * Configurations/WebKit2.xcconfig:
    Set SKIP_INSTALL=YES for all SDKs except 10.9 where we still need it.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182952 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  19. [GTK] Gardening 17th April.

    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=143870
    
    Unreviewed.
    
    Patch by Marcos Chavarría Teijeiro <chavarria1991@gmail.com> on 2015-04-17
    
    * platform/gtk/TestExpectations:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182950 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  20. [EFL] Unreviewed EFL gardening on 17 April.

    gyuyoung.kim@webkit.org authored
    Mark 5 form tests and 3 navigation tests to failure.
    
    * platform/efl/TestExpectations:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182949 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  21. [GTK] One more unreviewed fix after r182882.

    ossy@webkit.org authored
    * TestWebKitAPI/PlatformGTK.cmake: Added back the WebKit2's forwarding header generator dependency.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182948 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  22. [GStreamer] Silent WebAudio buffers support

    philn@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=143869
    
    Reviewed by Carlos Garcia Campos.
    
    * platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
    (webKitWebAudioSrcLoop): Set gap flag on silent buffers. The audio
    sink can then drop them and avoid un-necessary buffer processing.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182947 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  23. Unreviewed. Fix the build with ENABLE(NETWORK_CACHE) and !ENABLE(SHAR…

    carlosgc@webkit.org authored
    …EABLE_RESOURCE).
    
    * NetworkProcess/cache/NetworkCacheEntry.cpp:
    * NetworkProcess/cache/NetworkCacheFileSystemPosix.h:
    (WebKit::NetworkCache::fileTimes): There's no st_birthtime in Linux.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182946 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  24. [GTK] Unreviewed speculative clean build fix after r182882.

    ossy@webkit.org authored
    TestWebKitAPI's forwarding header generator depended on WeKit2's
    which generated SOUP related forwarding headers too.
    
    This dependency isn't necessary and was removed by r182882 to make
    forwarding header generators parallelizable. But in this case
    TestWebKitAPI's and WebKitTestRunner's forwarding header generator
    should generate SOUP related forwarding headers too similar to EFL.
    
    * TestWebKitAPI/PlatformGTK.cmake:
    * WebKitTestRunner/PlatformGTK.cmake:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182945 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  25. [SOUP] ResourceRequest cache policy is not encoded/decoded in IPC mes…

    carlosgc@webkit.org authored
    …sages
    
    
    https://bugs.webkit.org/show_bug.cgi?id=143867
    
    Reviewed by Sergio Villar Senin.
    
    Encode/Decode the ResourceRequest cache policy.
    
    * Shared/soup/WebCoreArgumentCodersSoup.cpp:
    (IPC::ArgumentCoder<ResourceRequest>::encodePlatformData):
    (IPC::ArgumentCoder<ResourceRequest>::decodePlatformData):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182944 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  26. [SOUP] Redirect to non HTTP destination is broken

    carlosgc@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=143866
    
    Reviewed by Sergio Villar Senin.
    
    Source/WebCore:
    
    This is because we are passing true unconditionally as
    isHTTPFamilyRequest parameter of
    createSoupRequestAndMessageForHandle in continueAfterWillSendRequest.
    We don't actually need to pass isHTTPFamilyRequest parameter to
    createSoupRequestAndMessageForHandle, since it can simply check
    that from the given request.
    
    Covered by unit tets and also cache/disk-cache/disk-cache-redirect-to-data.html.
    
    * platform/network/soup/ResourceHandleSoup.cpp:
    (WebCore::continueAfterWillSendRequest):
    (WebCore::createSoupRequestAndMessageForHandle):
    (WebCore::ResourceHandle::start):
    
    Tools:
    
    Add a unit test to check that redirect to a data URI works.
    
    * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
    (testRedirectToDataURI):
    (serverCallback):
    (beforeAll):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182943 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  27. streams/reference-implementation/readable-stream.html is flaky

    calvaris@igalia.com authored
    https://bugs.webkit.org/show_bug.cgi?id=143778
    
    Unreviewed.
    
    Comment out flaky subtests while working on a more complete
    solution.
    
    The problem with these tests is that they set a timeout before the
    calling done() and this causes some tests to behave
    undeterministically, specilly code related to promise
    resolution. This could even cause indetermination if the tests
    were expected to run correctly.
    
    We think it is better to comment them out and find a more long
    term solution that could involve submitting change requests to the
    reference tests in the spec. This will be tackled in bug 143774.
    
    
    * streams/reference-implementation/readable-stream-expected.txt:
    * streams/reference-implementation/readable-stream-reader-expected.txt:
    * streams/reference-implementation/readable-stream-reader.html:
    * streams/reference-implementation/readable-stream-templated-expected.txt:
    * streams/reference-implementation/readable-stream-templated.html:
    * streams/reference-implementation/readable-stream.html:
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182942 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  28. streams/readablestream-reader.html test should really test collected …

    youenn.fablet@crf.canon.fr authored
    …stream case.
    
    
    https://bugs.webkit.org/show_bug.cgi?id=143818
    
    Reviewed by Darin Adler.
    
    Making the test async so that the stream start async callback is made and the stream be collected.
    
    * streams/readable-stream-reader.html:
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182941 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  29. http/tests/misc/DOMContentLoaded-event.html is flaky

    ap@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=143382
    
    Reviewed by Chris Dumez.
    
    * http/tests/misc/DOMContentLoaded-event-expected.txt:
    * http/tests/misc/DOMContentLoaded-event.html:
    Don't race with a timer, just check if some time passes between DOMContentLoaded and load events.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182940 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  30. Web Inspector: Breakpoint icons should not get pushed off of debugger…

    jonowells@apple.com authored
    … sidebar due to long resource names
    
    
    https://bugs.webkit.org/show_bug.cgi?id=142714
    
    Reviewed by Timothy Hatcher.
    
    Modify the styles for content and group containers inside the debugger sidebar panel's detail sections
    such that the rules "display: table" and "display: table-row-group" no longer apply. This will make
    the file names which use the rule "text-overflow: ellipsis" truncate as expected.
    
    * UserInterface/Views/DebuggerSidebarPanel.css:
    (.sidebar > .panel.navigation.debugger .details-section > .content):
    (.sidebar > .panel.navigation.debugger .details-section.collapsed > .content):
    (.sidebar > .panel.navigation.debugger .details-section > .content > .group):
    (.sidebar > .panel.navigation.debugger .details-section.scripts):
    (.sidebar > .panel.navigation.debugger .details-section.scripts .header):
    (.sidebar > .panel.navigation.debugger .details-section.scripts.collapsed > .content):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182939 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  31. Number.parseInt is not === global parseInt in nightly r182673

    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=143799
    
    Patch by Jordan Harband <ljharb@gmail.com> on 2015-04-16
    Reviewed by Darin Adler.
    
    Source/JavaScriptCore:
    
    Ensuring parseInt === Number.parseInt, per spec
    https://people.mozilla.org/~jorendorff/es6-draft.html#sec-number.parseint
    
    * runtime/CommonIdentifiers.h:
    * runtime/JSGlobalObject.cpp:
    (JSC::JSGlobalObject::init):
    * runtime/JSGlobalObject.h:
    (JSC::JSGlobalObject::parseIntFunction):
    * runtime/NumberConstructor.cpp:
    (JSC::NumberConstructor::finishCreation):
    
    LayoutTests:
    
    * js/number-constructor-expected.txt:
    * js/parseInt-expected.txt:
    * js/script-tests/number-constructor.js:
    * js/script-tests/parseInt.js:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182938 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  32. Changes method of quitting iOS Simulator to be more correct.

    jacob_nielsen@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=143847
    <rdar://problem/20530344>
    
    Reviewed by Darin Adler.
    
    Fixes by addressing the app by ID rather than by name.
    
    * Scripts/webkitdirs.pm:
    (quitIOSSimulator):
    * Scripts/webkitpy/port/ios.py:
    (IOSSimulatorPort.check_sys_deps):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182937 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Something went wrong with that request. Please try again.