Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Branch: master
Commits on Aug 1, 2015
  1. Web Inspector: inherited CSS rules disappear from Styles sidebar whil…

    drousso@apple.com authored
    …e editing
    
    
    https://bugs.webkit.org/show_bug.cgi?id=147441
    
    Reviewed by Timothy Hatcher.
    
    If the user edits a style declaration such that it would dissapear mid-edit, prevent
    the rules panel from refreshing until that editor is blurred.
    
    * UserInterface/Views/CSSStyleDeclarationSection.js:
    (WebInspector.CSSStyleDeclarationSection):
    (WebInspector.CSSStyleDeclarationSection.prototype.get editorActive):
    (WebInspector.CSSStyleDeclarationSection.prototype.get _hasInvalidSelector):
    (WebInspector.CSSStyleDeclarationSection.prototype._editorContentChanged):
    (WebInspector.CSSStyleDeclarationSection.prototype._editorBlurred):
    * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
    (WebInspector.CSSStyleDeclarationTextEditor.prototype._editorBlured):
    (WebInspector.CSSStyleDeclarationTextEditor.prototype._contentChanged):
    * UserInterface/Views/RulesStyleDetailsPanel.js:
    (WebInspector.RulesStyleDetailsPanel):
    (WebInspector.RulesStyleDetailsPanel.prototype._removeSectionWithActiveEditor):
    * UserInterface/Views/StyleDetailsPanel.js:
    (WebInspector.StyleDetailsPanel.prototype._refreshPreservingScrollPosition):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@187714 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  2. Media Session: inform the UI process when the focused Content media e…

    mrajca@apple.com authored
    …lement changes
    
    
    https://bugs.webkit.org/show_bug.cgi?id=147323
    
    Reviewed by Tim Horton.
    
    WebCore:
    * html/HTMLMediaElement.cpp:
    (WebCore::HTMLMediaElement::playInternal): Eventually tell the UI process that the focused Content media element changed.
    * page/ChromeClient.h:
    
    WebKit2:
    * UIProcess/WebPageProxy.cpp:
    (WebKit::WebPageProxy::isPlayingMediaDidChange):
    * UIProcess/WebPageProxy.h:
    * UIProcess/WebPageProxy.messages.in:
    * WebProcess/WebCoreSupport/WebChromeClient.cpp:
    (WebKit::WebChromeClient::focusedContentMediaElementDidChange):
    * WebProcess/WebCoreSupport/WebChromeClient.h:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@187713 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  3. Media Session: give media elements unique IDs https://bugs.webkit.org…

    mrajca@apple.com authored
    …/show_bug.cgi?id=147322
    
    Reviewed by Eric Carlson.
    
    * html/HTMLMediaElement.cpp:
    (WebCore::elementIDsToElements): Create a global map of element IDs to elements.
    (WebCore::HTMLMediaElement::elementWithID): Retrieve the element with the given ID.
    (WebCore::HTMLMediaElement::HTMLMediaElement): Give the element a unique ID.
    (WebCore::HTMLMediaElement::playInternal): Removed whitespace.
    (WebCore::HTMLMediaElement::pauseInternal): Ditto.
    * html/HTMLMediaElement.h:
    (WebCore::HTMLMediaElement::elementID):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@187712 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  4. Adding -expected.png for fast/text/international/arabic-justify.html

    mmaxfield@apple.com authored
    * platform/mac-yosemite/fast/text/international/arabic-justify-expected.png: Added
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@187711 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  5. Media Session: add test to ensure that switching media sessions pause…

    mrajca@apple.com authored
    …s elements
    
    
    https://bugs.webkit.org/show_bug.cgi?id=147493
    
    Reviewed by Eric Carlson.
    
    * media/session/switching-sessions-expected.txt: Added.
    * media/session/switching-sessions.html: Added.
    * platform/mac/TestExpectations: Media Session support is disabled by default.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@187710 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  6. Fix the build

    mmaxfield@apple.com authored
    Unreviewed.
    
    * platform/graphics/mac/FontCacheMac.mm:
    (WebCore::lookupCTFont):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@187709 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  7. Web Inspector: Autocomplete: Undo (Cmd+Z) doesn't work as expected

    drousso@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=147316
    
    Reviewed by Timothy Hatcher.
    
    Instead of replacing the text for a completion, which messes up the undo history, add
    a unique marker that contains the remaining text for the current completion.
    
    * UserInterface/Controllers/CodeMirrorCompletionController.js:
    (WebInspector.CodeMirrorCompletionController.prototype._createCompletionHintMarker):
    (WebInspector.CodeMirrorCompletionController.prototype._applyCompletionHint.update):
    (WebInspector.CodeMirrorCompletionController.prototype._applyCompletionHint):
    (WebInspector.CodeMirrorCompletionController.prototype._removeCompletionHint.update):
    (WebInspector.CodeMirrorCompletionController.prototype._removeCompletionHint):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@187708 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  8. [OS X] Migrate to CTFontCreateForCharactersWithLanguage from [NSFont …

    mmaxfield@apple.com authored
    …findFontLike:forString:withRange:inLanguage]
    
    
    https://bugs.webkit.org/show_bug.cgi?id=147483
    
    Reviewed by Dean Jackson.
    
    [NSFont findFontLike:forString:withRange:inLanguage] doesn't properly handle its last argument. In
    addition, we want to be moving away from NSFont in the first place and on to Core Text. This new
    CoreText function correctly handles its language argument, which is required for language-specific
    font fallback.
    
    No new tests because there is no behavior change.
    
    * platform/graphics/FontCache.cpp:
    (WebCore::FontCache::purgeInactiveFontData):
    * platform/graphics/FontCache.h:
    (WebCore::FontCache::platformPurgeInactiveFontData):
    * platform/graphics/mac/FontCacheMac.mm:
    (WebCore::fallbackDedupSet):
    (WebCore::FontCache::platformPurgeInactiveFontData):
    (WebCore::lookupCTFont):
    (WebCore::FontCache::systemFallbackForCharacters):
    * platform/spi/cocoa/CoreTextSPI.h:
    * platform/spi/mac/NSFontSPI.h:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@187707 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  9. Drop dummy Timer callbacks

    cdumez@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=147516
    
    Reviewed by Alexey Proskuryakov.
    
    Drop dummy Timer callbacks in the code base. A lot of Timer callbacks
    do nothing else beside calling a particular method. In such case, we
    can use the called method as Timer callback instead.
    
    Source/WebCore:
    
    * css/FontLoader.cpp:
    (WebCore::FontLoader::FontLoader):
    * css/FontLoader.h:
    * dom/Document.cpp:
    (WebCore::Document::Document):
    (WebCore::Document::styleRecalcTimerFired): Deleted.
    (WebCore::Document::domCookieCacheExpiryTimerFired): Deleted.
    * dom/Document.h:
    * html/MediaController.cpp:
    (MediaController::MediaController):
    (MediaController::timeupdateTimerFired): Deleted.
    * html/MediaController.h:
    * loader/cache/CachedResource.cpp:
    (WebCore::CachedResource::CachedResource):
    * loader/cache/CachedResourceLoader.cpp:
    (WebCore::CachedResourceLoader::CachedResourceLoader):
    (WebCore::CachedResourceLoader::garbageCollectDocumentResourcesTimerFired): Deleted.
    * loader/cache/CachedResourceLoader.h:
    * loader/cache/MemoryCache.cpp:
    (WebCore::MemoryCache::MemoryCache):
    (WebCore::MemoryCache::pruneTimerFired): Deleted.
    * loader/cache/MemoryCache.h:
    * page/EventSource.cpp:
    (WebCore::EventSource::EventSource):
    (WebCore::EventSource::connectTimerFired): Deleted.
    * page/EventSource.h:
    * page/FrameView.cpp:
    (WebCore::FrameView::FrameView):
    (WebCore::FrameView::delayedScrollEventTimerFired): Deleted.
    (WebCore::FrameView::postLayoutTimerFired): Deleted.
    * page/FrameView.h:
    * page/scrolling/ios/ScrollingCoordinatorIOS.h:
    * page/scrolling/ios/ScrollingCoordinatorIOS.mm:
    (WebCore::ScrollingCoordinatorIOS::ScrollingCoordinatorIOS):
    (WebCore::ScrollingCoordinatorIOS::scrollingStateTreeCommitterTimerFired): Deleted.
    * page/scrolling/mac/ScrollingCoordinatorMac.h:
    * page/scrolling/mac/ScrollingCoordinatorMac.mm:
    (WebCore::ScrollingCoordinatorMac::ScrollingCoordinatorMac):
    (WebCore::ScrollingCoordinatorMac::scrollingStateTreeCommitterTimerFired): Deleted.
    * platform/graphics/FontCache.cpp:
    (WebCore::FontCache::FontCache):
    (WebCore::FontCache::purgeTimerFired): Deleted.
    * platform/graphics/FontCache.h:
    * platform/graphics/ShadowBlur.cpp:
    (WebCore::ScratchBuffer::ScratchBuffer):
    (WebCore::ScratchBuffer::timerFired): Deleted.
    * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
    * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
    (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::MediaPlayerPrivateMediaSourceAVFObjC):
    (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekTimerFired): Deleted.
    
    Source/WebKit/mac:
    
    * Plugins/WebNetscapePluginStream.h:
    * Plugins/WebNetscapePluginStream.mm:
    (WebNetscapePluginStream::WebNetscapePluginStream):
    (WebNetscapePluginStream::deliverDataTimerFired): Deleted.
    
    Source/WebKit2:
    
    * WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
    * WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
    (WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
    (WebKit::RemoteLayerTreeDrawingArea::layerFlushTimerFired): Deleted.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@187706 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  10. Removed pointSize from _addMarkersToList

    mdaiter@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=147515
    
    Reviewed by Eric Carlson.
    
    * editing/cocoa/HTMLConverter.mm:
    (HTMLConverter::_addMarkersToList): Deleted.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@187704 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  11. Prepare for VS2015

    achristensen@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=146579
    
    Reviewed by Jon Honeycutt.
    
    Source/JavaScriptCore:
    
    * heap/Heap.h:
    Fix compiler error by explicitly casting zombifiedBits to the size of a pointer.
    
    Source/WebCore:
    
    * WebCore.vcxproj/build-generated-files.pl:
    Find a correct preprocessor when using VS2015.
    
    Source/WTF:
    
    * wtf/StdLibExtras.h:
    (std::exchange):
    Added preprocessor macros around functions implemented in VS2015's standard library.
    
    Tools:
    
    * WinLauncher/stdafx.h:
    Define __STDC_LIMIT_MACROS to have access to INTMAX_MAX.
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@187702 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  12. Unreviewed gardening. Skip Media Sessions tests, the feature is not y…

    joepeck@webkit.org authored
    …et enabled.
    
    * TestExpectations:
    * platform/efl/TestExpectations:
    * platform/mac/TestExpectations:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@187701 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  13. Web Inspector: Scrolling "jumps" in console

    drousso@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=147482
    
    Reviewed by Joseph Pecoraro.
    
    Removed focus call on messageElement.
    
    * UserInterface/Views/LogContentView.js:
    (WebInspector.LogContentView):
    (WebInspector.LogContentView.prototype._mousedown): Deleted.
    (WebInspector.LogContentView.prototype._didFocus): Deleted.
    (WebInspector.LogContentView.prototype._didBlur): Deleted.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@187700 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  14. Unreviewed gardening. Update inspector test skips based on bots.

    joepeck@webkit.org authored
    * TestExpectations:
    * platform/gtk/TestExpectations:
    * platform/win/TestExpectations:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@187699 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  15. [WK2][NetworkCache] Drop HTTP method from NetworkCache::Key

    cdumez@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=143348
    
    Reviewed by Antti Koivisto.
    
    Drop HTTP method from NetworkCache::Key as we only cache GET responses
    for now. Even when we start caching HEAD responses, we likely will not
    want the method to be part of the key because:
    - A HEAD response can be used to update the headers of a previously cached response to GET
    - A cached GET response may be used to satisfy subsequent HEAD requests
    
    * NetworkProcess/cache/NetworkCache.cpp:
    (WebKit::NetworkCache::makeCacheKey):
    * NetworkProcess/cache/NetworkCacheKey.cpp:
    (WebKit::NetworkCache::Key::Key):
    (WebKit::NetworkCache::Key::operator==):
    (WebKit::NetworkCache::Key::decode):
    (WebKit::NetworkCache::Key::operator=): Deleted.
    (WebKit::NetworkCache::Key::computeHash): Deleted.
    (WebKit::NetworkCache::Key::encode): Deleted.
    * NetworkProcess/cache/NetworkCacheKey.h:
    (WebKit::NetworkCache::Key::method): Deleted.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@187698 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  16. [iOS] use a media-specific user gesture check

    eric.carlson@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=147509
    
    Reviewed by Tim Horton.
    
    Change an enum name added in r187688.
    
    * dom/UserGestureIndicator.cpp:
    (WebCore::isDefinite): DefinitelyProcessingMediaUserGesture -> DefinitelyProcessingPotentialUserGesture
    (WebCore::UserGestureIndicator::processingUserGestureForMedia): Ditto.
    * dom/UserGestureIndicator.h: Ditto.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@187694 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  17. [Cocoa] Latin quotes are used with the system font on Chinese devices

    mmaxfield@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=147504
    
    Reviewed by Dean Jackson.
    
    The system font has some fancy logic regarding character selection which requires
    using Core Text for glyph selection.
    
    No new tests because tests can't change the system language of the device.
    
    * platform/graphics/mac/GlyphPageMac.cpp:
    (WebCore::shouldUseCoreText):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@187693 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Commits on Jul 31, 2015
  1. Web Inspector: Unskip / Unflake inspector tests after r187627

    joepeck@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=147503
    
    Reviewed by Brian Burg.
    
    Source/WebInspectorUI:
    
    * UserInterface/Base/Test.js:
    (InspectorTest.completeTest):
    (InspectorTest.completeTest.signalCompletionToTestPage): Deleted.
    (InspectorTest.testPageDidLoad):
    Instead of immediately resending results if completeTest was called
    during a reload before the load has completed, we just set a flag
    to complete the test when the load completes. This consistently
    resends the output to the new page for test output.
    
    (InspectorTest._resendResults):
    Delete clear results. If the page had logged anything directly on
    the page side (using InspectorTestProxy) this clearMessages would
    have deleted those messages and not been able to recreate them.
    Clearing messages wasn't really serving a purpose.
    
    LayoutTests:
    
    * TestExpectations:
    * platform/mac-wk2/TestExpectations:
    * platform/mac/TestExpectations:
    Unskip and unflake inspector tests.
    
    * http/tests/inspector/inspector-test.js:
    (InspectorTestProxy.addResult):
    Simplify with the new append API.
    
    (InspectorTestProxy.clearResults): Deleted.
    Delete, as it is no longer used.
    
    * inspector/debugger/probe-manager-add-remove-actions-expected.txt:
    Include output that was getting erronously cleared by clearResults
    which we removed.
    
    * inspector/dom/highlightSelector-expected.txt:
    * inspector/dom/highlightSelector.html:
    Make this test more reliable when run with other tests.
    Never assume the frame id for the main frame or sub frame,
    instead compute them and mask them in the output.
    
    * inspector/dom/resources/highlightSelector-iframe.html: Renamed from LayoutTests/inspector/dom/highlightSelector-iframe.html.
    Move the non-test iframe html resource into a sub-folder
    so it won't be treated like an actual test.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@187692 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  2. Source/WebCore:

    cdumez@apple.com authored
    Coalesce authentication credential requests
    https://bugs.webkit.org/show_bug.cgi?id=128006
    <rdar://problem/16839069>
    
    Reviewed by Alexey Proskuryakov.
    
    Export symbol for ProtectionSpace::compare() so it can be called from
    WebKit2.
    
    * platform/network/ProtectionSpaceBase.h:
    
    Source/WebKit2:
    Coalesce concurrent authentication challenges for the same ProtectionSpace
    https://bugs.webkit.org/show_bug.cgi?id=147496
    <rdar://problem/16839069>
    
    Reviewed by Alexey Proskuryakov.
    
    Coalesce concurrent authentication challenges for the same ProtectionSpace.
    Ideally, this would be done in the network layer but short term, this will
    make sure the user no longer gets repeating authentication dialogs for the
    same protection space.
    
    This gets rid of a long-standing bug in WebKit / Safari where visiting a
    site using HTTP authentication would pop up one authentication dialog for
    each subresource being loaded from the network (especially when the main
    resource is loaded from the cache).
    
    * Shared/Authentication/AuthenticationManager.cpp:
    (WebKit::canCoalesceChallenge):
    (WebKit::AuthenticationManager::addChallengeToChallengeMap):
    (WebKit::AuthenticationManager::shouldCoalesceChallenge):
    (WebKit::AuthenticationManager::coalesceChallengesMatching):
    (WebKit::AuthenticationManager::didReceiveAuthenticationChallenge):
    (WebKit::AuthenticationManager::useCredentialForChallenge):
    (WebKit::AuthenticationManager::useCredentialForSingleChallenge):
    (WebKit::AuthenticationManager::continueWithoutCredentialForChallenge):
    (WebKit::AuthenticationManager::continueWithoutCredentialForSingleChallenge):
    (WebKit::AuthenticationManager::cancelChallenge):
    (WebKit::AuthenticationManager::cancelSingleChallenge):
    (WebKit::AuthenticationManager::performDefaultHandling):
    (WebKit::AuthenticationManager::performDefaultHandlingForSingleChallenge):
    (WebKit::AuthenticationManager::rejectProtectionSpaceAndContinue):
    (WebKit::AuthenticationManager::rejectProtectionSpaceAndContinueForSingleChallenge):
    (WebKit::AuthenticationManager::AuthenticationManager): Deleted.
    * Shared/Authentication/AuthenticationManager.h:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@187691 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  3. Unreviewed gardening. Skip more inspector tests on Windows.

    joepeck@webkit.org authored
    It may be that no inspector tests are working on Windows,
    if that is the case we may move to skipping all of them
    and investigate unskipping in chunks.
    
    * platform/win/TestExpectations:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@187690 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  4. Web Inspector: Convert timeline view classes to ES6 classes

    burg@cs.washington.edu authored
    https://bugs.webkit.org/show_bug.cgi?id=147381
    
    Reviewed by Joseph Pecoraro.
    
    Along the way, inline a few style class names.
    
    Elided mechanical changes from the Changelog.
    
    * UserInterface/Views/LayoutTimelineOverviewGraph.js:
    * UserInterface/Views/LayoutTimelineView.js:
    * UserInterface/Views/LinearTimelineOverview.js:
    * UserInterface/Views/NetworkTimelineOverviewGraph.js:
    * UserInterface/Views/NetworkTimelineView.js:
    * UserInterface/Views/OverviewTimelineView.js:
    * UserInterface/Views/RenderingFrameTimelineOverview.js:
    * UserInterface/Views/RenderingFrameTimelineOverviewGraph.js:
    * UserInterface/Views/RenderingFrameTimelineView.js:
    * UserInterface/Views/ScriptTimelineOverviewGraph.js:
    * UserInterface/Views/ScriptTimelineView.js:
    * UserInterface/Views/TimelineOverview.js:
    * UserInterface/Views/TimelineOverviewGraph.js:
    * UserInterface/Views/TimelineRecordBar.js:
    * UserInterface/Views/TimelineRecordFrame.js:
    * UserInterface/Views/TimelineRecordingContentView.js:
    * UserInterface/Views/TimelineRuler.js:
    * UserInterface/Views/TimelineTabContentView.js:
    * UserInterface/Views/TimelineView.js:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@187689 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  5. [iOS] use a media-specific user gesture check

    eric.carlson@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=147509
    
    Reviewed by Jer Noble.
    
    * bindings/js/ScriptController.cpp:
    (WebCore::ScriptController::processingUserGestureForMedia): New.
    * bindings/js/ScriptController.h:
    
    * dom/UserGestureIndicator.cpp:
    (WebCore::isDefinite): Allow DefinitelyProcessingMediaUserGesture.
    (WebCore::UserGestureIndicator::processingUserGestureForMedia): New.
    * dom/UserGestureIndicator.h:
    
    * html/HTMLMediaElement.cpp:
    (WebCore::HTMLMediaElement::load): Use ScriptController::processingUserGestureForMedia instead of 
      ScriptController::processingUserGesture
    (WebCore::HTMLMediaElement::play): Ditto.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@187688 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  6. Crashes under HTMLMediaElement::updateActiveTextTrackCues() when dest…

    akling@apple.com authored
    …roying CachedPage.
    
    <https://webkit.org/b/147506>
    <rdar://problem/21939014>
    
    Reviewed by Chris Dumez.
    
    Don't mess with the media element's text tracks below its ActiveDOMObject::stop()
    implementation, since that may cause DOM mutations.
    
    I don't have a repro or a test for this, but plenty of crash logs to indicate that
    we're getting ourselves into trouble by modifying the DOM during CachedPage teardown.
    
    * html/HTMLMediaElement.cpp:
    (WebCore::HTMLMediaElement::configureTextTrackDisplay):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@187687 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  7. [iOS] DOMNode preview snapshot rects are wrong for user-select: none …

    timothy_horton@apple.com authored
    …links
    
    
    https://bugs.webkit.org/show_bug.cgi?id=147513
    <rdar://problem/22083354>
    
    Reviewed by Simon Fraser.
    
    * bindings/objc/DOM.mm:
    (-[DOMNode getPreviewSnapshotImage:andRects:]):
    Use the same code as WebKit2 to compute the fallback rect (if TextIndicator fails),
    asking the RenderObject (or RenderImage) for its bounding box instead of using the
    (often wrong) Range bounding rect.
    
    Make sure to use the fallback rect *any* time TextIndicator fails (before
    we would return no rects at all if TextIndicator::createWithRange returned null,
    and the fallback rect if it returned with an empty image).
    
    Inverse-page-scale the margin, to match the appearance in WebKit2.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@187686 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  8. [SVG -> OTF Converter] Crash when converting Arabic fonts

    mmaxfield@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=147510
    
    Reviewed by Anders Carlsson.
    
    Source/WebCore:
    
    SVGToOTFFontConverter::compareCodepointsLexicographically() wasn't transitive.
    
    Test: fast/text/arabic-duplicate-glyph-font.html
    
    * svg/SVGToOTFFontConversion.cpp:
    (WebCore::SVGToOTFFontConverter::compareCodepointsLexicographically):
    
    LayoutTests:
    
    * fast/text/arabic-duplicate-glyph-font-expected.txt: Added.
    * fast/text/arabic-duplicate-glyph-font.html: Added.
    * fast/text/resources/arabic-duplicate-glyph-font.svg: Added.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@187685 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  9. Rename AVPlayerLayerView to _AVPlayerLayerView.

    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=147399
    
    Patch by Jeremy Jones <jeremyj@apple.com> on 2015-07-31
    Reviewed by Eric Carlson.
    
    Change class name AVPlayerLayerView to match change in AVKit SPI.
    This prevents conflicts with 3rd party apps.
    
    * platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
    (WebAVPlayerLayerView_dealloc):
    (getWebAVPlayerLayerViewClass):
    * platform/spi/cocoa/AVKitSPI.h:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@187684 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  10. Unreviewed parameter name typo fix.

    joepeck@webkit.org authored
    * UIProcess/API/Cocoa/WKPreferences.mm:
    (-[WKPreferences _setHiddenPageDOMTimerThrottlingEnabled:]):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@187682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  11. ImageBufferDataCG should not add IOSurfaces to the pool

    cdumez@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=147494
    
    Reviewed by Tim Horton.
    
    ImageBufferDataCG should not add IOSurfaces to the pool as it is not
    safe. IOSurfaceIsInUse() does not return accurate result for those
    surfaces.
    
    This is a partial revert of r181301.
    
    * platform/graphics/cg/ImageBufferDataCG.cpp:
    (WebCore::ImageBufferData::~ImageBufferData): Deleted.
    * platform/graphics/cg/ImageBufferDataCG.h:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@187681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  12. ES6 class syntax should use block scoping

    saambarati1@gmail.com authored
    https://bugs.webkit.org/show_bug.cgi?id=142567
    
    Reviewed by Geoffrey Garen.
    
    Source/JavaScriptCore:
    
    We treat class declarations like we do "let" declarations.
    The class name is under TDZ until the class declaration
    statement is evaluated. Class declarations also follow
    the same rules as "let": No duplicate definitions inside
    a lexical environment.
    
    * parser/ASTBuilder.h:
    (JSC::ASTBuilder::createClassDeclStatement):
    * parser/Parser.cpp:
    (JSC::Parser<LexerType>::parseClassDeclaration):
    * tests/stress/class-syntax-block-scoping.js: Added.
    (assert):
    (truth):
    (.):
    * tests/stress/class-syntax-definition-semantics.js: Added.
    (shouldBeSyntaxError):
    (shouldNotBeSyntaxError):
    (truth):
    * tests/stress/class-syntax-tdz.js:
    (assert):
    (shouldThrowTDZ):
    (truth):
    (.):
    
    LayoutTests:
    
    * js/class-constructor-return-expected.txt:
    * js/class-syntax-call-expected.txt:
    * js/class-syntax-declaration-expected.txt:
    * js/class-syntax-default-constructor-expected.txt:
    * js/class-syntax-extends-expected.txt:
    * js/class-syntax-name-expected.txt:
    * js/class-syntax-super-expected.txt:
    * js/script-tests/class-constructor-return.js:
    (shouldThrow):
    (shouldNotThrow):
    (shouldBeTrue):
    (shouldBeFalse):
    * js/script-tests/class-syntax-call.js:
    (A):
    (B):
    (shouldThrow):
    (shouldNotThrow):
    * js/script-tests/class-syntax-declaration.js:
    (shouldThrow):
    (shouldNotThrow):
    (shouldBe):
    * js/script-tests/class-syntax-default-constructor.js:
    (shouldThrow):
    (shouldBe):
    (shouldBeTrue):
    (assert):
    (A):
    (B):
    * js/script-tests/class-syntax-extends.js:
    (shouldThrow):
    (shouldNotThrow):
    (shouldBe):
    (shouldBeTrue):
    (Base):
    (Base.prototype.baseMethod):
    * js/script-tests/class-syntax-name.js:
    (shouldThrow):
    (shouldNotThrow):
    (shouldBe):
    (shouldBeTrue):
    (runTestShouldBe):
    * js/script-tests/class-syntax-super.js:
    (shouldThrow):
    (shouldNotThrow):
    (shouldBe):
    (shouldBeTrue):
    (shouldBeFalse):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@187680 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  13. Implement WebAssembly module parser

    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=147293
    
    Patch by Sukolsak Sakshuwong <sukolsak@gmail.com> on 2015-07-31
    Reviewed by Mark Lam.
    
    Re-landing after fix for the "..\..\jsc.cpp(46): fatal error C1083: Cannot open
    include file: 'JSWASMModule.h'" issue on Windows.
    
    Implement WebAssembly module parser for WebAssembly files produced by pack-asmjs
    <https://github.com/WebAssembly/polyfill-prototype-1>. This patch only checks
    the magic number at the beginning of the files. Parsing of the rest will be
    implemented in a subsequent patch.
    
    * CMakeLists.txt:
    * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
    * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
    * JavaScriptCore.xcodeproj/project.pbxproj:
    * jsc.cpp:
    (GlobalObject::finishCreation):
    (functionLoadWebAssembly):
    * parser/SourceProvider.h:
    (JSC::WebAssemblySourceProvider::create):
    (JSC::WebAssemblySourceProvider::data):
    (JSC::WebAssemblySourceProvider::WebAssemblySourceProvider):
    * runtime/JSGlobalObject.cpp:
    (JSC::JSGlobalObject::init):
    (JSC::JSGlobalObject::visitChildren):
    * runtime/JSGlobalObject.h:
    (JSC::JSGlobalObject::wasmModuleStructure):
    * wasm/WASMMagicNumber.h: Added.
    * wasm/WASMModuleParser.cpp: Added.
    (JSC::WASMModuleParser::WASMModuleParser):
    (JSC::WASMModuleParser::parse):
    (JSC::WASMModuleParser::parseModule):
    (JSC::parseWebAssembly):
    * wasm/WASMModuleParser.h: Added.
    * wasm/WASMReader.cpp: Added.
    (JSC::WASMReader::readUnsignedInt32):
    (JSC::WASMReader::readFloat):
    (JSC::WASMReader::readDouble):
    * wasm/WASMReader.h: Added.
    (JSC::WASMReader::WASMReader):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@187677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  14. CRASH at WebCore::TaskDispatcher<WebCore::ScriptExecutionContext>::p…

    jer.noble@apple.com authored
    …ostTask + 38
    
     https://bugs.webkit.org/show_bug.cgi?id=147485
    
     Rubber-stamped by Joseph Pecoraro.
    
     Follow-up test crash fix: call superclass's contextDestroyed() which allows the
     m_scriptExecutionContext variable to be cleared.
    
     * html/HTMLMediaElement.cpp:
     (WebCore::HTMLMediaElement::contextDestroyed):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@187675 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  15. REGRESSION (r174791): Returning a zombie NSImage from sharingService:…

    beidson@apple.com authored
    …transitionImageForShareItem:contentRect:
    
    <rdar://problem/22060183> and https://bugs.webkit.org/show_bug.cgi?id=147497
    
    Reviewed by Tim Horton.
    
    * WebCoreSupport/WebContextMenuClient.mm:
    (WebContextMenuClient::imageForCurrentSharingServicePickerItem): Don't return what is basically a temporary NSImage.
      Instead do a [[retain] autorelease] on it while still valid.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@187669 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  16. Only generate "themeWin*" UserAgentStyleSheet constants for Windows b…

    commit-queue@webkit.org authored
    …uilds
    
    
    https://bugs.webkit.org/show_bug.cgi?id=147378
    
    Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-07-31
    Reviewed by Alex Christensen.
    
    * DerivedSources.make:
    Only include windows user agent style sheets for Windows OSes.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@187668 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  17. Prepare for debug CMake builds on Windows.

    achristensen@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=147484
    
    Reviewed by Tim Horton.
    
    .:
    
    * Source/cmake/OptionsWindows.cmake:
    Don't use debug runtimes in debug builds because the dependencies are only built with multithreaded runtimes.
    
    Source/WebCore:
    
    In order to get debug builds to link on Windows with CMake, we will need to use AllInOnes.
    This patch includes more files in the AllInOnes and removes some duplicate code.
    
    * WebCore.vcxproj/WebCore.vcxproj:
    * bindings/js/JSBindingsAllInOne.cpp:
    * css/CSSAllInOne.cpp:
    Many files were added to the AllInOne files.  They should not be included in the Visual Studio solutions.
    * css/CSSCalculationValue.cpp:
    (WebCore::CSSCalcValue::create):
    Use CSSParserString::equalIgnoringCase to avoid ambiguous calls to overloaded functions.
    * css/StyleResolver.cpp:
    (WebCore::StyleResolver::pseudoStyleRulesForElement):
    (WebCore::shouldApplyPropertyInParseOrder):
    (WebCore::convertToFloatLength): Deleted.
    * css/TransformFunctions.cpp:
    (WebCore::transformOperationType):
    (WebCore::convertToFloatLength):
    * css/TransformFunctions.h:
    Removed duplicate convertToFloatLength function.
    * html/HTMLElementsAllInOne.cpp:
    * rendering/FlowThreadController.cpp:
    (WebCore::FlowThreadController::updateNamedFlowsLayerListsIfNeeded):
    (WebCore::compareZIndexFlowThreadController): Renamed from compareZIndex to prevent naming conflicts.
    (WebCore::FlowThreadController::collectFixedPositionedLayers):
    (WebCore::compareZIndex): Deleted.
    * rendering/RenderLayer.cpp:
    (WebCore::RenderLayer::shouldRepaintAfterLayout):
    (WebCore::compositedWithOwnBackingStore):
    * rendering/RenderLayer.h:
    * rendering/RenderLayerBacking.cpp:
    (WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
    (WebCore::descendantLayerPaintsIntoAncestor):
    (WebCore::RenderLayerBacking::paintIntoLayer):
    (WebCore::RenderLayerBacking::paintContents):
    (WebCore::compositedWithOwnBackingStore): Deleted.
    Removed duplicate compositedWithOwnBackingStore.
    (WebCore::paintScrollbar): Deleted duplicate function.
    * rendering/RenderLayerCompositor.cpp:
    (WebCore::RenderLayerCompositor::requiresScrollLayer):
    (WebCore::paintScrollbar):
    * rendering/RenderLayerCompositor.h:
    * rendering/RenderingAllInOne.cpp:
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@187659 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  18. CRASH at WebCore::TaskDispatcher<WebCore::ScriptExecutionContext>::po…

    jer.noble@apple.com authored
    …stTask + 38
    
    
    https://bugs.webkit.org/show_bug.cgi?id=147485
    
    Reviewed by Eric Carlson.
    
    CrashLogs indicate a use-after-free of the ScriptExecutionContext (i.e., Document) used by
    the GenericTaskQueue objects owned by HTMLMediaElement. When the ScriptExecutionContext
    notifies its ActiveDOMObjects that it is about to be destroyed, close() the
    GenericTaskQueues so that they can no longer accept new tasks.
    
    Previously, enqueueing a task on a closed GenericTaskQueue ASSERTed in debug builds, but
    silently succeeded in release builds. Calling enqueueTask() on a  closed GenericTaskQueue is
    now a no-op.
    
    * html/HTMLMediaElement.cpp:
    (WebCore::HTMLMediaElement::contextDestroyed):
    * html/HTMLMediaElement.h:
    * platform/GenericTaskQueue.h:
    (WebCore::GenericTaskQueue::enqueueTask):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@187655 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Something went wrong with that request. Please try again.