Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
branch: master
Commits on Mar 30, 2015
  1. Avoid using hardcoded values for JSValue::Int32Tag, if possible.

    peavo@outlook.com authored
    https://bugs.webkit.org/show_bug.cgi?id=143134
    
    Reviewed by Geoffrey Garen.
    
    * jit/JSInterfaceJIT.h:
    * jit/Repatch.cpp:
    (JSC::tryCacheGetByID):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182151 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  2. Swipe snapshot removed too early (jumps around) on arstechnica and NYT

    timothy_horton@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=143199
    <rdar://problem/18420467>
    
    Reviewed by Dan Bernstein.
    
    Make ViewGestureControllerIOS's snapshot removal timing behave more like the Mac version.
    
    * UIProcess/API/Cocoa/WKWebView.mm:
    (-[WKWebView _didCommitLayerTree:]):
    Let ViewGestureController know when the page has finished state restoration.
    
    (-[WKWebView _didFinishLoadForMainFrame]):
    (-[WKWebView _didSameDocumentNavigationForMainFrame:]):
    Forward these to ViewGestureController.
    
    * UIProcess/API/Cocoa/WKWebViewInternal.h:
    * UIProcess/ios/PageClientImplIOS.mm:
    (WebKit::PageClientImpl::didFinishLoadForMainFrame):
    Forward didFinishLoadForMainFrame to WKWebView.
    
    * UIProcess/ios/ViewGestureControllerIOS.mm:
    (WebKit::ViewGestureController::ViewGestureController):
    (WebKit::ViewGestureController::endSwipeGesture):
    Split the swipe snapshot removal state into a bunch of bools.
    
    (WebKit::ViewGestureController::willCommitPostSwipeTransitionLayerTree):
    (WebKit::ViewGestureController::setRenderTreeSize):
    (WebKit::ViewGestureController::removeSwipeSnapshotIfReady):
    (WebKit::ViewGestureController::removeSwipeSnapshot):
    Unify the snapshot removal logic into one function; removeSwipeSnapshotIfReady
    completely owns the decision. For now, we're waiting for everything, but
    we can do better in the future (using firstVisuallyNonEmptyLayout like Mac used to).
    
    (WebKit::ViewGestureController::didRestoreScrollPosition):
    (WebKit::ViewGestureController::didFinishLoadForMainFrame):
    (WebKit::ViewGestureController::didSameDocumentNavigationForMainFrame):
    (WebKit::ViewGestureController::activeLoadMonitoringTimerFired):
    Add more conditions for swipe snapshot removal. We'll now wait for
    didFinishLoadForMainFrame (or didSameDocumentNavigationForMainFrame),
    for active loads to finish, and for the scroll position to be restored.
    This brings the iOS implementation in line with the slightly better Mac
    implementation, and also sets the stage for deduplication of all of this code.
    
    * UIProcess/mac/ViewGestureController.h:
    * UIProcess/mac/ViewGestureControllerMac.mm:
    (WebKit::ViewGestureController::ViewGestureController):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182150 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  3. Rebaseline accessibility/aria-toggle-button-with-title.html

    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=143229
    
    Unreviewed.
    
    Revision r182012 updates the way a role=button + aria-pressed object should be exposed as AXCheckbox. We need to create a new baseline.
    
    Patch by Marcos Chavarría Teijeiro <chavarria1991@gmail.com> on 2015-03-30
    
    * platform/gtk/accessibility/aria-toggle-button-with-title-expected.txt: Added.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182149 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  4. REGRESSION: js/regress/inline-arguments-local-escape.html is flaky

    fpizlo@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=143104
    
    Reviewed by Geoffrey Garen.
    
    Created a test that is a 100% repro of the flaky failure. This test is called
    get-my-argument-by-val-for-inlined-escaped-arguments.js. It fails all of the time because it
    always causes the compiler to emit a GetMyArgumentByVal of the arguments object returned by
    the inlined function. Other than that, it's the same as inline-arguments-local-escape.
    
    Also created three more tests for three similar, but not identical, failures.
    
    Then fixed the bug: PreciseLocalClobberize was assuming that if we read(Stack) then we are
    only reading those parts of the stack that are relevant to the current semantic code origin.
    That's false after ArgumentsEliminationPhase - we might have operations on phantom arguments,
    like GetMyArgumentByVal, ForwardVarargs, CallForwardVarargs, and ConstructForwardVarargs, that
    read parts of the stack associated with the inline call frame for the phantom arguments. This
    may not be subsumed by the current semantic origin's stack area in cases that the arguments
    were allowed to "locally" escape.
    
    The higher-order lesson here is that in DFG SSA IR, the current semantic origin's stack area
    is not really a meaningful concept anymore. It is only meaningful for nodes that will read
    the stack due to function.arguments, but there are a bunch of other ways that we could also
    read the stack and those operations may read any stack slot. I believe that this change makes
    PreciseLocalClobberize right: it will refine a read(Stack) from Clobberize correctly by casing
    on node type. In future, if we add a read(Stack) to Clobberize, we'll have to make sure that
    readTop() in PreciseLocalClobberize does the right thing.
    
    * dfg/DFGClobberize.h:
    (JSC::DFG::clobberize):
    * dfg/DFGPreciseLocalClobberize.h:
    (JSC::DFG::PreciseLocalClobberizeAdaptor::readTop):
    * dfg/DFGPutStackSinkingPhase.cpp:
    * tests/stress/call-forward-varargs-for-inlined-escaped-arguments.js: Added.
    * tests/stress/construct-forward-varargs-for-inlined-escaped-arguments.js: Added.
    * tests/stress/forward-varargs-for-inlined-escaped-arguments.js: Added.
    * tests/stress/get-my-argument-by-val-for-inlined-escaped-arguments.js: Added.
    * tests/stress/real-forward-varargs-for-inlined-escaped-arguments.js: Added.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182148 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  5. [CSS Grid Layout] Upgrade align-self and align-items parsing to CSS 3

    jfernandez@igalia.com authored
    https://bugs.webkit.org/show_bug.cgi?id=133359
    
    Reviewed by David Hyatt.
    
    From Blink r164817 and r165264 by <jchaffraix@chromium.org>
    
    Source/WebCore:
    
    Broaden justify-self's parsing name
    
    This is in preparation of migrating align-self, align-items
    and justify-items to the CSS 3 Alignment syntax.
    
    The current naming was too tied to justify-self and needs to
    be broadened. This will reduce the follow-up implementations'
    patches.
    
    Upgrade align-self and align-items parsing to CSS 3
    
    This change migrates the 2 properties to the CSS 3 Alignment
    parsing. The new parsing is identical to how we parse
    'justify-self'. The 2 properties need to be migrated together
    as they are used in tandem in CSSComputedStyleDeclaration.
    
    This change also removes EAlignItems as it is now unused.
    
    Tests: css3/parse-align-items.html
           css3/parse-align-self.html
    
    * css/CSSComputedStyleDeclaration.cpp:
    (WebCore::resolveAlignmentAuto): Added. Resolves the "auto" value for the alignment properties.
    (WebCore::valueForItemPositionWithOverflowAlignment): Added. Builds the CSSValue for the for the alignment properties.
    (WebCore::ComputedStyleExtractor::propertyValue):
    * css/CSSParser.cpp:
     (WebCore::isValidKeywordPropertyAndValue): Removed align-self, align-items and justify-items.
    (WebCore::isKeywordPropertyID): Removed align-self, align-items and justify-items.
    (WebCore::isBaselinePositionKeyword): Added. Set of keywords related to baseline value.
    (WebCore::CSSParser::parseItemPositionOverflowPosition): Generic parsing fuction for the alignment properties.
    (WebCore::CSSParser::parseJustifySelf): Deleted.
    (WebCore::CSSParser::parseValue): Added align-items and align-self to the list and call to the generic parsing fuction for the alignment properties.
    * css/CSSParser.h:
    * css/CSSPrimitiveValueMappings.h:
    (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added.
    (WebCore::CSSPrimitiveValue::operator ItemPosition): Added. Replace the old EAlignItems enumeration.
    (WebCore::CSSPrimitiveValue::operator OverflowAlignment): Added.
    (WebCore::CSSPrimitiveValue::operator EAlignItems): Deleted.
    (WebCore::CSSPrimitiveValue::operator EJustifySelf): Deleted.
    (WebCore::CSSPrimitiveValue::operator EJustifySelfOverflowAlignment): Deleted.
    * css/CSSPropertyNames.in:
    * css/CSSValueKeywords.in:
    * css/StyleBuilderCustom.h:
    (WebCore::StyleBuilderCustom::applyInheritAlignSelf): Added.
    (WebCore::StyleBuilderCustom::applyInitialAlignSelf): Added.
    (WebCore::StyleBuilderCustom::applyValueAlignSelf): Added.
    (WebCore::StyleBuilderCustom::applyInheritAlignItems): Added.
    (WebCore::StyleBuilderCustom::applyInitialAlignItems): Added.
    (WebCore::StyleBuilderCustom::applyValueAlignItems): Added.
    (WebCore::StyleBuilderCustom::applyInheritJustifySelf): Added.
    (WebCore::StyleBuilderCustom::applyInitialJustifySelf): Added.
    (WebCore::StyleBuilderCustom::applyValueJustifySelf): Added.
    (WebCore::StyleBuilderCustom::applyValueWebkitJustifySelf): Deleted.
    * css/StyleResolver.cpp:
    (WebCore::StyleResolver::adjustRenderStyle): isDisplayFlexibleOrGridBox now a RenderStyle function.
    (WebCore::isDisplayFlexibleBox): Deleted. Moved to RenderStyle.
    (WebCore::isDisplayGridBox): Deleted. Moved to RenderStyle.
    (WebCore::isDisplayFlexibleOrGridBox): Deleted. Moved to RenderStyle.
    * rendering/RenderBox.cpp:
    (WebCore::flexItemHasStretchAlignment): Adapted to the new ItemPostition enum.
    * rendering/RenderFlexibleBox.cpp:
    (WebCore::RenderFlexibleBox::firstLineBaseline): Adapted to the new ItemPostition enum.
    (WebCore::RenderFlexibleBox::styleDidChange): Adapted to the new ItemPostition enum.
    (WebCore::RenderFlexibleBox::alignmentForChild): Adapted to the new ItemPostition enum.
    (WebCore::RenderFlexibleBox::needToStretchChild): Adapted to the new ItemPostition enum.
    (WebCore::RenderFlexibleBox::layoutAndPlaceChildren): Adapted to the new ItemPostition enum.
    (WebCore::RenderFlexibleBox::alignChildren): Adapted to the new ItemPostition enum.
    (WebCore::resolveAlignment): Deleted. Moved to RenderStyle.
    * rendering/RenderFlexibleBox.h:
    * rendering/RenderFullScreen.cpp:
    (WebCore::createFullScreenStyle): Adapted to the new ItemPostition enum.
    * rendering/RenderMenuList.cpp:
    (WebCore::RenderMenuList::adjustInnerStyle): Adapted to the new ItemPostition enum.
    * rendering/mathml/RenderMathMLRoot.cpp:
    (WebCore::RenderMathMLRoot::updateStyle): Adapted to the new ItemPostition enum.
    * rendering/mathml/RenderMathMLScripts.cpp:
    (WebCore::RenderMathMLScripts::fixAnonymousStyleForSubSupPair): Adapted to the new ItemPostition enum.
    (WebCore::RenderMathMLScripts::fixAnonymousStyles): Adapted to the new ItemPostition enum.
    * rendering/style/ContentData.h:
    * rendering/style/RenderStyle.cpp:
    (WebCore::RenderStyle::resolveAlignment): Added.
    * rendering/style/RenderStyle.h: Adapted to the new ItemPostition enum.
    * rendering/style/RenderStyleConstants.h: Adapted to the new ItemPostition enum.
    * rendering/style/StyleRareNonInheritedData.cpp: Adapted to the new ItemPostition enum.
    (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): Adapted to the new ItemPostition enum.
    (WebCore::StyleRareNonInheritedData::operator==): Adapted to the new ItemPostition enum.
    * rendering/style/StyleRareNonInheritedData.h: Adapted to the new ItemPostition enum.
    * style/StyleResolveTree.cpp:
    (WebCore::Style::determineChange): Changes in the alignItems property cause a Detach.
    
    LayoutTests:
    
    Broaden justify-self's parsing name and upgrade align-self and
    align-items parsing to CSS 3.
    
    * TestExpectations:
    * css3/flexbox/css-properties-expected.txt:
    * css3/flexbox/css-properties.html:
    * css3/parse-align-items-expected.txt: Added.
    * css3/parse-align-items.html: Added.
    * css3/parse-align-self-expected.txt: Added.
    * css3/parse-align-self.html: Added.
    * css3/resources/alignment-parsing-utils.js: Added.
    (checkValues):
    (checkBadValues):
    (checkInitialValues):
    (checkInheritValues):
    (checkLegacyValues):
    * fast/css/getComputedStyle/computed-style-expected.txt:
    * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
    * fast/css/getComputedStyle/resources/property-names.js:
    * fast/css/parse-justify-self-expected.txt:
    * fast/css/parse-justify-self.html:
    * svg/css/getComputedStyle-basic-expected.txt:
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182147 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  6. [New Block-Inside-Inline Model] Create anonymous inline blocks to hol…

    hyatt@apple.com authored
    …d blocks-inside-inlines.
    
    
    https://bugs.webkit.org/show_bug.cgi?id=143145
    
    Reviewed by Dean Jackson.
    
    Source/WebCore:
    
    Added fast/block/inside-inlines/ tests.
    
    * rendering/RenderBlock.cpp:
    (WebCore::RenderBlock::renderName):
    Add support for labeling anonymous inline-blocks when dumped by the render tree.
    
    * rendering/RenderInline.cpp:
    (WebCore::RenderInline::addChildIgnoringContinuation):
    When the pref is set to use the new block-inside-inline model, create an anonymous inline block to
    hold block children of RenderInlines instead of splitting flows or creating continuations.
    
    * rendering/RenderObject.h:
    (WebCore::RenderObject::isAnonymousInlineBlock):
    Add the definition of isAnonymousInlineBlock (note the exclusion of Ruby, since Ruby creates anonymous
    inline-blocks also).
    
    LayoutTests:
    
    * fast/block/inside-inlines: Added.
    * fast/block/inside-inlines/empty-block-expected.html: Added.
    * fast/block/inside-inlines/empty-block.html: Added.
    * fast/block/inside-inlines/new-model: Added.
    * fast/block/inside-inlines/new-model/empty-block-expected.html: Added.
    * fast/block/inside-inlines/new-model/empty-block.html: Added.
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182146 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  7. [WK2][NetworkCache] Add support for "Cache-Control: max-stale" reques…

    cdumez@apple.com authored
    …t header
    
    
    https://bugs.webkit.org/show_bug.cgi?id=143159
    <rdar://problem/20333296>
    
    Reviewed by Antti Koivisto.
    
    Source/WebCore:
    
    Add support for "Cache-Control: max-stale" request header:
    https://tools.ietf.org/html/rfc7234#section-5.2.1.2
    
    Test: http/tests/cache/disk-cache/disk-cache-request-max-stale.html
    
    * platform/network/CacheValidation.cpp:
    (WebCore::parseCacheControlDirectives):
    * platform/network/CacheValidation.h:
    
    Source/WebKit2:
    
    Add support for "Cache-Control: max-stale" request header:
    https://tools.ietf.org/html/rfc7234#section-5.2.1.2
    
    * NetworkProcess/cache/NetworkCache.cpp:
    (WebKit::NetworkCache::responseHasExpired):
    (WebKit::NetworkCache::requestRequiresRevalidation):
    (WebKit::NetworkCache::canUse):
    
    LayoutTests:
    
    Add layout test to cover support for "Cache-Control: max-stale" request
    header.
    
    * http/tests/cache/disk-cache/disk-cache-request-max-stale-expected.txt: Added.
    * http/tests/cache/disk-cache/disk-cache-request-max-stale.html: Added.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182145 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  8. Update install-dependencies Fedora packages after r181624

    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=143215
    
    Add json-glib, libv4l, openssl and pulseaudio development packages to
    the Fedora list providing we need them to build WebKit dependencies
    for this distribution.
    
    Patch by Marcos Chavarría Teijeiro <chavarria1991@gmail.com> on 2015-03-30
    Reviewed by Philippe Normand.
    
    * gtk/install-dependencies:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182144 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  9. Fix iOS internal build after r182132.

    simon.fraser@apple.com authored
    * page/scrolling/ScrollingCoordinator.cpp:
    (WebCore::ScrollingCoordinator::computeNonFastScrollableRegion):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182143 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  10. Web Inspector: Add more ESLint rules that reflect the current state o…

    commit-queue@webkit.org authored
    …f the code base
    
    
    https://bugs.webkit.org/show_bug.cgi?id=143212
    
    Patch by Tobias Reiss <tobi+webkit@basecode.de> on 2015-03-30
    Reviewed by Timothy Hatcher.
    
    * .eslintrc:
    Define some utilities as globals.
    Replace "no-comma-dangle" with "comma-dangle". "no-comma-dangle" is deprecated and does not trigger in ESLint v.0.17.1
    Set "new-cap" to 0 due to the usage of "WebInspector.UIString".
    Disable "no-redeclare" for now and enable it back as soon as block scoped `let` is used.
    Disable "dot-notation", "no-shadow" and "no-use-before-define" due to a lot of hits.
    Disable "no-inner-declarations" as this is a common pattern to save memory.
    * UserInterface/Views/ObjectTreePropertyTreeElement.js:
    * UserInterface/Models/SourceCodeLocation.js:
    It's not necessary to initialize x to undefined.
    * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
    * UserInterface/Views/LayerTreeDetailsSidebarPanel.js:
    * UserInterface/Views/TextEditor.js:
    * UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
    Remove unused variable x.
    * UserInterface/Views/ObjectTreeMapEntryTreeElement.js:
    * UserInterface/Models/PropertyPath.js:
    * UserInterface/Views/RadioButtonNavigationItem.js:
    * UserInterface/Views/ReplayDashboardView.js:
    * UserInterface/Models/ScriptSyntaxTree.js:
    * UserInterface/Views/SourceCodeTextEditor.js:
    * UserInterface/Views/SourceCodeTreeElement.js:
    Remove trailing and unexpected whitespace.
    * UserInterface/Views/ProbeSetDataGrid.js:
    * UserInterface/Views/TimelineRuler.js:
    Add missing semicolon.
    * UserInterface/Views/TimelineDataGrid.js:
    * UserInterface/Views/TimelineRecordFrame.js:
    Add missing var statement.
    * UserInterface/Views/TypeTokenView.js:
    Remove unnecessary `bind`.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182142 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  11. [iOS] When Web Audio is interrupted by a phone call, it cannot be res…

    jer.noble@apple.com authored
    …tarted.
    
    
    https://bugs.webkit.org/show_bug.cgi?id=143190
    
    Reviewed by Darin Adler.
    
    Source/WebCore:
    
    Tests: webaudio/audiocontext-state-interrupted.html
           webaudio/audiocontext-state.html
    
    Implement the following methods and properties from the Web Audio spec:
    close(), suspend(), resume(), onstatechange.
    
    AudioContext will take more responsibility for tracking state and interruptions (and
    AudioDestination will give up that responsibility). This means AudioContext must be a
    MediaSessionClient, and own its own MediaSession. In return, AudioDestinationIOS and
    AudioDestinationMac relinquish both.
    
    * Modules/webaudio/AudioContext.cpp:
    (WebCore::AudioContext::AudioContext): Set default values in header.
    (WebCore::AudioContext::uninitialize): Call setState() instead of setting m_state.
    (WebCore::AudioContext::addReaction): Added. Append the callback to the appropriate vector for the state.
    (WebCore::AudioContext::setState): Added. Fire events and resolve the appropriate reaction callbacks for the new state.
    (WebCore::AudioContext::state): Return a string representing the context's state.
    (WebCore::AudioContext::stop): Close the event queue.
    (WebCore::AudioContext::startRendering): Call setState().
    (WebCore::AudioContext::fireCompletionEvent): Call setState().
    (WebCore::AudioContext::suspendContext): Added. Add reaction callback and call suspend() on the destination node.
    (WebCore::AudioContext::resumeContext): Added. Add reaction callback and call resume() on the destination node.
    (WebCore::AudioContext::closeContext): Added. Add reaction callback and call close() on the destination node.
    (WebCore::AudioContext::suspendPlayback): Added. Suspend playback and set state to interrupted.
    (WebCore::AudioContext::mayResumePlayback): Added. Conditionally resume playback.
    * bindings/js/JSAudioContextCustom.cpp:
    (WebCore::JSAudioContext::suspend): Added. Create and return a new Promise object.
    (WebCore::JSAudioContext::resume): Ditto.
    (WebCore::JSAudioContext::close): Ditto.
    * Modules/webaudio/AudioContext.idl: Add new methods and properties.
    
    Extensive organizational changes were made to AudioContext.h to group instance
    variables together and add C++11 initializers in their declarations:
    
    * Modules/webaudio/AudioContext.h:
    (WebCore::AudioContext::mediaType): Moved from AudioDestinationNode.
    (WebCore::AudioContext::presentationType): Ditto.
    (WebCore::AudioContext::canReceiveRemoteControlCommands): Ditto.
    (WebCore::AudioContext::didReceiveRemoteControlCommand): Ditto.
    (WebCore::AudioContext::overrideBackgroundPlaybackRestriction): Ditto.
    
    Other changes to support the new AudioContext methods:
    
    * Modules/webaudio/AudioDestinationNode.h:
    (WebCore::AudioDestinationNode::resume): Add empty default virtual method.
    (WebCore::AudioDestinationNode::suspend): Ditto.
    (WebCore::AudioDestinationNode::close): Ditto.
    * Modules/webaudio/DefaultAudioDestinationNode.cpp:
    (WebCore::DefaultAudioDestinationNode::resume): Added. Pass to AudioDestination.
    (WebCore::DefaultAudioDestinationNode::suspend): Ditto.
    (WebCore::DefaultAudioDestinationNode::close): Ditto.
    * Modules/webaudio/DefaultAudioDestinationNode.h:
    * bindings/js/JSDOMPromise.h:
    (WebCore::DeferredWrapper::resolve): Add an overload for a nullptr resolve value.
    * dom/EventNames.h: Added 'statechange'.
    * dom/ScriptExecutionContext.h:
    (WebCore::ScriptExecutionContext::Task::Task): Add a constructor which takes a void() callback.
    
    Modify MediaSession, AudioSession, and MediaSessionManager to support the new
    interruption behavior.
    
    * html/HTMLMediaElement.cpp:
    (WebCore::HTMLMediaElement::suspendPlayback): Renamed from pausePlayback().
    (WebCore::HTMLMediaElement::mayResumePlayback): Renamed from resumePlayback().
    * html/HTMLMediaElement.h:
    * platform/audio/AudioSession.cpp:
    (WebCore::AudioSession::tryToSetActive): Renamed from setActive. Return true by default.
    (WebCore::AudioSession::setActive): Deleted.
    * platform/audio/AudioSession.h:
    * platform/audio/MediaSession.cpp:
    (WebCore::MediaSession::beginInterruption): pausePlayback() was renamed to suspendPlayback().
    (WebCore::MediaSession::endInterruption): Always notify the client, telling it whether to resume.
    (WebCore::MediaSession::clientWillBeginPlayback): Bail early if reentrant.  Check the (new)
        return value of sessionWillBeginPlayback() and remember to resume once the interruption ends.
    (WebCore::MediaSession::clientWillPausePlayback): Bail early if reentrant.
    (WebCore::MediaSession::pauseSession): pausePlayback() was renamed to suspendPlayback().
    * platform/audio/MediaSession.h:
    * platform/audio/MediaSessionManager.cpp:
    (WebCore::MediaSessionManager::sessionWillBeginPlayback): Return false if not allowed to break interruption or
        if activating the audio session failed. Otherwise, end the interruption.
    * platform/audio/MediaSessionManager.h:
    * platform/audio/ios/AudioDestinationIOS.cpp:
    (WebCore::AudioDestinationIOS::AudioDestinationIOS): m_mediaSession was removed.
    (WebCore::AudioDestinationIOS::start): Ditto.
    * platform/audio/ios/AudioDestinationIOS.h:
    * platform/audio/ios/AudioSessionIOS.mm:
    (WebCore::AudioSession::tryToSetActive): Renamed from setActive. Return false if the AVAudioSession could not be activated.
    (WebCore::AudioSession::setActive): Deleted.
    * platform/audio/ios/MediaSessionManagerIOS.h:
    * platform/audio/ios/MediaSessionManagerIOS.mm:
    (WebCore::MediaSessionManageriOS::sessionWillBeginPlayback): Do not update the now playing info if session playback was blocked.
    * platform/audio/mac/AudioDestinationMac.cpp:
    (WebCore::AudioDestinationMac::AudioDestinationMac): m_mediaSession was removed.
    * platform/audio/mac/AudioDestinationMac.h:
    * platform/audio/mac/AudioSessionMac.cpp:
    (WebCore::AudioSession::tryToSetActive): Renamed from setActive(). Return true by default.
    (WebCore::AudioSession::setActive): Deleted.
    * platform/audio/mac/MediaSessionManagerMac.cpp:
    (MediaSessionManager::updateSessionState): No longer attempt to activate the session, as this is done
        MediaSessionManager::sessionWillBeginPlayback().
    * testing/Internals.cpp:
    (WebCore::Internals::setMediaSessionRestrictions): Add "InterruptedPlaybackNotPermitted".
    
    LayoutTests:
    
    * webaudio/audiocontext-state-expected.txt: Added.
    * webaudio/audiocontext-state-interrupted-expected.txt: Added.
    * webaudio/audiocontext-state-interrupted.html: Added.
    * webaudio/audiocontext-state.html: Added.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182141 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  12. [Streams API] Error storage should be moved from source to stream/reader

    youenn.fablet@crf.canon.fr authored
    https://bugs.webkit.org/show_bug.cgi?id=143048
    
    Reviewed by Benjamin Poulain.
    
    This patch removes error storage from the source as it should be stored at the stream level as error access goes through the reader.
    It removes abstract ReadableStreamSource::isErrored and the storage of JavaScript errors from ReadableStreamJSSource.
    
    Existing tests cover most of the changes.
    Added test case for creating readable stream from empty JS object.
    
    * Modules/streams/ReadableStreamSource.h: Removing isErrored().
    * bindings/js/JSReadableStreamCustom.cpp:
    (WebCore::constructJSReadableStream): Added JS stream constructor parameters checking.
    * bindings/js/ReadableStreamJSSource.cpp:
    (WebCore::ReadableStreamJSSource::ReadableStreamJSSource): Removed JS stream constructor parameters checking.
    (WebCore::ReadableStreamJSSource::start): Changed prototype of start so that start can throw errors directly.
    (WebCore::ReadableStreamJSSource::setInternalError): Deleted.
    * bindings/js/ReadableStreamJSSource.h: Removed m_error, setInternalError and updated start declaration.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182140 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  13. [GStreamer] More GL shared context fixes

    philn@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=143216
    
    Reviewed by Carlos Garcia Campos.
    
    Moved the GLX/EGL context tests to be done at runtime rather than
    using build-time macros because in the GTK port at least, both EGL
    and GLX support are mutually exclusive. Also fixed a couple wrong
    defines (USE(GLES2) doesn't exist).
    
    * platform/graphics/GLContext.h: Simple utility method to check if
    the platform context is compatible with EGL APIs or not.
    * platform/graphics/egl/GLContextEGL.h:
    (WebCore::GLContextEGL::isEGLContext):
    * platform/graphics/glx/GLContextGLX.h:
    (WebCore::GLContextGLX::isEGLContext):
    * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
    (WebCore::MediaPlayerPrivateGStreamer::ensureGstGLContext): Do
    runtime checks and properly ensure GLES2/GL API usage.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182139 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  14. [EFL][GTK] WebKit2's generate-forwarding-headers.pl should fail if cl…

    ossy@webkit.org authored
    …ashing headers found
    
    
    https://bugs.webkit.org/show_bug.cgi?id=142909
    
    Reviewed by Philippe Normand.
    
    * Scripts/generate-forwarding-headers.pl:
    (createForwardingHeadersForFramework):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182138 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  15. Source/WebCore:

    commit-queue@webkit.org authored
    Add support for deleting emoji on GTK
    https://bugs.webkit.org/show_bug.cgi?id=141419
    
    Patch by Marcos Chavarría Teijeiro <chavarria1991@gmail.com> on 2015-03-30
    Reviewed by Gustavo Noronha Silva.
    
    The code for deleting special group of characters was specific for
    COCOA and EFL platforms. The fix consists on add GTK to the #if
    preprocessor directive.
    
    * rendering/RenderText.cpp:
    (WebCore::RenderText::previousOffsetForBackwardDeletion):
    
    LayoutTests:
    Update expectations for delete-emoji test since the bug is fixed now.
    https://bugs.webkit.org/show_bug.cgi?id=141419
    
    Patch by Marcos Chavarría Teijeiro <chavarria1991@gmail.com> on 2015-03-30
    Reviewed by Gustavo Noronha Silva.
    
    * platform/gtk/TestExpectations:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182137 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  16. Include cache entry worth to json dump

    antti@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=143202
    
    Reviewed by Darin Adler.
    
    This is useful for analyzing cache performance.
    Also include the body size, total item count and average worth.
    
    * NetworkProcess/cache/NetworkCache.cpp:
    (WebKit::NetworkCache::Cache::traverse):
    (WebKit::NetworkCache::Cache::dumpContentsToFile):
    * NetworkProcess/cache/NetworkCacheEntry.cpp:
    (WebKit::NetworkCache::Entry::asJSON):
    * NetworkProcess/cache/NetworkCacheEntry.h:
    * NetworkProcess/cache/NetworkCacheStorage.cpp:
    (WebKit::NetworkCache::Storage::traverse):
    
        Add flags for specificying what sort of information is needed.
    
    (WebKit::NetworkCache::computeRecordWorth):
    
        Factor to a function.
    
    (WebKit::NetworkCache::deletionProbability):
    * NetworkProcess/cache/NetworkCacheStorage.h:
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182136 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  17. Unreviewed, rolling out r182119.

    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=143196
    
    problem with syntax (Requested by youenn on #webkit).
    
    Reverted changeset:
    
    "[buildbot] clean-build script should remove untracked files
    and revert local changes too"
    https://bugs.webkit.org/show_bug.cgi?id=142400
    http://trac.webkit.org/changeset/182119
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182135 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  18. Start the features.json files

    benjamin@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=143207
    
    Reviewed by Darin Adler.
    
    Source/JavaScriptCore:
    
    Start the features.json files to have something to experiment
    with for the UI.
    
    * features.json: Added.
    
    Source/WebCore:
    
    * features.json: Added.
    
    Tools:
    
    I kept the style checking light. We'll have to figure
    what is the best format for each field.
    
    * Scripts/webkitpy/style/checker.py:
    (CheckerDispatcher._create_checker):
    * Scripts/webkitpy/style/checkers/jsonchecker.py:
    (JSONContributorsChecker.check):
    (JSONFeaturesChecker):
    (JSONFeaturesChecker.check):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182134 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  19. Fix iOS scrollperf crash after a web process crash

    simon.fraser@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=143110
    
    Reviewed by Dean Jackson.
    
    When we destroy the drawing area after a web process crash, we also need to destroy
    the scrollingPerformanceData which has a reference to the drawing area.
    
    * UIProcess/WebPageProxy.cpp:
    (WebKit::WebPageProxy::resetState):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182133 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  20. Convert arguments to ScrollingCoordinator functions to references

    simon.fraser@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=143198
    
    Reviewed by Darin Adler.
    
    Convert all the FrameView* and ScrollableArea* arguments to ScrollingCoordinator functions to
    references, and use references in a few other places.
    
    Source/WebCore:
    
    * dom/Document.cpp:
    (WebCore::wheelEventHandlerCountChanged):
    * loader/HistoryController.cpp:
    (WebCore::HistoryController::restoreScrollPositionAndViewState):
    * page/DebugPageOverlays.cpp:
    (WebCore::NonFastScrollableRegionOverlay::updateRegion):
    * page/Frame.cpp:
    (WebCore::Frame::willDetachPage):
    * page/FrameView.cpp:
    (WebCore::FrameView::prepareForDetach):
    (WebCore::FrameView::addSlowRepaintObject):
    (WebCore::FrameView::removeSlowRepaintObject):
    (WebCore::FrameView::addViewportConstrainedObject):
    (WebCore::FrameView::removeViewportConstrainedObject):
    (WebCore::FrameView::requestScrollPositionUpdate):
    (WebCore::FrameView::performPostLayoutTasks):
    (WebCore::FrameView::scrollableAreaSetChanged):
    (WebCore::FrameView::wheelEvent):
    * page/Page.cpp:
    (WebCore::Page::nonFastScrollableRects):
    * page/Page.h:
    * page/scrolling/AsyncScrollingCoordinator.cpp:
    (WebCore::AsyncScrollingCoordinator::frameViewLayoutUpdated):
    (WebCore::AsyncScrollingCoordinator::frameViewNonFastScrollableRegionChanged):
    (WebCore::AsyncScrollingCoordinator::frameViewRootLayerDidChange):
    (WebCore::AsyncScrollingCoordinator::requestScrollPositionUpdate):
    (WebCore::AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScroll):
    (WebCore::AsyncScrollingCoordinator::scrollableAreaScrollbarLayerDidChange):
    (WebCore::AsyncScrollingCoordinator::ensureRootStateNodeForFrameView):
    (WebCore::AsyncScrollingCoordinator::updateMainFrameScrollLayerPosition):
    (WebCore::AsyncScrollingCoordinator::recomputeWheelEventHandlerCountForFrameView):
    * page/scrolling/AsyncScrollingCoordinator.h:
    * page/scrolling/ScrollingCoordinator.cpp:
    (WebCore::ScrollingCoordinator::pageDestroyed):
    (WebCore::ScrollingCoordinator::coordinatesScrollingForFrameView):
    (WebCore::ScrollingCoordinator::computeNonFastScrollableRegion):
    (WebCore::ScrollingCoordinator::frameViewWheelEventHandlerCountChanged):
    (WebCore::ScrollingCoordinator::frameViewHasSlowRepaintObjectsDidChange):
    (WebCore::ScrollingCoordinator::frameViewFixedObjectsDidChange):
    (WebCore::ScrollingCoordinator::scrollLayerForScrollableArea):
    (WebCore::ScrollingCoordinator::scrollLayerForFrameView):
    (WebCore::ScrollingCoordinator::headerLayerForFrameView):
    (WebCore::ScrollingCoordinator::footerLayerForFrameView):
    (WebCore::ScrollingCoordinator::counterScrollingLayerForFrameView):
    (WebCore::ScrollingCoordinator::insetClipLayerForFrameView):
    (WebCore::ScrollingCoordinator::contentShadowLayerForFrameView):
    (WebCore::ScrollingCoordinator::rootContentLayerForFrameView):
    (WebCore::ScrollingCoordinator::frameViewRootLayerDidChange):
    (WebCore::ScrollingCoordinator::hasVisibleSlowRepaintViewportConstrainedObjects):
    (WebCore::ScrollingCoordinator::synchronousScrollingReasons):
    (WebCore::ScrollingCoordinator::updateSynchronousScrollingReasons):
    (WebCore::ScrollingCoordinator::setForceSynchronousScrollLayerPositionUpdates):
    (WebCore::ScrollingCoordinator::shouldUpdateScrollLayerPositionSynchronously):
    (WebCore::ScrollingCoordinator::replaySessionStateDidChange):
    (WebCore::ScrollingCoordinator::synchronousScrollingReasonsAsText):
    * page/scrolling/ScrollingCoordinator.h: Align the bitmask enums to make mistakes easier to spot.
    (WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
    (WebCore::ScrollingCoordinator::frameViewNonFastScrollableRegionChanged):
    (WebCore::ScrollingCoordinator::requestScrollPositionUpdate):
    (WebCore::ScrollingCoordinator::handleWheelEvent):
    (WebCore::ScrollingCoordinator::willDestroyScrollableArea):
    (WebCore::ScrollingCoordinator::scrollableAreaScrollLayerDidChange):
    (WebCore::ScrollingCoordinator::scrollableAreaScrollbarLayerDidChange):
    (WebCore::ScrollingCoordinator::recomputeWheelEventHandlerCountForFrameView):
    * page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp:
    (WebCore::ScrollingCoordinatorCoordinatedGraphics::scrollableAreaScrollLayerDidChange):
    (WebCore::ScrollingCoordinatorCoordinatedGraphics::willDestroyScrollableArea):
    (WebCore::ScrollingCoordinatorCoordinatedGraphics::requestScrollPositionUpdate):
    * page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.h:
    * page/scrolling/ios/ScrollingCoordinatorIOS.h:
    * page/scrolling/mac/ScrollingCoordinatorMac.h:
    * page/scrolling/mac/ScrollingCoordinatorMac.mm:
    (WebCore::ScrollingCoordinatorMac::handleWheelEvent):
    * rendering/RenderLayer.cpp:
    (WebCore::RenderLayer::~RenderLayer):
    * rendering/RenderLayerBacking.cpp:
    (WebCore::RenderLayerBacking::updateOverflowControlsLayers):
    * rendering/RenderLayerCompositor.cpp:
    (WebCore::RenderLayerCompositor::updateBacking):
    (WebCore::RenderLayerCompositor::hasCoordinatedScrolling):
    (WebCore::RenderLayerCompositor::scrollingLayerDidChange):
    (WebCore::RenderLayerCompositor::updateLayerForHeader):
    (WebCore::RenderLayerCompositor::updateLayerForFooter):
    (WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
    (WebCore::RenderLayerCompositor::destroyRootLayer):
    (WebCore::RenderLayerCompositor::updateScrollCoordinationForThisFrame):
    (WebCore::RenderLayerCompositor::updateScrollCoordinatedLayer):
    (WebCore::RenderLayerCompositor::willRemoveScrollingLayerWithBacking):
    (WebCore::RenderLayerCompositor::didAddScrollingLayer):
    * testing/Internals.cpp:
    (WebCore::Internals::nonFastScrollableRects):
    
    Source/WebKit2:
    
    * WebProcess/Scrolling/RemoteScrollingCoordinator.h:
    * WebProcess/Scrolling/RemoteScrollingCoordinator.mm:
    (WebKit::RemoteScrollingCoordinator::coordinatesScrollingForFrameView):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182132 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  21. Use :matches() instead of :-webkit-any() for the sections and heading…

    benjamin@webkit.org authored
    …s default style
    
    
    https://bugs.webkit.org/show_bug.cgi?id=143197
    
    Reviewed by Darin Adler.
    
    We no longer need to use the :-webkit-any() hack in the default stylesheet.
    
    The pseudo class :matches() also support correct specificity. This is not observable
    since those selector do not conflict with any other rule in the default stylesheet.
    
    * css/CSSSelector.h:
    * css/SelectorChecker.cpp:
    (WebCore::SelectorChecker::determineLinkMatchType):
    * css/html.css:
    (:matches(article, aside, nav, section) h1):
    (:matches(article, aside, nav, section) :matches(article, aside, nav, section) h1):
    (:matches(article, aside, nav, section) :matches(article, aside, nav, section) :matches(article, aside, nav, section) h1):
    (:matches(article, aside, nav, section) :matches(article, aside, nav, section) :matches(article, aside, nav, section) :matches(article, aside, nav, section) h1):
    (:matches(article, aside, nav, section) :matches(article, aside, nav, section) :matches(article, aside, nav, section) :matches(article, aside, nav, section) :matches(article, aside, nav, section) h1):
    (:-webkit-any(article,aside,nav,section) h1): Deleted.
    (:-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) h1): Deleted.
    (:-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) h1): Deleted.
    (:-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) h1): Deleted.
    (:-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) h1): Deleted.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182131 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  22. `currentColor` computes to the same colour on all elements, even if '…

    benjamin@webkit.org authored
    …color' is inherited differently
    
    
    https://bugs.webkit.org/show_bug.cgi?id=133420
    
    Reviewed by Darin Adler.
    
    Source/WebCore:
    
    When resolving a style with the help of the property cache, we were
    completely ignoring currentColor.
    
    Since you can set currentColor on properties that are not inherited,
    those properties would just be copied from the cached style, which
    may have a completely different inherited color.
    
    This pacth fixes the issue by preventing any MatchResult from hitting
    the cache if it contains any non-inherited property that would require
    resolution by the cache:
    -Using the inherit value.
    -Using the currentColor value.
    
    Tests: fast/css/currentColor-on-before-after-pseudo-elements.html
           fast/css/currentColor-style-update-reftest.html
           fast/css/currentColor-value-style-update.html
    
    * css/ElementRuleCollector.cpp:
    (WebCore::ElementRuleCollector::addElementStyleProperties):
    (WebCore::ElementRuleCollector::matchAuthorRules):
    (WebCore::ElementRuleCollector::matchUserRules):
    (WebCore::ElementRuleCollector::matchUARules):
    * css/StyleResolver.cpp:
    (WebCore::StyleResolver::MatchResult::addMatchedProperties):
    (WebCore::StyleResolver::styleForKeyframe):
    (WebCore::StyleResolver::pseudoStyleForElement):
    (WebCore::StyleResolver::styleForPage):
    (WebCore::StyleResolver::findFromMatchedPropertiesCache):
    (WebCore::StyleResolver::addToMatchedPropertiesCache):
    (WebCore::extractDirectionAndWritingMode):
    (WebCore::StyleResolver::applyMatchedProperties):
    (WebCore::StyleResolver::CascadedProperties::addStyleProperties):
    (WebCore::StyleResolver::CascadedProperties::addMatches):
    * css/StyleResolver.h:
    (WebCore::StyleResolver::MatchResult::matchedProperties):
    
    LayoutTests:
    
    * fast/css/currentColor-on-before-after-pseudo-elements-expected.html: Added.
    * fast/css/currentColor-on-before-after-pseudo-elements.html: Added.
    * fast/css/currentColor-style-update-reftest-expected.html: Added.
    * fast/css/currentColor-style-update-reftest.html: Added.
    * fast/css/currentColor-value-style-update-expected.txt: Added.
    * fast/css/currentColor-value-style-update.html: Added.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182130 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  23. Enable :any-link by default

    benjamin@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=143201
    
    Reviewed by Sam Weinig.
    
    The pseudo class :any-link has been stable for a while. This patch enables
    it by default and remove the -webkit- prefix on the default style.
    
    * css/CSSDefaultStyleSheets.cpp:
    * css/CSSSelector.cpp:
    (WebCore::CSSSelector::selectorText):
    * css/CSSSelector.h:
    * css/RuleSet.cpp:
    (WebCore::RuleSet::addRule):
    * css/SelectorChecker.cpp:
    (WebCore::SelectorChecker::checkOne):
    * css/SelectorChecker.h:
    (WebCore::SelectorChecker::isCommonPseudoClassSelector):
    * css/SelectorPseudoClassAndCompatibilityElementMap.in:
    * css/html.css:
    (a:any-link):
    (a:any-link:active):
    (:any-link img):
    (a:-webkit-any-link): Deleted.
    (a:-webkit-any-link:active): Deleted.
    (:-webkit-any-link img): Deleted.
    * cssjit/SelectorCompiler.cpp:
    (WebCore::SelectorCompiler::addPseudoClassType):
    (WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementLinkMatching):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182129 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  24. [CMake] Update old CMakeList.txt in gtest

    gyuyoung.kim@samsung.com authored
    https://bugs.webkit.org/show_bug.cgi?id=143192
    
    Reviewed by Darin Adler.
    
    CMake ports have used cmake/gtest/CMakeLists.txt instead of ThirdParty/test/CMakeLists.txt
    in order to build gtest. However it looks ThirdParty/test/CMakeLists.txt won't be used anymore.
    So this patch moves cmake/gtest/CMakeLists.txt to ThirdPart/test/CMakeLists.txt, and use it.
    
    .:
    
    * Source/CMakeLists.txt:
    * Source/cmake/gtest/CMakeLists.txt: Removed.
    
    Source/ThirdParty:
    
    * gtest/CMakeLists.txt:
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182128 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  25. nullptr cleanup in RenderFooBox classes

    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=143182
    
    Patch by Joonghun Park <jh718.park@samsung.com> on 2015-03-29
    Reviewed by Ryosuke Niwa.
    
    No new tests, no behavior changes
    
    Replace 0 with nullptr in RenderFooBox classes.
    
    * rendering/RenderBox.cpp:
    (WebCore::RenderBox::RenderBox):
    (WebCore::RenderBox::paintFillLayer):
    (WebCore::RenderBox::shrinkLogicalWidthToAvoidFloats):
    (WebCore::RenderBox::containingBlockAvailableLineWidthInRegion):
    (WebCore::RenderBox::renderBoxRegionInfo):
    (WebCore::RenderBox::computePositionedLogicalWidthUsing):
    (WebCore::RenderBox::computePositionedLogicalHeightUsing):
    (WebCore::RenderBox::computePositionedLogicalWidthReplaced):
    (WebCore::RenderBox::positionForPoint):
    (WebCore::RenderBox::layoutOverflowRectForPropagation):
    * rendering/RenderBox.h:
    (WebCore::RenderBox::setMarginBefore):
    (WebCore::RenderBox::setMarginAfter):
    (WebCore::RenderBox::setMarginStart):
    (WebCore::RenderBox::setMarginEnd):
    (WebCore::RenderBox::createAnonymousBoxWithSameTypeAs):
    (WebCore::RenderBox::setInlineBoxWrapper):
    * rendering/RenderBoxModelObject.cpp:
    (WebCore::RenderBoxModelObject::willBeDestroyed):
    (WebCore::RenderBoxModelObject::paintMaskForTextFillBox):
    (WebCore::RenderBoxModelObject::paintBorderSides):
    (WebCore::RenderBoxModelObject::firstLetterRemainingText):
    * rendering/RenderBoxModelObject.h:
    (WebCore::RenderBoxModelObject::moveChildTo):
    (WebCore::RenderBoxModelObject::moveAllChildrenTo):
    (WebCore::RenderBoxModelObject::moveChildrenTo):
    * rendering/RenderDeprecatedFlexibleBox.cpp:
    (WebCore::FlexBoxIterator::reset):
    (WebCore::FlexBoxIterator::next):
    * rendering/RenderDeprecatedFlexibleBox.h:
    * rendering/RenderFlexibleBox.cpp:
    (WebCore::RenderFlexibleBox::firstLineBaseline):
    (WebCore::RenderFlexibleBox::computeMainAxisExtentForChild):
    * rendering/RenderLineBoxList.cpp:
    (WebCore::RenderLineBoxList::deleteLineBoxTree):
    (WebCore::RenderLineBoxList::extractLineBox):
    (WebCore::RenderLineBoxList::deleteLineBoxes):
    (WebCore::RenderLineBoxList::checkConsistency):
    * rendering/RenderLineBoxList.h:
    (WebCore::RenderLineBoxList::RenderLineBoxList):
    * rendering/RenderListBox.cpp:
    (WebCore::RenderListBox::enclosingScrollableArea):
    (WebCore::RenderListBox::setHasVerticalScrollbar):
    * rendering/RenderListBox.h:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182127 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  26. [iOS WK2] WKContentView should implement _selectionClipRect

    enrica@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=143143
    rdar://problem/20330075
    
    Reviewed by Benjamin Poulain.
    
    UIKit checks if the text delegate responds to this selector
    to retrieve the clipping rectangle for the editable element
    where the selection is being create.
    
    * UIProcess/ios/WKContentViewInteraction.mm:
    (-[WKContentView _selectionClipRect]):
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182126 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  27. HTMLCollection caches incorrect length if item(0) is called before le…

    darin@apple.com authored
    …ngth on an empty collection
    
    
    https://bugs.webkit.org/show_bug.cgi?id=143203
    Source/WebCore:
    
    rdar://problem/18460462
    
    Reviewed by Antti Koivisto.
    
    Test: fast/dom/htmlcollection-length-after-item-2.html
    
    * dom/CollectionIndexCache.h:
    (CollectionIndexCache::nodeAt): If we hit the end looking for index 0, cache a length
    of 0, not a length of 1.
    
    LayoutTests:
    
    Reviewed by Antti Koivisto.
    
    * fast/dom/htmlcollection-length-after-item-2-expected.txt: Added.
    * fast/dom/htmlcollection-length-after-item-2.html: Added.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182125 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Commits on Mar 29, 2015
  1. Use st_mtime instead of st_atime to track file access time

    antti@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=143200
    
    Reviewed by Darin Adler.
    
    On OS X atime updates automatically on read so calling Storage::traverse() would always ends up updating access times
    for all cache entries to the current time. This would make entry worth computation produce unexpected results.
    We update mtime manually on successful cache retrieve only so switching to it fixes the problem.
    
    * NetworkProcess/cache/NetworkCacheFileSystemPosix.h:
    (WebKit::NetworkCache::fileTimes):
    (WebKit::NetworkCache::updateFileModificationTimeIfNeeded):
    (WebKit::NetworkCache::updateFileAccessTimeIfNeeded): Deleted.
    * NetworkProcess/cache/NetworkCacheStorage.cpp:
    (WebKit::NetworkCache::Storage::updateFileModificationTime):
    (WebKit::NetworkCache::Storage::dispatchReadOperation):
    (WebKit::NetworkCache::deletionProbability):
    (WebKit::NetworkCache::Storage::updateFileAccessTime): Deleted.
    * NetworkProcess/cache/NetworkCacheStorage.h:
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182124 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  2. [Win] Addresing post-review comment after r182122

    mmaxfield@apple.com authored
  3. [Win] Allow building JavaScriptCore without Cygwin

    mmaxfield@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=143189
    
    Reviewed by Brent Fulgham.
    
    Paths like /usr/bin/ don't exist on Windows.
    Hashbangs don't work on Windows. Instead we must explicitly call the executable.
    Prefixing commands with environment variables doesn't work on Windows.
    Windows doesn't have 'cmp'
    Windows uses 'del' instead of 'rm'
    Windows uses 'type NUL' intead of 'touch'
    
    * DerivedSources.make:
    * JavaScriptCore.vcxproj/JavaScriptCoreGenerated.make:
    * JavaScriptCore.vcxproj/LLInt/LLIntAssembly/LLIntAssembly.make:
    * JavaScriptCore.vcxproj/LLInt/LLIntAssembly/build-LLIntAssembly.pl:
    * JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/LLIntDesiredOffsets.make:
    * JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/build-LLIntDesiredOffsets.pl:
    * JavaScriptCore.vcxproj/build-generated-files.pl:
    * UpdateContents.py: Copied from Source/JavaScriptCore/JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/build-LLIntDesiredOffsets.pl.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182122 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  4. Remove unneeded SVG code, including most isSupportedAttribute functions

    darin@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=143194
    
    Reviewed by Antti Koivisto.
    
    - Removed most implementations of isSupportedAttribute. Others can be removed in
      future patches. The ones left behind are now all private static member functions.
      It's dangerous for them to be public because they tend to indicate which attributes
      are supported at a particular level in the class hierarchy and they are not virtual
      functions; might want to rethink the function name if we keep any of these long term.
    
    - Removed unneeded includes, especially of Attr.h and Attribute.h.
    
    - Changed most parseAttribute and svgAttributeChanged functions so they no longer
      rely on checking attribute names against a set. Also removed lots of unneeded calls
      to SVGLangSpace::parseAttribute, which is called by SVGElement::parseAttribute and
      need not be called by derived classes.
    
    - Removed return values from parseAttribute functions. Skipping other parseAttribute
      logic is not an important optimization and makes functions needlessly complex.
    
    - Moved use of InstanceInvalidationGuard closer to where they are needed. Eventually
      we may be able to remove many of these.
    
    - Used auto in a few places where the same type is repeated twice on the same line of
      code, and auto makes it a bit smaller.
    
    - Got rid of protected sections in some final classes; doesn't make sense to combine
      these two. Also moved a few functions from protected to private in other classes.
    
    - Made a number of functions into static member functions in the base classes such
      as SVGLangSpace; they were not making any use of the object, and so it was wasteful
      to compile them as non-static member functions.
    
    * rendering/svg/RenderSVGImage.cpp: Removed unneeded includes.
    * svg/SVGAElement.cpp: Removed unneeded includes.
    (WebCore::SVGAElement::isSupportedAttribute): Deleted.
    (WebCore::SVGAElement::parseAttribute): Don't use isSupportedAttribute.
    (WebCore::SVGAElement::svgAttributeChanged): Don't use isSupportedAttribute.
    * svg/SVGAElement.h: Removed isSupportedAttribute.
    * svg/SVGAnimateMotionElement.cpp: Removed unneeded includes.
    (WebCore::SVGAnimateMotionElement::isSupportedAttribute): Deleted.
    (WebCore::SVGAnimateMotionElement::parseAttribute): Don't use isSupportedAttribute.
    * svg/SVGAnimateMotionElement.h: Removed isSupportedAttribute.
    * svg/SVGAnimateTransformElement.cpp:
    (WebCore::SVGAnimateTransformElement::isSupportedAttribute): Deleted.
    (WebCore::SVGAnimateTransformElement::parseAttribute): Don't use isSupportedAttribute.
    * svg/SVGAnimateTransformElement.h: Removed isSupportedAttribute.
    * svg/SVGAnimationElement.cpp:
    (WebCore::SVGAnimationElement::parseAttribute): Don't use isSupportedAttribute.
    * svg/SVGCircleElement.cpp:
    (WebCore::SVGCircleElement::isSupportedAttribute): Deleted.
    (WebCore::SVGCircleElement::parseAttribute): Don't use isSupportedAttribute.
    (WebCore::SVGCircleElement::svgAttributeChanged): Don't use isSupportedAttribute.
    * svg/SVGCircleElement.h: Removed isSupportedAttribute.
    * svg/SVGClipPathElement.cpp: Removed unneeded includes.
    (WebCore::SVGClipPathElement::parseAttribute): Don't use isSupportedAttribute.
    * svg/SVGComponentTransferFunctionElement.cpp:
    (WebCore::SVGComponentTransferFunctionElement::parseAttribute): Don't use isSupportedAttribute.
    * svg/SVGCursorElement.cpp: Removed unneeded includes.
    (WebCore::SVGCursorElement::parseAttribute): Don't use isSupportedAttribute.
    (WebCore::SVGCursorElement::svgAttributeChanged): Don't use isSupportedAttribute.
    * svg/SVGElement.cpp: Removed unneeded includes.
    * svg/SVGEllipseElement.cpp: Removed unneeded includes.
    (WebCore::SVGEllipseElement::isSupportedAttribute): Deleted.
    (WebCore::SVGEllipseElement::parseAttribute): Don't use isSupportedAttribute.
    (WebCore::SVGEllipseElement::svgAttributeChanged): Don't use isSupportedAttribute.
    * svg/SVGEllipseElement.h: Removed isSupportedAttribute.
    * svg/SVGExternalResourcesRequired.cpp: Removed unneeded includes.
    (WebCore::SVGExternalResourcesRequired::parseAttribute): Don't return a boolean.
    * svg/SVGExternalResourcesRequired.h: Don't return a boolean.
    * svg/SVGFEBlendElement.cpp: Removed unneeded includes.
    (WebCore::SVGFEBlendElement::isSupportedAttribute): Deleted.
    (WebCore::SVGFEBlendElement::parseAttribute): Don't use isSupportedAttribute.
    (WebCore::SVGFEBlendElement::svgAttributeChanged): Don't use isSupportedAttribute.
    * svg/SVGFEBlendElement.h: Removed isSupportedAttribute.
    * svg/SVGFEColorMatrixElement.cpp: Removed unneeded includes.
    (WebCore::SVGFEColorMatrixElement::isSupportedAttribute): Deleted.
    (WebCore::SVGFEColorMatrixElement::parseAttribute): Don't use isSupportedAttribute.
    (WebCore::SVGFEColorMatrixElement::svgAttributeChanged): Don't use isSupportedAttribute.
    * svg/SVGFEColorMatrixElement.h: Removed isSupportedAttribute.
    * svg/SVGFEComponentTransferElement.cpp: Removed unneeded includes.
    (WebCore::SVGFEComponentTransferElement::isSupportedAttribute): Deleted.
    (WebCore::SVGFEComponentTransferElement::parseAttribute): Don't use isSupportedAttribute.
    * svg/SVGFEComponentTransferElement.h: Removed unneeded includes.
    * svg/SVGFECompositeElement.cpp: Removed unneeded includes.
    (WebCore::SVGFECompositeElement::isSupportedAttribute): Deleted.
    (WebCore::SVGFECompositeElement::parseAttribute): Don't use isSupportedAttribute.
    (WebCore::SVGFECompositeElement::svgAttributeChanged): Don't use isSupportedAttribute.
    * svg/SVGFECompositeElement.h:
    * svg/SVGFEConvolveMatrixElement.cpp: Removed unneeded includes.
    (WebCore::SVGFEConvolveMatrixElement::isSupportedAttribute): Deleted.
    (WebCore::SVGFEConvolveMatrixElement::parseAttribute): Don't use isSupportedAttribute.
    (WebCore::SVGFEConvolveMatrixElement::svgAttributeChanged): Don't use isSupportedAttribute.
    * svg/SVGFEConvolveMatrixElement.h:
    * svg/SVGFEDiffuseLightingElement.cpp: Removed unneeded includes.
    (WebCore::SVGFEDiffuseLightingElement::isSupportedAttribute): Deleted.
    (WebCore::SVGFEDiffuseLightingElement::parseAttribute): Don't use isSupportedAttribute.
    (WebCore::SVGFEDiffuseLightingElement::svgAttributeChanged): Don't use isSupportedAttribute.
    * svg/SVGFEDiffuseLightingElement.h:
    * svg/SVGFEDisplacementMapElement.cpp: Removed unneeded includes.
    (WebCore::SVGFEDisplacementMapElement::isSupportedAttribute): Deleted.
    (WebCore::SVGFEDisplacementMapElement::parseAttribute): Don't use isSupportedAttribute.
    (WebCore::SVGFEDisplacementMapElement::svgAttributeChanged): Don't use isSupportedAttribute.
    * svg/SVGFEDisplacementMapElement.h:
    * svg/SVGFEDropShadowElement.cpp: Removed unneeded includes.
    (WebCore::SVGFEDropShadowElement::isSupportedAttribute): Deleted.
    (WebCore::SVGFEDropShadowElement::parseAttribute): Don't use isSupportedAttribute.
    (WebCore::SVGFEDropShadowElement::svgAttributeChanged): Don't use isSupportedAttribute.
    * svg/SVGFEDropShadowElement.h:
    * svg/SVGFEFloodElement.cpp: Removed unneeded includes.
    * svg/SVGFEGaussianBlurElement.cpp: Removed unneeded includes.
    (WebCore::SVGFEGaussianBlurElement::isSupportedAttribute): Deleted.
    (WebCore::SVGFEGaussianBlurElement::parseAttribute): Don't use isSupportedAttribute.
    (WebCore::SVGFEGaussianBlurElement::svgAttributeChanged): Don't use isSupportedAttribute.
    * svg/SVGFEGaussianBlurElement.h:
    * svg/SVGFEImageElement.cpp: Removed unneeded includes.
    (WebCore::SVGFEImageElement::isSupportedAttribute): Deleted.
    (WebCore::SVGFEImageElement::parseAttribute): Don't use isSupportedAttribute.
    (WebCore::SVGFEImageElement::svgAttributeChanged): Don't use isSupportedAttribute.
    * svg/SVGFEImageElement.h:
    * svg/SVGFELightElement.cpp: Removed unneeded includes.
    (WebCore::SVGFELightElement::isSupportedAttribute): Deleted.
    (WebCore::SVGFELightElement::parseAttribute): Don't use isSupportedAttribute.
    (WebCore::SVGFELightElement::svgAttributeChanged): Don't use isSupportedAttribute.
    * svg/SVGFELightElement.h:
    * svg/SVGFEMergeNodeElement.cpp: Removed unneeded includes.
    (WebCore::SVGFEMergeNodeElement::isSupportedAttribute): Deleted.
    (WebCore::SVGFEMergeNodeElement::parseAttribute): Don't use isSupportedAttribute.
    (WebCore::SVGFEMergeNodeElement::svgAttributeChanged): Don't use isSupportedAttribute.
    * svg/SVGFEMergeNodeElement.h:
    * svg/SVGFEMorphologyElement.cpp: Removed unneeded includes.
    (WebCore::SVGFEMorphologyElement::isSupportedAttribute): Deleted.
    (WebCore::SVGFEMorphologyElement::parseAttribute): Don't use isSupportedAttribute.
    (WebCore::SVGFEMorphologyElement::svgAttributeChanged): Don't use isSupportedAttribute.
    * svg/SVGFEMorphologyElement.h:
    * svg/SVGFEOffsetElement.cpp: Removed unneeded includes.
    (WebCore::SVGFEOffsetElement::isSupportedAttribute): Deleted.
    (WebCore::SVGFEOffsetElement::parseAttribute): Don't use isSupportedAttribute.
    (WebCore::SVGFEOffsetElement::svgAttributeChanged): Don't use isSupportedAttribute.
    * svg/SVGFEOffsetElement.h:
    * svg/SVGFESpecularLightingElement.cpp: Removed unneeded includes.
    (WebCore::SVGFESpecularLightingElement::isSupportedAttribute): Deleted.
    (WebCore::SVGFESpecularLightingElement::parseAttribute): Don't use isSupportedAttribute.
    (WebCore::SVGFESpecularLightingElement::svgAttributeChanged): Don't use isSupportedAttribute.
    * svg/SVGFESpecularLightingElement.h:
    * svg/SVGFETileElement.cpp: Removed unneeded includes.
    (WebCore::SVGFETileElement::isSupportedAttribute): Deleted.
    (WebCore::SVGFETileElement::parseAttribute): Don't use isSupportedAttribute.
    (WebCore::SVGFETileElement::svgAttributeChanged): Don't use isSupportedAttribute.
    * svg/SVGFETileElement.h:
    * svg/SVGFETurbulenceElement.cpp: Removed unneeded includes.
    (WebCore::SVGFETurbulenceElement::isSupportedAttribute): Deleted.
    (WebCore::SVGFETurbulenceElement::parseAttribute): Don't use isSupportedAttribute.
    (WebCore::SVGFETurbulenceElement::svgAttributeChanged): Don't use isSupportedAttribute.
    * svg/SVGFETurbulenceElement.h:
    * svg/SVGFilterElement.cpp: Removed unneeded includes.
    (WebCore::SVGFilterElement::parseAttribute): Don't use isSupportedAttribute.
    * svg/SVGFilterPrimitiveStandardAttributes.cpp: Removed unneeded includes.
    (WebCore::SVGFilterPrimitiveStandardAttributes::parseAttribute): Don't use isSupportedAttribute.
    * svg/SVGFilterPrimitiveStandardAttributes.h: Removed isSupportedAttribute and also moved a
    couple functions out of the class definition.
    * svg/SVGFitToViewBox.cpp: Removed unneeded includes.
    * svg/SVGFontFaceElement.cpp: Removed unneeded includes.
    * svg/SVGFontFaceUriElement.cpp: Removed unneeded includes.
    * svg/SVGForeignObjectElement.cpp: Removed unneeded includes.
    (WebCore::SVGForeignObjectElement::parseAttribute): Don't use isSupportedAttribute.
    * svg/SVGGElement.cpp: Removed unneeded includes.
    (WebCore::SVGGElement::parseAttribute): Don't use isSupportedAttribute.
    * svg/SVGGlyphElement.cpp: Removed unneeded includes.
    * svg/SVGGlyphRefElement.cpp: Removed unneeded includes.
    (WebCore::SVGGlyphRefElement::hasValidGlyphElement): Rewrote to use is<> instead of hasTagName.
    (WebCore::SVGGlyphRefElement::parseAttribute): Don't use return value from SVGURIReference::parseAttribute.
    * svg/SVGGradientElement.cpp: Removed unneeded includes.
    (WebCore::SVGGradientElement::parseAttribute): Don't use isSupportedAttribute.
    * svg/SVGGraphicsElement.cpp: Removed unneeded includes.
    (WebCore::SVGGraphicsElement::parseAttribute): Don't use isSupportedAttribute.
    * svg/SVGImageElement.cpp: Removed unneeded includes.
    (WebCore::SVGImageElement::parseAttribute): Don't use isSupportedAttribute.
    * svg/SVGLangSpace.cpp: Removed unneeded includes.
    (WebCore::SVGLangSpace::parseAttribute): Removed the return value.
    * svg/SVGLangSpace.h: Converted functions to static member functions and removed the
    return value from parseAttribute.
    * svg/SVGLineElement.cpp: Removed unneeded includes.
    (WebCore::SVGLineElement::parseAttribute): Don't use isSupportedAttribute.
    * svg/SVGLinearGradientElement.cpp: Removed unneeded includes.
    (WebCore::SVGLinearGradientElement::parseAttribute): Don't use isSupportedAttribute.
    * svg/SVGMPathElement.cpp: Removed unneeded includes.
    (WebCore::SVGMPathElement::isSupportedAttribute): Deleted.
    (WebCore::SVGMPathElement::parseAttribute): Don't use isSupportedAttribute.
    (WebCore::SVGMPathElement::svgAttributeChanged): Don't use isSupportedAttribute.
    * svg/SVGMPathElement.h: Removed isSupportedAttribute and made didNotifySubtreeInsertions
    private instead of protected.
    * svg/SVGMarkerElement.cpp: Removed unneeded includes.
    (WebCore::SVGMarkerElement::parseAttribute): Don't use isSupportedAttribute.
    * svg/SVGMaskElement.cpp: Removed unneeded includes.
    (WebCore::SVGMaskElement::parseAttribute): Don't use isSupportedAttribute.
    * svg/SVGPathElement.cpp: Removed unneeded includes.
    (WebCore::SVGPathElement::parseAttribute): Don't use isSupportedAttribute.
    * svg/SVGPatternElement.cpp: Removed unneeded includes.
    (WebCore::SVGPatternElement::parseAttribute): Don't use isSupportedAttribute.
    * svg/SVGPolyElement.cpp: Removed unneeded includes.
    (WebCore::SVGPolyElement::isSupportedAttribute): Deleted.
    (WebCore::SVGPolyElement::parseAttribute): Don't use isSupportedAttribute.
    (WebCore::SVGPolyElement::svgAttributeChanged): Don't use isSupportedAttribute.
    * svg/SVGPolyElement.h:
    * svg/SVGRadialGradientElement.cpp: Removed unneeded includes.
    (WebCore::SVGRadialGradientElement::parseAttribute): Don't use isSupportedAttribute.
    * svg/SVGRectElement.cpp: Removed unneeded includes.
    (WebCore::SVGRectElement::isSupportedAttribute): Deleted.
    (WebCore::SVGRectElement::parseAttribute): Don't use isSupportedAttribute.
    (WebCore::SVGRectElement::svgAttributeChanged): Don't use isSupportedAttribute.
    * svg/SVGRectElement.h:
    * svg/SVGSVGElement.cpp: Removed unneeded includes.
    (WebCore::SVGSVGElement::parseAttribute): Don't use isSupportedAttribute.
    * svg/SVGScriptElement.cpp: Removed unneeded includes.
    * svg/SVGStopElement.cpp: Removed unneeded includes.
    (WebCore::SVGStopElement::isSupportedAttribute): Deleted.
    (WebCore::SVGStopElement::parseAttribute): Don't use isSupportedAttribute.
    (WebCore::SVGStopElement::svgAttributeChanged): Don't use isSupportedAttribute.
    * svg/SVGStopElement.h: Removed isSupportedAttribute.
    * svg/SVGStyleElement.cpp: Removed unneeded includes.
    (WebCore::SVGStyleElement::isSupportedAttribute): Deleted.
    (WebCore::SVGStyleElement::parseAttribute): Don't use isSupportedAttribute.
    * svg/SVGStyleElement.h: Removed isSupportedAttribute.
    * svg/SVGSymbolElement.cpp: Removed unneeded includes.
    (WebCore::SVGSymbolElement::isSupportedAttribute): Deleted.
    (WebCore::SVGSymbolElement::parseAttribute): Don't use isSupportedAttribute.
    (WebCore::SVGSymbolElement::svgAttributeChanged): Don't use isSupportedAttribute.
    * svg/SVGSymbolElement.h: Removed isSupportedAttribute.
    * svg/SVGTRefElement.cpp: Removed unneeded includes.
    (WebCore::SVGTRefElement::isSupportedAttribute): Deleted.
    (WebCore::SVGTRefElement::parseAttribute): Don't use isSupportedAttribute.
    (WebCore::SVGTRefElement::svgAttributeChanged): Don't use isSupportedAttribute.
    * svg/SVGTRefElement.h: Removed isSupportedAttribute and made didNotifySubtreeInsertions
    private instead of protected.
    * svg/SVGTests.cpp: Removed unneeded includes.
    (WebCore::SVGTests::parseAttribute): Removed return value.
    * svg/SVGTests.h: Removed return value of parseAttribute.
    * svg/SVGTextContentElement.cpp: Removed unneeded includes.
    (WebCore::SVGTextContentElement::collectStyleForPresentationAttribute): Don't use
    isSupportedAttribute. Also removed global to optimize comparing attribute value against
    the string "preserve".
    (WebCore::SVGTextContentElement::parseAttribute): Don't use isSupportedAttribute.
    (WebCore::SVGTextContentElement::svgAttributeChanged): Don't use isSupportedAttribute.
    * svg/SVGTextContentElement.h: Made isSupportedAttribute private instead of protected.
    * svg/SVGTextElement.cpp: Removed unneeded includes.
    * svg/SVGTextPathElement.cpp: Removed unneeded includes.
    (WebCore::SVGTextPathElement::parseAttribute): Don't use isSupportedAttribute.
    * svg/SVGTextPositioningElement.cpp: Removed unneeded includes.
    (WebCore::SVGTextPositioningElement::isSupportedAttribute): Deleted.
    (WebCore::SVGTextPositioningElement::parseAttribute): Don't use isSupportedAttribute.
    (WebCore::SVGTextPositioningElement::svgAttributeChanged): Don't use isSupportedAttribute.
    * svg/SVGTextPositioningElement.h: Removed isSupportedAttribute and made some functions
    private insetad of protected.
    * svg/SVGURIReference.cpp: Removed unneeded includes.
    (WebCore::SVGURIReference::parseAttribute): Don't use isSupportedAttribute.
    * svg/SVGURIReference.h:
    (WebCore::SVGURIReference::isExternalURIReference):
    * svg/SVGUseElement.cpp: Removed unneeded includes.
    (WebCore::SVGUseElement::parseAttribute): Don't use isSupportedAttribute.
    * svg/SVGViewElement.h: Removed isSupportedAttribute.
    * svg/animation/SVGSMILElement.cpp: Removed unneeded includes.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182121 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  5. Remove unneeded includes of "Attribute.h"

    darin@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=143195
    
    Reviewed by Antti Koivisto.
    
    * css/StyleResolver.cpp:
    * html/HTMLAnchorElement.cpp:
    * html/HTMLAreaElement.cpp:
    * html/HTMLBRElement.cpp:
    * html/HTMLBaseElement.cpp:
    * html/HTMLBodyElement.cpp:
    * html/HTMLButtonElement.cpp:
    * html/HTMLCanvasElement.cpp:
    * html/HTMLDivElement.cpp:
    * html/HTMLElement.cpp:
    * html/HTMLEmbedElement.cpp:
    * html/HTMLFontElement.cpp:
    * html/HTMLFormControlElement.cpp:
    * html/HTMLFormElement.cpp:
    * html/HTMLFrameElement.cpp:
    * html/HTMLFrameElementBase.cpp:
    * html/HTMLFrameSetElement.cpp:
    * html/HTMLHRElement.cpp:
    * html/HTMLIFrameElement.cpp:
    * html/HTMLImageElement.cpp:
    * html/HTMLOListElement.cpp:
    * html/HTMLOptionElement.cpp:
    * html/HTMLParagraphElement.cpp:
    * html/HTMLParamElement.cpp:
    * html/HTMLPlugInElement.cpp:
    * html/HTMLPreElement.cpp:
    * html/HTMLProgressElement.cpp:
    * html/HTMLScriptElement.cpp:
    * html/HTMLSelectElement.cpp:
    * html/HTMLStyleElement.cpp:
    * html/HTMLTableCaptionElement.cpp:
    * html/HTMLTableCellElement.cpp:
    * html/HTMLTableColElement.cpp:
    * html/HTMLTableElement.cpp:
    * html/HTMLTablePartElement.cpp:
    * html/HTMLTextAreaElement.cpp:
    * html/HTMLTextFormControlElement.cpp:
    * html/HTMLUListElement.cpp:
    * html/HTMLVideoElement.cpp:
    * html/parser/HTMLScriptRunner.cpp:
    * inspector/InspectorNodeFinder.cpp:
    Removed includes of "Attribute.h".
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182120 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  6. [buildbot] clean-build script should remove untracked files and rever…

    youenn.fablet@crf.canon.fr authored
    …t local changes too
    
    
    https://bugs.webkit.org/show_bug.cgi?id=142400
    
    Reviewed by Ryosuke Niwa.
    
    This patch cleans the WebKit folder by deleting SCM untracked files and reverting changes for tracked files.
    
    * BuildSlaveSupport/clean-build:
    (main): Adding call to Tools/Scripts/clean-webkit.
    * Scripts/clean-webkit: Added.
    (main): Removes untracked and changed files.
    * Scripts/webkitpy/common/checkout/scm/git.py:
    (Git.untracked_files): Retrieves GIT untracked files.
    * Scripts/webkitpy/common/checkout/scm/scm.py:
    (SCM.untracked_files): Retrieves SVN untracked files.
    (SCM):
    (SCM.discard_untracked_files): Deletes untracked files/folders.
    * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
    (SCMTest._shared_test_untracked_files): Unit testing for untracked files.
    (test_untracked_files):
    (GitSVNTest.test_untracked_files):
    * Scripts/webkitpy/common/checkout/scm/svn.py:
    (SVN.untracked_files):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182119 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  7. Clean up JavaScriptCore/builtins

    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=143177
    
    Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-03-28
    Reviewed by Ryosuke Niwa.
    
    * builtins/ArrayConstructor.js:
    (from):
    - We can compare to undefined instead of using a typeof undefined check.
    - Converge on double quoted strings everywhere.
    
    * builtins/ArrayIterator.prototype.js:
    (next):
    * builtins/StringIterator.prototype.js:
    (next):
    - Use shorthand object construction to avoid duplication.
    - Improve grammar in error messages.
    
    * tests/stress/array-iterators-next-with-call.js:
    * tests/stress/string-iterators.js:
    - Update for new error message strings.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182118 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  8. [Mac] Update for output device API change

    eric.carlson@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=143187
    
    Reviewed by Zalan Bujtas.
    
    The API used for output device is being deprecated, update to the replacement.
    
    * WebCore.xcodeproj/project.pbxproj: Add SPI headers.
    
    * platform/graphics/MediaPlaybackTarget.h:
    (WebCore::MediaPlaybackTarget::MediaPlaybackTarget): Update for API change.
    (WebCore::MediaPlaybackTarget::setDevicePickerContext):
    (WebCore::MediaPlaybackTarget::devicePickerContext):
    
    * platform/graphics/avfoundation/MediaPlaybackTargetMac.mm:
    (WebCore::MediaPlaybackTarget::encode):
    (WebCore::MediaPlaybackTarget::decode):
    
    * platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.h:
    * platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:
    (WebCore::MediaPlaybackTargetPickerMac::MediaPlaybackTargetPickerMac):
    (WebCore::MediaPlaybackTargetPickerMac::~MediaPlaybackTargetPickerMac):
    (WebCore::MediaPlaybackTargetPickerMac::outputeDeviceAvailabilityChangedTimerFired):
    (WebCore::MediaPlaybackTargetPickerMac::devicePicker):
    (WebCore::MediaPlaybackTargetPickerMac::currentDeviceDidChange):
    (WebCore::MediaPlaybackTargetPickerMac::stopMonitoringPlaybackTargets):
    (-[WebAVOutputDeviceMenuControllerHelper observeValueForKeyPath:ofObject:change:context:]):
    (-[WebAVOutputDevicePickerMenuControllerHelper observeValueForKeyPath:ofObject:change:context:]): Deleted.
    
    * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
    * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
    (WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad):
    (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
    (WebCore::MediaPlayerPrivateAVFoundationObjC::setWirelessPlaybackTarget):
    (-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]):
    
    * platform/spi/cocoa/AVKitSPI.h: Copied from Source/WebCore/platform/spi/ios/AVKitSPI.h. Moved
        from ios directory, added Mac includes and prototypes.
    * platform/spi/ios/AVKitSPI.h: Removed.
    
    * platform/spi/mac/AVFoundationSPI.h: Added.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@182117 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Something went wrong with that request. Please try again.