Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
branch: master

Apr 17, 2014

  1. InlineCallFrameSet should be refcounted

    https://bugs.webkit.org/show_bug.cgi?id=131829
    
    Reviewed by Geoffrey Garen.
            
    And DFG::Plan should hold a ref to it. Previously it was owned by Graph until it
    became owned by JITCode. Except that if we're "failing" to compile, JITCode may die.
    Even as it dies, the GC may still want to scan the DFG::Plan, which leads to scanning
    the DesiredWriteBarriers, which leads to scanning the InlineCallFrameSet.
            
    So, just make the darn thing refcounted.
    
    * bytecode/InlineCallFrameSet.h:
    * dfg/DFGArgumentsSimplificationPhase.cpp:
    (JSC::DFG::ArgumentsSimplificationPhase::run):
    * dfg/DFGByteCodeParser.cpp:
    (JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
    * dfg/DFGCommonData.h:
    * dfg/DFGGraph.cpp:
    (JSC::DFG::Graph::Graph):
    (JSC::DFG::Graph::requiredRegisterCountForExit):
    * dfg/DFGGraph.h:
    * dfg/DFGJITCompiler.cpp:
    (JSC::DFG::JITCompiler::link):
    * dfg/DFGPlan.cpp:
    (JSC::DFG::Plan::Plan):
    * dfg/DFGPlan.h:
    * dfg/DFGStackLayoutPhase.cpp:
    (JSC::DFG::StackLayoutPhase::run):
    * ftl/FTLFail.cpp:
    (JSC::FTL::fail):
    * ftl/FTLLink.cpp:
    (JSC::FTL::link):
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@167467 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    authored April 17, 2014
  2. Rollout: Add a way to cache never-changing IDL attributes in the wrap…

    …per.
    
    <https://webkit.org/b/131759>
    
    This behavior may be observable from the web, so we can't do it this way.
    
    * bindings/scripts/CodeGeneratorJS.pm:
    (GenerateImplementation):
    * bindings/scripts/IDLAttributes.txt:
    * bindings/scripts/test/*:
    * dom/Element.idl:
    * dom/Node.idl:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@167466 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    authored April 17, 2014
  3. [iOS] REGRESSION (r166975): WKPDFView is broken

    https://bugs.webkit.org/show_bug.cgi?id=131828
    
    Reviewed by Simon Fraser.
    
    * UIProcess/API/Cocoa/WKWebView.mm:
    (-[WKWebView _didCommitLayerTree:WebKit::]):
    Bail from updating the scroll view parameters from the layer tree update
    while it's being managed by a custom content view.
    We'll get any changes again in the next commit after removing the custom
    content view (and painting the new page) anyway, so this should be OK.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@167465 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    authored April 17, 2014
  4. Cheesy Mountain Lion build fix.

    * platform/MemoryPressureHandler.h:
    (WebCore::MemoryPressureHandler::ReliefLogger::logString):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@167464 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    authored April 17, 2014
  5. [New Multicolumn] Column rules don't respect the specified stacking o…

    …rder.
    
    
    https://bugs.webkit.org/show_bug.cgi?id=131804
    
    Reviewed by Beth Dakin.
    
    
    Source/WebCore: 
    Added fast/multicol/newmulticol/compare_with_old_impl/column-rules-stacking.html
    
    * rendering/RenderBlockFlow.cpp:
    (WebCore::RenderBlockFlow::paintBoxDecorations):
    * rendering/RenderBlockFlow.h:
    Override paintBoxDecorations for block flows so that we can iterate over our column sets
    and paint their rules just after painting our background and border. We can't wait until
    the child column sets paint their backgrounds, since that is specified as being above negative
    z-index children. We have to pretend that the column sets don't exist as
    far as column rule painting is concerned.
    
    * rendering/RenderMultiColumnSet.cpp:
    (WebCore::RenderMultiColumnSet::paintObject): Deleted.
    * rendering/RenderMultiColumnSet.h:
    Turn paintObject in RenderMultiColumnSet into an override that doesn't paint anything.
    
    LayoutTests: 
    * fast/multicol/newmulticol/compare-with-old-impl/column-rules-stacking-expected.html: Added.
    * fast/multicol/newmulticol/compare-with-old-impl/column-rules-stacking.html: Added.
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@167463 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    authored April 17, 2014
  6. Hit-testing is incorrect for plugins inside iframes when there is a

    topContentInset
    https://bugs.webkit.org/show_bug.cgi?id=131826
    -and corresponding-
    <rdar://problem/16649996>
    
    Reviewed by Tim Horton.
    
    I missed one coordinate-conversion spot when getting hit-testing to work. Like 
    headerHeight() which also manipulates the location of the root layer, 
    topContentInset() has to be factored into all of these conversions.
    * page/FrameView.cpp:
    (WebCore::FrameView::convertFromRenderer):
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@167460 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    authored April 17, 2014
  7. _webProcessIdentifier should return 0 if the web process crashed

    https://bugs.webkit.org/show_bug.cgi?id=131813
    <rdar://problem/16650605>
    
    Reviewed by Anders Carlsson.
    
    * UIProcess/API/Cocoa/WKWebView.mm:
    (-[WKWebView _hasWebProcess]):
    * UIProcess/API/Cocoa/WKWebViewPrivate.h:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@167457 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    authored April 17, 2014
  8. FTL::fail() should manage memory "correctly"

    https://bugs.webkit.org/show_bug.cgi?id=131823
    <rdar://problem/16384297>
    
    Reviewed by Oliver Hunt.
    
    * ftl/FTLFail.cpp:
    (JSC::FTL::fail):
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@167456 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    authored April 17, 2014
  9. Prediction propagator should correctly model Int52s flowing through a…

    …rguments
    
    
    https://bugs.webkit.org/show_bug.cgi?id=131822
    <rdar://problem/16641408>
    
    Reviewed by Oliver Hunt.
    
    * dfg/DFGPredictionPropagationPhase.cpp:
    (JSC::DFG::PredictionPropagationPhase::propagate):
    * tests/stress/int52-argument.js: Added.
    (foo):
    * tests/stress/int52-variable.js: Added.
    (foo):
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@167455 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    authored April 17, 2014
  10. Stub out MemoryPressureHandler::ReliefLogger on older OS X'es.

    * platform/cocoa/MemoryPressureHandlerCocoa.mm:
    (WebCore::MemoryPressureHandler::ReliefLogger::platformLog):
    (WebCore::MemoryPressureHandler::ReliefLogger::platformMemoryUsage):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@167454 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    authored April 17, 2014
  11. Don't include CompilationThread.h from StringImpl.h

    https://bugs.webkit.org/show_bug.cgi?id=131817
    
    Reviewed by Simon Fraser.
    
    * wtf/CompilationThread.h:
    * wtf/StdLibExtras.h:
    * wtf/text/StringImpl.h:
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@167453 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    authored April 17, 2014
  12. REGRESSION: ASSERT(!typeInfo().hasImpureGetOwnPropertySlot() || typeI…

    …nfo().newImpurePropertyFiresWatchpoints()) on jquery tests
    
    
    https://bugs.webkit.org/show_bug.cgi?id=131798
    
    Reviewed by Alexey Proskuryakov.
            
    Some day, we will fix https://bugs.webkit.org/show_bug.cgi?id=131810 and some version
    of this assertion can return. For now, it's not clear that the assertion is guarding
    any truly undesirable behavior - so it should just go away and be replaced with a
    FIXME.
    
    * bytecode/GetByIdStatus.cpp:
    (JSC::GetByIdStatus::computeForStubInfo):
    * runtime/Structure.h:
    (JSC::Structure::takesSlowPathInDFGForImpureProperty):
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@167452 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    authored April 17, 2014
  13. Remove CANVAS_PATH where possible

    https://bugs.webkit.org/show_bug.cgi?id=131788
    
    Reviewed by Dean Jackson.
    
    Since Firefox and Chrome ship the same interoperable subset of Path2D soon,
    it is time to remove CANVAS_PATH where possible.
    
    * html/canvas/CanvasRenderingContext2D.cpp:
    (WebCore::CanvasRenderingContext2D::clip):
    (WebCore::CanvasRenderingContext2D::isPointInStroke):
    * html/canvas/CanvasRenderingContext2D.h:
    * html/canvas/CanvasRenderingContext2D.idl:
    * html/canvas/DOMPath.h:
    * html/canvas/DOMPath.idl:
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@167451 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    authored April 17, 2014
  14. [GStreamer] Store TrackPrivateBaseGStreamer's label and language as A…

    …tomicStrings
    
    
    https://bugs.webkit.org/show_bug.cgi?id=130404
    
    Reviewed by Philippe Normand.
    
    No new tests, this just makes things more efficient.
    
    * platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:
    (WebCore::TrackPrivateBaseGStreamer::getLanguageCode):
    (WebCore::TrackPrivateBaseGStreamer::getTag):
    * platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h:
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@167450 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    authored April 17, 2014
  15. Fix Cocoa build.

    * platform/cocoa/MemoryPressureHandlerCocoa.mm:
    (WebCore::MemoryPressureHandler::ReliefLogger::platformMemoryUsage):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@167449 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    authored April 17, 2014
  16. [CSS Blending] Remove the -webkit- prefix for mix-blend-mode and isol…

    …ation CSS properties
    
    
    https://bugs.webkit.org/show_bug.cgi?id=131355
    
    Reviewed by Dean Jackson.
    
    Source/WebCore:
    Removed webkit prefix from mix-blend-mode and isolation. These properties
    never shipped and their spec is now in CR.
    
    Covered by existing tests.
    
    * css/CSSComputedStyleDeclaration.cpp:
    (WebCore::ComputedStyleExtractor::propertyValue):
    * css/CSSParser.cpp:
    (WebCore::isValidKeywordPropertyAndValue):
    (WebCore::isKeywordPropertyID):
    (WebCore::CSSParser::parseValue):
    * css/CSSPropertyNames.in:
    * css/DeprecatedStyleBuilder.cpp:
    (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
    
    LayoutTests:
    Removed prefix from mix-blend-mode and isolation in layout tests.
    
    * css3/compositing/blend-mode-accelerated-with-multiple-stacking-contexts.html:
    * css3/compositing/blend-mode-ancestor-clipping-layer.html:
    * css3/compositing/blend-mode-background.html:
    * css3/compositing/blend-mode-blended-element-overlapping-composited-sibling-should-have-compositing-layer.html:
    * css3/compositing/blend-mode-isolated-group-1.html:
    * css3/compositing/blend-mode-isolated-group-2.html:
    * css3/compositing/blend-mode-isolated-group-3.html:
    * css3/compositing/blend-mode-layers.html:
    * css3/compositing/blend-mode-parent-of-composited-blended-has-layer.html:
    * css3/compositing/blend-mode-property-expected.txt:
    * css3/compositing/blend-mode-property-parsing-expected.txt:
    * css3/compositing/blend-mode-property-parsing-invalid-expected.txt:
    * css3/compositing/blend-mode-reflection.html:
    * css3/compositing/blend-mode-simple-composited.html:
    * css3/compositing/blend-mode-simple.html:
    * css3/compositing/blend-mode-transform-style-expected.txt:
    * css3/compositing/blend-mode-transform-style.html:
    * css3/compositing/blend-mode-with-accelerated-sibling.html:
    * css3/compositing/blend-mode-with-composited-descendant-should-have-layer.html:
    * css3/compositing/isolation-isolate-blended-child-expected.html:
    * css3/compositing/isolation-isolate-blended-child.html:
    * css3/compositing/isolation-parsing.html:
    * css3/compositing/script-tests/blend-mode-property-parsing-invalid.js:
    (testInvalidFilterRule):
    * css3/compositing/script-tests/blend-mode-property-parsing.js:
    (testBlendModeRule):
    * css3/compositing/script-tests/blend-mode-property.js:
    (testblendmode):
    * css3/compositing/svg-blend-color-dodge.html:
    * css3/compositing/svg-blend-color.html:
    * css3/compositing/svg-blend-hard-light.html:
    * css3/compositing/svg-blend-hue.html:
    * css3/compositing/svg-blend-layer-blend.html:
    * css3/compositing/svg-blend-layer-clip-path.html:
    * css3/compositing/svg-blend-layer-filter.html:
    * css3/compositing/svg-blend-layer-opacity.html:
    * css3/compositing/svg-blend-layer-shadow.html:
    * css3/compositing/svg-blend-luminosity.html:
    * css3/compositing/svg-blend-multiply-alpha.html:
    * css3/compositing/svg-blend-multiply.html:
    * css3/compositing/svg-blend-saturation.html:
    * css3/compositing/svg-blend-screen.html:
    * css3/compositing/svg-blend-soft-light.html:
    * css3/compositing/svg-isolation-default-expected.html:
    * css3/compositing/svg-isolation-default.html:
    * css3/compositing/svg-isolation-isolated-group-expected.html:
    * css3/compositing/svg-isolation-isolated-group.html:
    * fast/repaint/blend-mode-isolate-stacking-context.html:
    * inspector-protocol/layers/layers-blending-compositing-reasons.html:
    * transitions/blendmode-transitions-expected.txt:
    * transitions/blendmode-transitions.html:
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@167448 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    authored April 17, 2014
  17. Tidy up isIsolatedInline() and highestContainingIsolateWithinRoot()

    <http://webkit.org/b/131117>
    
    Reviewed by Daniel Bates.
    
    Based on review feedback for r166650.
    
    * rendering/InlineIterator.h:
    (WebCore::isIsolatedInline):
    - Switch argument to a reference since it is never called with a
      nullptr.
    (WebCore::highestContainingIsolateWithinRoot):
    - Switch first argument to a reference since it's never a
      nullptr.
    - Use nullptr for pointer initialization.
    - Switch while() loop to for() loop. Pass reference to
      isIsolatedInline().
    (WebCore::numberOfIsolateAncestors):
    - Switch while() loop to for() loop. Pass reference to
      isIsolatedInline().
    * rendering/RenderBlockLineLayout.cpp:
    (WebCore::constructBidiRunsForSegment):
    - Rename startObj to startObject.
    - No longer need to pass the address of startObject here.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@167447 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    authored April 17, 2014
  18. Fix build bustage.

    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@167446 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    authored April 17, 2014
  19. Log number of bytes reclaimed at each step of memory pressure relief.

    <https://webkit.org/b/131751>
    
    Reviewed by Antti Koivisto.
    
    * platform/MemoryPressureHandler.h:
    * platform/MemoryPressureHandler.cpp:
    (WebCore::MemoryPressureHandler::ReliefLogger::platformLog):
    (WebCore::MemoryPressureHandler::ReliefLogger::platformMemoryUsage):
    (WebCore::MemoryPressureHandler::ReliefLogger::ReliefLogger):
    (WebCore::MemoryPressureHandler::ReliefLogger::~ReliefLogger):
    * platform/cocoa/MemoryPressureHandlerCocoa.mm:
    (WebCore::MemoryPressureHandlerCocoa::ReliefLogger::platformMemoryUsage):
    (WebCore::MemoryPressureHandlerCocoa::ReliefLogger::platformLog):
    
        Add a simple RAII helper to check memory usage before and after
        a block of code, and then dump the delta to system log.
    
    (WebCore::MemoryPressureHandler::releaseMemory):
    * platform/cocoa/MemoryPressureHandlerCocoa.mm:
    (WebCore::MemoryPressureHandler::platformReleaseMemory):
    
        Use ReliefLogger to annotate the various attempts to reduce
        our memory footprint. This will help us understand the efficiency
        of our current strategy.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@167445 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    authored April 17, 2014
  20. [New Multicolumn] columnNumberForOffset is not patched for new multic…

    …olumn code yet.
    
    
    https://bugs.webkit.org/show_bug.cgi?id=131740
    
    Reviewed by Enrica Casucci.
            
    I took the opportunity to clean this code up while adding support for the new columns.
    columnNumberForOffset only applied for paginated RenderViews and was really about
    pages and not columns. It also only returns an actual page number if the columns are
    block progressed (e.g., right-to-left vertical Japanese books).
            
    Therefore I renamed columnNumberForOffset to pageNumberForBlockProgressionOffset and
    moved it to RenderView.
            
    I also renamed the member variable of SelectionRect to be pageNumber instead of
    columnNumber in order to make it more obvious that this isn't about columns per se
    (since the fact that we implemented RenderView's pagination mode using columns is an
    implementation detail).
    
    * dom/Range.cpp:
    (WebCore::coalesceSelectionRects):
    (WebCore::Range::collectSelectionRects):
    * platform/ios/SelectionRect.h:
    (WebCore::SelectionRect::pageNumber):
    (WebCore::SelectionRect::columnNumber): Deleted.
    * rendering/RenderImage.cpp:
    (WebCore::RenderImage::collectSelectionRects):
    * rendering/RenderObject.cpp:
    (WebCore::RenderObject::collectSelectionRects):
    (WebCore::RenderObject::columnNumberForOffset): Deleted.
    * rendering/RenderObject.h:
    * rendering/RenderText.cpp:
    (WebCore::RenderText::collectSelectionRects):
    * rendering/RenderView.cpp:
    (WebCore::RenderView::pageNumberForBlockProgressionOffset):
    * rendering/RenderView.h:
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@167444 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    authored April 17, 2014
  21. [Win] Unreviewed 64-bit build fix.

    * WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Do not
    export 32-bit symbol in 64-bit build. 
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@167443 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    authored April 17, 2014
  22. [Win] A few final cleanups to the DataObject classes.

    https://bugs.webkit.org/show_bug.cgi?id=131784
    
    Reviewed by Anders Carlsson.
    
    
    Source/WebCore: 
    * platform/win/WCDataObject.cpp:
    (WebCore::WCDataObject::clearData): Use 'last()' method.
    
    Tools: 
    * DumpRenderTree/win/DRTDataObject.cpp:
    (DRTDataObject::clearData): Use 'last()' method.
    * DumpRenderTree/win/UIDelegate.cpp:
    (DRTUndoStack::pop): Use 'takeLast()' method.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@167442 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    authored April 17, 2014
  23. Fullscreen media controls are unusable in pagination mode

    https://bugs.webkit.org/show_bug.cgi?id=131705
    
    Reviewed by Darin Adler.
    
    Source/WebCore:
    When pagination mode is enabled, the full screen media will (depending on the width of the
    pagination columns) overflow its column, and hit testing will be clipped to the column. In extreme
    cases, where the column width < 0.5 * media element width, the media controls will be entirely
    unclickable.
    
    Rather than making the RenderFullScreen a child of the full screen element's parent's renderer,
    make it a child of the RenderView, putting it outside of the columns entirely. Always create and
    insert the fullscreenRenderer's placeholder, using it as the remembered insertion point for the
    fullscreen element's renderer when we exit full screen.
    
    Drive-by fix: don't wrap the full screen element's renderer in webkitWillEnterFullScreenForElement();
    it will just be re-wrapped in createRendererIfNeeded().
    
    * dom/Document.cpp:
    (WebCore::Document::webkitWillEnterFullScreenForElement): Don't wrap the full screen element's renderer.
    (WebCore::Document::setFullScreenRenderer): Call setPlaceholderStyle.
    * rendering/RenderFullScreen.cpp:
    (WebCore::RenderFullScreenPlaceholder::willBeDestroyed): Call clearPlaceholder.
    (WebCore::RenderFullScreen::wrapRenderer): Make fullscreenRenderer a child of the view().
    (WebCore::RenderFullScreen::unwrapRenderer): Return the children to the parent of the placeholder().
    (WebCore::RenderFullScreen::clearPlaceholder): Renamed from setPlaceholder().
    (WebCore::RenderFullScreen::ensurePlaceholder): Added.
    (WebCore::RenderFullScreen::setPlaceholderStyle): Renamed from createPlaceholder().
    (WebCore::RenderFullScreen::setPlaceholder): Deleted.
    (WebCore::RenderFullScreen::createPlaceholder): Deleted.
    * rendering/RenderFullScreen.h:
    
    LayoutTests:
    * fullscreen/full-screen-no-style-sharing-expected.txt: Rebaselined.
    * fullscreen/video-cursor-auto-hide.html: Corrected test to move cursor
        to the middle of the video element.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@167441 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    authored April 17, 2014
  24. [MSE] Multiple initialization segments with same codecs in tracks fai…

    …l validation.
    
    
    https://bugs.webkit.org/show_bug.cgi?id=131768
    
    Source/WebCore:
    Additional initialization segments added to the same SourceBuffer with the same
    codec values will fail validation. Update the validation check to add the correct
    codec information for the initial segment, and check against the correct codecs during
    the validation step.
    
    Additionally, after validation, if successful update the Audio, Video, and TextTracks
    for the SourceBuffer with the updated initialization segment information.
    
    Reviewed by Eric Carlson.
    
    Test: media/media-source/media-source-multiple-initialization-segments.html
    
    * Modules/mediasource/SourceBuffer.cpp:
    (WebCore::SourceBuffer::appendBufferTimerFired): m_source may have been cleared
        as a result of the append, so check it before using.
    (WebCore::SourceBuffer::sourceBufferPrivateDidEndStream): Call streamEndedWithError
        instead of endOfStream as the latter is safe to call within an update.
    (WebCore::SourceBuffer::sourceBufferPrivateDidReceiveInitializationSegment): Ditto.
        Update the track lists if validation succeeds.
    (WebCore::SourceBuffer::validateInitializationSegment): Switch the audio and video
        codec checks.
    
    Add the ability for Audio, Video, and InbandTextTracks to replace their private tracks:
    * html/track/AudioTrack.cpp:
    (WebCore::AudioTrack::AudioTrack): Call updateKindFromPrivate().
    (WebCore::AudioTrack::setPrivate):
    (WebCore::AudioTrack::updateKindFromPrivate): Split out from constructor.
    * html/track/AudioTrack.h:
    * html/track/InbandTextTrack.cpp:
    (WebCore::InbandTextTrack::InbandTextTrack): Call updateKindFromPrivate().
    (WebCore::InbandTextTrack::setPrivate):
    (WebCore::InbandTextTrack::setMode): Split up into setModeInternal().
    (WebCore::InbandTextTrack::setModeInternal): Broke out from setMode().
    (WebCore::InbandTextTrack::updateKindFromPrivate): Split out from constructor.
    * html/track/InbandTextTrack.h:
    * html/track/TextTrack.h:
    (WebCore::TextTrack::isInband): Added, returns false.
    * html/track/VideoTrack.cpp:
    (WebCore::VideoTrack::VideoTrack): Call updateKindFromPrivate().
    (WebCore::VideoTrack::setPrivate):
    (WebCore::VideoTrack::updateKindFromPrivate):  Split out from constructor.
    * html/track/VideoTrack.h:
    
    LayoutTests:
    Reviewed by Eric Carlson.
    
    * media/media-source/media-source-multiple-initialization-segments-expected.txt: Added.
    * media/media-source/media-source-multiple-initialization-segments.html: Added.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@167440 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    authored April 17, 2014
  25. [New Multicolumn] Column sets below spanners don't repaint properly.

    https://bugs.webkit.org/show_bug.cgi?id=131778
    
    Reviewed by Beth Dakin.
    
    
    Source/WebCore: 
    Added fast/repaint/spanner-with-margins.html.
    
    * rendering/RenderBox.cpp:
    (WebCore::RenderBox::computeRectForRepaint):
    Turn off some code that was running for in-flow RenderFlowThreads that made no sense.
    I'm not convinced the code is right for other types of RenderFlowThreads either,
    but will leave that to the named flow thread experts. :)
    
    LayoutTests: 
    * fast/repaint/spanner-with-margin-expected.txt: Added.
    * fast/repaint/spanner-with-margin.html: Added.
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@167439 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    authored April 17, 2014
  26. [GTK] [Gardening] Updates GTK test expectations

    Patch by Eduardo Lima Mitev <elima@igalia.com> on 2014-04-17
    
    * platform/gtk/TestExpectations:
      - Marked as flaky
        - fast/frames/frame-programmatic-noresize.html
        - fast/frames/frame-with-noresize-can-be-resized-after-removal-of-noresize.html
        - fast/frames/frame-with-noresize-can-be-resized-after-setting-noResize-to-false.html
      - Removed because are passing now
        - fast/dom/gc-dom-tree-lifetime.html
        - http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials.html
        - editing/editability/ignored-content.html
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@167438 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    authored April 17, 2014
  27. Catch up ruby and its tag omission rule changes in HTML5 CR Feb 2014

    https://bugs.webkit.org/show_bug.cgi?id=131175
    
    Patch by Koji Ishii <kojishi@gmail.com> on 2014-04-17
    Reviewed by Darin Adler.
    
    Source/WebCore:
    Tests: html5lib/resources/ruby.dat
           html5lib/resources/tests19.dat
    
    This patch makes WebKit HTML parser to match to the tag omission rules of HTML5 CR Feb 2014:
    http://www.w3.org/TR/2014/CR-html5-20140204/syntax.html#syntax-tag-omission
    with the support for two new elements (rb, rtc) which were also defined in the spec:
    http://www.w3.org/TR/2014/CR-html5-20140204/text-level-semantics.html#the-rb-element
    http://www.w3.org/TR/2014/CR-html5-20140204/text-level-semantics.html#the-rtc-element
    to better support use cases presented by W3C I18N WG:
    http://www.w3.org/TR/ruby-use-cases/
    
    * html/HTMLTagNames.in: rb and rtc added as HTMLElement interfaces.
    * html/parser/HTMLConstructionSite.cpp:
    (WebCore::hasImpliedEndTag): the spec says rb and rtc have implied end tags.
    * html/parser/HTMLTreeBuilder.cpp:
    (WebCore::HTMLTreeBuilder::processStartTagForInBody): rb and rtc added. rt excludes rtc from its implied end tags.
    
    LayoutTests:
    25 new test cases in 2 test files imported from pull requests to html5lib-tests,
    with run- and expected-files generated.
    All new tests pass with the changes included in this patch.
    
    * html5lib/generated/run-ruby-data-expected.txt: Added.
    * html5lib/generated/run-ruby-data.html: Added (generated by generate-test-wrappers.py)
    * html5lib/generated/run-ruby-write-expected.txt: Added.
    * html5lib/generated/run-ruby-write.html: Added (generated by generate-test-wrappers.py)
    * html5lib/resources/ruby.dat: Added from darobin/html5lib-tests#1
    * html5lib/resources/tests19.dat: Updated from html5lib/html5lib-tests#27
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@167437 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    authored April 17, 2014
  28. Try to fix EFL and GTK builds.

            * Source/cmake/OptionsEfl.cmake: Add INDEXED_DATABASE_IN_WORKERS.
            * Source/cmake/OptionsGTK.cmake: Ditto.
            * Source/cmakeconfig.h.cmake: Ditto.
    
            * Source/WebCore/workers/WorkerGlobalScope.idl: Touch file to make it rebuild,
            assuming that module dependencies aren't working right with CMake. Tweaked
            formatting quite a bit while I was in here.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@167436 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    authored April 17, 2014
  29. Blind attempt to fix Windows build after r166837

    <http://webkit.org/b/131246>
    
    Hoping to fix this build error:
    
        warning MSB8027: Two or more files with the name of GCLogging.cpp will produce outputs to the same location. This can lead to an incorrect build result.  The files involved are ..\heap\GCLogging.cpp, ..\heap\GCLogging.cpp.
    
    * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Fix copy-paste
    boo-boo by changing the GCLogging.cpp ClCompile entry to a
    GCLogging.h ClInclude entry.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@167435 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    authored April 17, 2014
  30. Don't skip inspector/dom/content-flow-list.html and inspector/dom/con…

    …tent-flow-content-removal.html.
    
    First, they no longer crash/assert. They fail most of the time, but that's tracked as bug 129817.
    
    Second, skipping was ineffective anyway, because we had a preceding [ Pass Failure ]
    entry for the same files.
    
    * TestExpectations:
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@167434 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    authored April 17, 2014
  31. AI for GetLocal should match the DFG backend, and in this case, the b…

    …est way to do that is to get rid of the "exit if empty prediction" thing since it's a vestige of a time long gone
    
    
    https://bugs.webkit.org/show_bug.cgi?id=131764
    
    Reviewed by Geoffrey Garen.
            
    The attached test case can be made to not crash by deleting old code. It used to be
    the case that the DFG needed empty prediction guards, for shady reasons. We fixed that
    long ago. At this point, these guards just make life difficult. So get rid of them.
    
    * dfg/DFGAbstractInterpreterInlines.h:
    (JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
    * dfg/DFGSpeculativeJIT32_64.cpp:
    (JSC::DFG::SpeculativeJIT::compile):
    * dfg/DFGSpeculativeJIT64.cpp:
    (JSC::DFG::SpeculativeJIT::compile):
    * tests/stress/bug-131764.js: Added.
    (test1):
    (test2):
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@167433 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    authored April 17, 2014
  32. Use HashMap<unique_ptr> and Vector<unique_ptr> instead of deprecatedD…

    …eleteAllValues
    
    
    https://bugs.webkit.org/show_bug.cgi?id=73757
    
    Reviewed by Brent Fulgham.
    
    * wtf/Vector.h:
    (WTF::deprecatedDeleteAllValues): Deleted.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@167432 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    authored April 17, 2014
  33. Remove use of deprecatedDeleteAllValues in NPRemoteObjectMap::pluginD…

    …estroyed
    
    
    https://bugs.webkit.org/show_bug.cgi?id=122496
    
    Reviewed by Brent Fulgham.
    
    * Shared/Plugins/NPRemoteObjectMap.cpp:
    (WebKit::NPRemoteObjectMap::pluginDestroyed): Use new-style code and write the
    deprecatedDeleteAllValues function out using a loop. Might be nice to return here
    and use unique_ptr instead some day, but I tried that before and got it wrong, so
    lets do that another time.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@167431 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    authored April 17, 2014
  34. [Win] cygwin to keep installing curl 7.33.0-1 and subversion 1.7.14-1

    https://bugs.webkit.org/show_bug.cgi?id=131365
    
    Reviewed by Brent Fulgham.
    
    The cygwin installer is now downloading the wanted versions for
    the local installation given to the setup wizard.
    
    * CygwinDownloader/cygwin-downloader.py:
    * CygwinDownloader/cygwin-downloader.zip:
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@167430 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    authored April 17, 2014
  35. [New Multicolumn] REGRESSION: Column set styles don't update when zoo…

    …ming etc.
    
    
    https://bugs.webkit.org/show_bug.cgi?id=131777
    
    Reviewed by Enrica Casucci.
    
    
    Source/WebCore: 
    Added fast/multicol/zoom-test.html
    
    * rendering/RenderBlockFlow.cpp:
    (WebCore::RenderBlockFlow::styleDidChange):
    Put back in the code that propagates new styles to the flow thread and column sets
    when styles change. This propagation was removed when the column span code landed.
    This patch puts it back in but qualifies the types of objects that get styles
    propagated to avoid accidentally propagating the wrong style to column spans.
    
    LayoutTests: 
    * fast/multicol/zoom-test-expected.html: Added.
    * fast/multicol/zoom-test.html: Added.
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@167429 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    authored April 17, 2014
Something went wrong with that request. Please try again.