Skip to content
Branch: master
Find file History
antti@apple.com
antti@apple.com Skip matched declarations cache only for length resolution affecting …
…font properties

https://bugs.webkit.org/show_bug.cgi?id=204098

Reviewed by Zalan Bujtas.

* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::equalForLengthResolution):

Put this next to the length resolution function, hopefully helping to keep them in sync.

* css/CSSPrimitiveValue.h:
* css/StyleResolver.cpp:
(WebCore::StyleResolver::applyMatchedProperties):

Replace test for font declaration change with a narrower test that only looks for those properties that affect length resolution.

* style/MatchedDeclarationsCache.cpp:
(WebCore::Style::MatchedDeclarationsCache::Entry::isUsableAfterHighPriorityProperties const):

Factor into function.

* style/MatchedDeclarationsCache.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@252370 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Latest commit ea57b5f Nov 12, 2019
Permalink
Type Name Latest commit message Commit time
..
Failed to load latest commit information.
parser Revert "[css-lists] Implement list-style-type: <string>" Nov 11, 2019
typedom Unreviewed. Restabilize non-unified build. Oct 8, 2019
BasicShapeFunctions.cpp Add TextStream dumping for BasicShape types Oct 18, 2019
BasicShapeFunctions.h Clean up / Modernize the CSS Parser May 23, 2016
CSSAspectRatioValue.cpp Eliminate unnecessary String temporaries by using StringConcatenateNu… Feb 9, 2019
CSSAspectRatioValue.h Add final keyword to final classes and overriden methods in WebCore/css Aug 28, 2016
CSSBasicShapes.cpp CSS ellipse() doesn't accept single <shape-radius> Oct 3, 2019
CSSBasicShapes.h Modernize SVGRenderStyleDefs.h May 28, 2018
CSSBorderImage.cpp Clean up CSS code May 18, 2016
CSSBorderImage.h Clean up CSS code May 18, 2016
CSSBorderImageSliceValue.cpp Clean up CSS code May 18, 2016
CSSBorderImageSliceValue.h Move CSS classes from ExceptionCode to Exception Oct 17, 2016
CSSCalculationValue.cpp Add support for the Q unit Oct 28, 2019
CSSCalculationValue.h Properly determine if css custom property values are computationally … Oct 6, 2018
CSSCanvasValue.cpp Change some image-related CSSValue subclasses to use references Oct 23, 2019
CSSCanvasValue.h Change some image-related CSSValue subclasses to use references Oct 23, 2019
CSSComputedStyleDeclaration.cpp Revert "[css-lists] Implement list-style-type: <string>" Nov 11, 2019
CSSComputedStyleDeclaration.h Streamline some string code, focusing on functions that were using su… Jun 29, 2019
CSSContentDistributionValue.cpp [css-align] 'overflow' keyword must precede the self-position and con… Jan 22, 2018
CSSContentDistributionValue.h Remove excessive include directives from WebCore/css Jun 20, 2017
CSSCrossfadeValue.cpp Use makeString and multi-argument StringBuilder::append instead of le… Aug 22, 2019
CSSCrossfadeValue.h Use WTF::Function instead of std::function in more places in WebCore/ Jun 19, 2017
CSSCursorImageValue.cpp Finish cleanup of String::number for floating point Jun 3, 2019
CSSCursorImageValue.h CSS subresource loads should not be observable from resource timing i… Nov 29, 2018
CSSCustomIdentValue.cpp Rename AtomicString to AtomString Jun 17, 2019
CSSCustomIdentValue.h Rename AtomicString to AtomString Jun 17, 2019
CSSCustomPropertyValue.cpp CSS Painting API should allow image values in inputProperties Dec 4, 2018
CSSCustomPropertyValue.h Rename AtomicString to AtomString Jun 17, 2019
CSSDefaultStyleSheets.cpp Add fullscreen style quirk for reddit.com Oct 31, 2019
CSSDefaultStyleSheets.h Enable the datalist element by default on iOS and macOS Oct 18, 2018
CSSFilterImageValue.cpp Style::Builder should not depend on StyleResolver Nov 1, 2019
CSSFilterImageValue.h Style::Builder should not depend on StyleResolver Nov 1, 2019
CSSFontFace.cpp Rename StyleBuilder to Style::BuilderGenerated Oct 31, 2019
CSSFontFace.h [JSC] Thread JSGlobalObject* instead of ExecState* Oct 22, 2019
CSSFontFaceRule.cpp Use makeString and multi-argument StringBuilder::append instead of le… Aug 22, 2019
CSSFontFaceRule.h Source/WebCore: Aug 22, 2016
CSSFontFaceRule.idl Add support for [NoInterfaceObject] Web IDL extended attribute May 9, 2013
CSSFontFaceSet.cpp Rename StyleBuilder to Style::BuilderGenerated Oct 31, 2019
CSSFontFaceSet.h Rename AtomicString to AtomString Jun 17, 2019
CSSFontFaceSource.cpp [Cocoa] Move ui-serif, ui-monospaced, and ui-rounded out from behind SPI Oct 22, 2019
CSSFontFaceSource.h Rename AtomicString to AtomString Jun 17, 2019
CSSFontFaceSrcValue.cpp Use makeString and multi-argument StringBuilder::append instead of le… Aug 22, 2019
CSSFontFaceSrcValue.h CSS subresource loads should not be observable from resource timing i… Nov 29, 2018
CSSFontFamily.h Use #pragma once in WebCore Nov 13, 2016
CSSFontFeatureValue.cpp Omit default value when serializing font-feature-settings Apr 20, 2018
CSSFontFeatureValue.h Remove excessive headers from WebCore/{bindings,css,dom} Jun 23, 2017
CSSFontSelector.cpp Integrate resize event with HTML5 event loop Oct 31, 2019
CSSFontSelector.h document.fonts.ready is resolved too quickly Aug 29, 2019
CSSFontStyleRangeValue.cpp Cleanup some StringBuilder use Jul 4, 2017
CSSFontStyleRangeValue.h Remove excessive include directives from WebCore/css Jun 20, 2017
CSSFontStyleValue.cpp Crash beneath CSSValue::equals @ csas.cz Jan 3, 2018
CSSFontStyleValue.h Addressing post-review comments after r219173. Aug 10, 2017
CSSFontValue.cpp Remove excessive includes from WebCore/css sources Jun 28, 2017
CSSFontValue.h font-style needs a new CSSValue to make CSSRule.cssText work correctly Mar 24, 2017
CSSFontVariationValue.cpp Specify fixed precision explicitly to prepare to change String::numbe… Mar 11, 2019
CSSFontVariationValue.h Put variation fonts work behind a compile-time flag Oct 6, 2016
CSSFunctionValue.cpp [CSS Parser] Make CSSFunctionValue derive from CSSValueList Dec 14, 2016
CSSFunctionValue.h [CSS Parser] Make CSSFunctionValue derive from CSSValueList Dec 14, 2016
CSSGradientValue.cpp Style::Builder should not depend on StyleResolver Nov 1, 2019
CSSGradientValue.h Style::Builder should not depend on StyleResolver Nov 1, 2019
CSSGridAutoRepeatValue.cpp [css-grid] Update grid when changing auto repeat type May 14, 2019
CSSGridAutoRepeatValue.h [css-grid] Update grid when changing auto repeat type May 14, 2019
CSSGridIntegerRepeatValue.cpp [css-grid] Preserve repeat() notation when serializing declared values May 27, 2019
CSSGridIntegerRepeatValue.h [css-grid] Preserve repeat() notation when serializing declared values May 27, 2019
CSSGridLineNamesValue.cpp [css-grid] Remove compilation flag ENABLE_CSS_GRID_LAYOUT Feb 20, 2017
CSSGridLineNamesValue.h [css-grid] Remove compilation flag ENABLE_CSS_GRID_LAYOUT Feb 20, 2017
CSSGridTemplateAreasValue.cpp [css-grid] Remove compilation flag ENABLE_CSS_GRID_LAYOUT Feb 20, 2017
CSSGridTemplateAreasValue.h Use "= default" to denote default constructor or destructor Oct 19, 2017
CSSGroupingRule.cpp [WTF] Add makeUnique<T>, which ensures T is fast-allocated, makeUniqu… Aug 19, 2019
CSSGroupingRule.h Move CSS classes from ExceptionCode to Exception Oct 17, 2016
CSSHelper.h Use #pragma once in WebCore Nov 13, 2016
CSSImageGeneratorValue.cpp Change some image-related CSSValue subclasses to use references Oct 23, 2019
CSSImageGeneratorValue.h Web Inspector: Show all elements currently using a given CSS Canvas Jul 7, 2017
CSSImageSetValue.cpp CSS subresource loads should not be observable from resource timing i… Nov 29, 2018
CSSImageSetValue.h CSS subresource loads should not be observable from resource timing i… Nov 29, 2018
CSSImageValue.cpp CSS subresource loads should not be observable from resource timing i… Nov 29, 2018
CSSImageValue.h Rename AtomicString to AtomString Jun 17, 2019
CSSImportRule.cpp Remove excessive includes from WebCore/css sources Jun 28, 2017
CSSImportRule.h Source/WebCore: Aug 22, 2016
CSSImportRule.idl Drop [TreatReturnedNullStringAs=Null] WebKit-specific IDL attribute Feb 25, 2016
CSSInheritedValue.cpp [WTF] Add user-defined literal for ASCIILiteral Jun 23, 2018
CSSInheritedValue.h Remove the workaround for friend class LazyNeverDestroyed<X> statemen… Sep 13, 2018
CSSInitialValue.cpp [WTF] Add user-defined literal for ASCIILiteral Jun 23, 2018
CSSInitialValue.h Remove the workaround for friend class LazyNeverDestroyed<X> statemen… Sep 13, 2018
CSSKeyframeRule.cpp Can't change @font-face descriptors from fontFaceRule.style.setProper… Oct 28, 2019
CSSKeyframeRule.h Remove excessive include directives from WebCore/css Jun 20, 2017
CSSKeyframeRule.idl CSSStyleRule.style / CSSPageRule.style / CSSKeyframeRule.style should… Jun 8, 2017
CSSKeyframesRule.cpp Can't change @font-face descriptors from fontFaceRule.style.setProper… Oct 28, 2019
CSSKeyframesRule.h Rename AtomicString to AtomString Jun 17, 2019
CSSKeyframesRule.idl Align CSSKeyframesRule with the specification Jul 26, 2016
CSSLineBoxContainValue.cpp Convert LineBoxContain to use an OptionSet<> Oct 13, 2019
CSSLineBoxContainValue.h Convert LineBoxContain to use an OptionSet<> Oct 13, 2019
CSSMarkup.cpp Rename StringBuilder::append(UChar32) to StringBuilder::appendCharact… Aug 14, 2019
CSSMarkup.h REGRESSION(r209495): materiauxlaverdure.com fails to load Jun 17, 2017
CSSMediaRule.cpp Use makeString and multi-argument StringBuilder::append instead of le… Aug 22, 2019
CSSMediaRule.h Move CSS classes from ExceptionCode to Exception Oct 17, 2016
CSSMediaRule.idl Move CSS classes from ExceptionCode to Exception Oct 17, 2016
CSSNamedImageValue.cpp Change some image-related CSSValue subclasses to use references Oct 23, 2019
CSSNamedImageValue.h Change some image-related CSSValue subclasses to use references Oct 23, 2019
CSSNamespaceRule.cpp Use makeString and multi-argument StringBuilder::append instead of le… Aug 22, 2019
CSSNamespaceRule.h Rename AtomicString to AtomString Jun 17, 2019
CSSNamespaceRule.idl [CSS Parser] Remove the old CSS Parser Dec 10, 2016
CSSPageRule.cpp Use makeString and multi-argument StringBuilder::append instead of le… Aug 22, 2019
CSSPageRule.h Source/WebCore: Aug 22, 2016
CSSPageRule.idl CSSStyleRule.style / CSSPageRule.style / CSSKeyframeRule.style should… Jun 8, 2017
CSSPaintCallback.h CSS Painting API code cleanup Dec 7, 2018
CSSPaintCallback.idl CSS Painting API should pass 'this' correctly to paint callback, and … Nov 29, 2018
CSSPaintImageValue.cpp CS Painting API should support multiple worklets. Dec 11, 2018
CSSPaintImageValue.h CSS Painting API should pass 'this' correctly to paint callback, and … Nov 29, 2018
CSSPaintSize.h CSS Painting API should pass size, arguments and input properties to … Nov 8, 2018
CSSPaintSize.idl CSS Painting API should pass size, arguments and input properties to … Nov 8, 2018
CSSPendingSubstitutionValue.cpp [CSS Parser] Get all the properties turned on Oct 18, 2016
CSSPendingSubstitutionValue.h [CSS Parser] Get all the properties turned on Oct 18, 2016
CSSPrimitiveValue.cpp Skip matched declarations cache only for length resolution affecting … Nov 12, 2019
CSSPrimitiveValue.h Skip matched declarations cache only for length resolution affecting … Nov 12, 2019
CSSPrimitiveValueMappings.h Revert "[css-lists] Implement list-style-type: <string>" Nov 11, 2019
CSSProperties.json Revert "[css-lists] Implement list-style-type: <string>" Nov 11, 2019
CSSProperty.cpp [css-logical] Implement flow-relative inset properties Jan 23, 2019
CSSProperty.h Web Inspector: generate CSSKeywordCompletions from backend values Sep 17, 2018
CSSPropertySourceData.cpp Use makeString and multi-argument StringBuilder::append instead of le… Aug 22, 2019
CSSPropertySourceData.h Can't change @font-face descriptors from fontFaceRule.style.setProper… Oct 28, 2019
CSSReflectValue.cpp Remove excessive includes from WebCore/css sources Jun 28, 2017
CSSReflectValue.h Remove excessive include directives from WebCore/css Jun 20, 2017
CSSRegisteredCustomProperty.cpp CSS Custom Properties API Should Support syntax="*" and "<length>", a… Nov 1, 2018
CSSRegisteredCustomProperty.h Mark more heap-allocated classes as fast allocated Feb 8, 2019
CSSRevertValue.cpp