Find file History
jiewen_tan@apple.com
jiewen_tan@apple.com Replace CommonRandom SPI with API
https://bugs.webkit.org/show_bug.cgi?id=191178
<rdar://problem/45722391>

Reviewed by Brent Fulgham.

Source/bmalloc:

* bmalloc/CryptoRandom.cpp:
(bmalloc::ARC4RandomNumberGenerator::stir):

Source/WebCore:

The API is available since macOS 10.10 and iOS 10, and therefore it is safe to replace
all SPI usages with API.

No change of behaviors.

* crypto/CommonCryptoUtilities.h:
* crypto/mac/CryptoKeyMac.cpp:
(WebCore::CryptoKey::randomData):
* crypto/mac/SerializedCryptoKeyWrapMac.mm:
(WebCore::createAndStoreMasterKey):
(WebCore::wrapSerializedCryptoKey):
* page/Crypto.cpp:
(WebCore::Crypto::getRandomValues):

Source/WTF:

* WTF.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/RandomDevice.cpp:
(WTF::RandomDevice::cryptographicallyRandomValues):
* wtf/spi/darwin/CommonCryptoSPI.h: Removed.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@237721 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Latest commit 4fb6a96 Nov 1, 2018
Permalink
..
Failed to load latest commit information.
darwin Add BPLATFORM(IOS_FAMILY) Oct 24, 2018
Algorithm.h Cleanup: inline constexpr is redundant as constexpr implies inline Oct 25, 2018
AllIsoHeaps.cpp bmalloc StaticMutex's constructor should be constexpr Apr 5, 2018
AllIsoHeaps.h bmalloc StaticMutex's constructor should be constexpr Apr 5, 2018
AllIsoHeapsInlines.h bmalloc should support strictly type-segregated isolated heaps Nov 7, 2017
Allocator.cpp Correctly detect string overflow when using the 'Function' constructor. Oct 30, 2018
Allocator.h Correctly detect string overflow when using the 'Function' constructor. Oct 30, 2018
AvailableMemory.cpp Add BPLATFORM(IOS_FAMILY) Oct 24, 2018
AvailableMemory.h Add BPLATFORM(IOS_FAMILY) Oct 24, 2018
BAssert.h Rename UNUSED to BUNUSED Apr 10, 2018
BCompiler.h Rename WTF_COMPILER_GCC_OR_CLANG to WTF_COMPILER_GCC_COMPATIBLE Sep 25, 2018
BExport.h Improve use of ExportMacros Jan 15, 2018
BInline.h Primitive auxiliaries and JSValue auxiliaries should have separate gi… Aug 7, 2017
BMalloced.h bmalloc should support strictly type-segregated isolated heaps Nov 7, 2017
BPlatform.h Add BPLATFORM(IOS_FAMILY) Oct 24, 2018
Bits.h Cleanup: inline constexpr is redundant as constexpr implies inline Oct 25, 2018
BulkDecommit.h bmalloc should do partial scavenges more frequently Apr 10, 2018
BumpAllocator.h bmalloc: segregate small and large objects again, and allocate more o… Apr 4, 2016
BumpRange.h bmalloc: cleaned up fast path vs slow path Sep 30, 2014
Cache.cpp Enable gigacage on iOS Oct 12, 2017
Cache.h Correctly detect string overflow when using the 'Function' constructor. Oct 30, 2018
Chunk.h bmalloc: Small and large objects should share memory Jun 6, 2017
CryptoRandom.cpp Replace CommonRandom SPI with API Nov 2, 2018
CryptoRandom.h bmalloc should support strictly type-segregated isolated heaps Nov 7, 2017
Deallocator.cpp [JSC] Remove "using namespace std;" from JSC, bmalloc, WTF May 7, 2018
Deallocator.h bmalloc should do partial scavenges more frequently Apr 10, 2018
DebugHeap.cpp Correctly detect string overflow when using the 'Function' constructor. Oct 30, 2018
DebugHeap.h Correctly detect string overflow when using the 'Function' constructor. Oct 30, 2018
DeferredDecommit.h bmalloc should support strictly type-segregated isolated heaps Nov 7, 2017
DeferredDecommitInlines.h bmalloc should support strictly type-segregated isolated heaps Nov 7, 2017
DeferredTrigger.h bmalloc should support strictly type-segregated isolated heaps Nov 7, 2017
DeferredTriggerInlines.h
EligibilityResult.h bmalloc should support strictly type-segregated isolated heaps Nov 7, 2017
EligibilityResultInlines.h
Environment.cpp Wasm: Any function argument of type Void should be a validation error Jun 26, 2018
Environment.h bmalloc StaticMutex's constructor should be constexpr Apr 5, 2018
FixedVector.h bmalloc should support strictly type-segregated isolated heaps Nov 7, 2017
FreeList.cpp
FreeList.h bmalloc should support strictly type-segregated isolated heaps Nov 7, 2017
FreeListInlines.h bmalloc should support strictly type-segregated isolated heaps Nov 7, 2017
Gigacage.cpp Use alignas instead of compiler-specific attributes Apr 8, 2018
Gigacage.h Add BPLATFORM(IOS_FAMILY) Oct 24, 2018
Heap.cpp bmalloc should do partial scavenges more frequently Apr 10, 2018
Heap.h bmalloc should do partial scavenges more frequently Apr 10, 2018
HeapKind.cpp Enable gigacage on iOS Oct 12, 2017
HeapKind.h Strings should not be allocated in a gigacage May 4, 2018
IsoAllocator.h bmalloc should support strictly type-segregated isolated heaps Nov 7, 2017
IsoAllocatorInlines.h bmalloc should support strictly type-segregated isolated heaps Nov 7, 2017
IsoConfig.h bmalloc should support strictly type-segregated isolated heaps Nov 7, 2017
IsoDeallocator.h bmalloc StaticMutex's constructor should be constexpr Apr 5, 2018
IsoDeallocatorInlines.h bmalloc should support strictly type-segregated isolated heaps Nov 7, 2017
IsoDirectory.h bmalloc should do partial scavenges more frequently Apr 10, 2018
IsoDirectoryInlines.h bmalloc should do partial scavenges more frequently Apr 10, 2018
IsoDirectoryPage.h bmalloc should support strictly type-segregated isolated heaps Nov 7, 2017
IsoDirectoryPageInlines.h Unreviewed, rolling out r237063. Oct 12, 2018
IsoHeap.h bmalloc StaticMutex's constructor should be constexpr Apr 5, 2018
IsoHeapImpl.cpp IsoHeapImpl not IsoHeapImplBase should add itself to AllIsoHeaps Apr 6, 2018
IsoHeapImpl.h bmalloc should do partial scavenges more frequently Apr 10, 2018
IsoHeapImplInlines.h IsoHeapImpl::scavenge* needs to grab the lock Apr 11, 2018
IsoHeapInlines.h bmalloc should support strictly type-segregated isolated heaps Nov 7, 2017
IsoPage.cpp Replace tryLargeMemalignVirtual with tryLargeZeroedMemalignVirtual an… Feb 1, 2018
IsoPage.h Isolated Heaps caused an increase in reported leaks on the bots Nov 24, 2017
IsoPageInlines.h Unreviewed, rolling out r237063. Oct 12, 2018
IsoPageTrigger.h bmalloc should support strictly type-segregated isolated heaps Nov 7, 2017
IsoTLS.cpp bmalloc: Coverity scan issues Aug 16, 2018
IsoTLS.h Put the DOM in IsoHeaps Mar 17, 2018
IsoTLSAllocatorEntry.h bmalloc should support strictly type-segregated isolated heaps Nov 7, 2017
IsoTLSAllocatorEntryInlines.h bmalloc should support strictly type-segregated isolated heaps Nov 7, 2017
IsoTLSDeallocatorEntry.h bmalloc StaticMutex's constructor should be constexpr Apr 5, 2018
IsoTLSDeallocatorEntryInlines.h bmalloc StaticMutex's constructor should be constexpr Apr 5, 2018
IsoTLSEntry.cpp bmalloc should support strictly type-segregated isolated heaps Nov 7, 2017
IsoTLSEntry.h bmalloc should support strictly type-segregated isolated heaps Nov 7, 2017
IsoTLSEntryInlines.h bmalloc should support strictly type-segregated isolated heaps Nov 7, 2017
IsoTLSInlines.h bmalloc StaticMutex's constructor should be constexpr Apr 5, 2018
IsoTLSLayout.cpp bmalloc StaticMutex's constructor should be constexpr Apr 5, 2018
IsoTLSLayout.h bmalloc StaticMutex's constructor should be constexpr Apr 5, 2018
LargeMap.cpp bmalloc should do partial scavenges more frequently Apr 10, 2018
LargeMap.h bmalloc should do partial scavenges more frequently Apr 10, 2018
LargeRange.h bmalloc should do partial scavenges more frequently Apr 10, 2018
LineMetadata.h bmalloc: segregate small and large objects again, and allocate more o… Apr 4, 2016
List.h Remove code for compilers that did not support NSDMI for aggregates Apr 20, 2018
Logging.cpp Add BPLATFORM(IOS_FAMILY) Oct 24, 2018
Logging.h bmalloc should support strictly type-segregated isolated heaps Nov 7, 2017
Map.h Primitive auxiliaries and JSValue auxiliaries should have separate gi… Aug 7, 2017
Mutex.cpp bmalloc StaticMutex's constructor should be constexpr Apr 5, 2018
Mutex.h Use WordLock instead of std::mutex for Threading Apr 30, 2018
Object.h Assertion failure in bmalloc::vmRevokePermissions(void*, unsigned long). Apr 28, 2016
ObjectType.cpp bmalloc should do partial scavenges more frequently Apr 10, 2018
ObjectType.h Bmalloc and GC should put auxiliaries (butterflies, typed array backi… Aug 2, 2017
PerHeapKind.h bmalloc should support strictly type-segregated isolated heaps Nov 7, 2017
PerProcess.cpp Include stdio.h before using stderr Apr 23, 2018
PerProcess.h
PerThread.cpp Disable IsoHeaps when Gigacage is off Jul 12, 2018
PerThread.h Disable IsoHeaps when Gigacage is off Jul 12, 2018
PhysicalPageMap.h bmalloc should compute its own estimate of its footprint Apr 2, 2018
ProcessCheck.h Wasm: Any function argument of type Void should be a validation error Jun 26, 2018
ProcessCheck.mm Allow for suffixes to com.apple.WebKit.WebContent Sep 25, 2018
Range.h Unreviewed, rolling in r197174. Mar 4, 2016
Scavenger.cpp https://hackernoon.com/ uses lots of layer backing store Jun 27, 2018
Scavenger.h bmalloc: Fix 'noreturn' warnings when compiling with -std=gnu++17 Jun 7, 2018
ScopeExit.h Unreviewed, build fix for GCC ports Aug 31, 2016
Sizes.h Cleanup: inline constexpr is redundant as constexpr implies inline Oct 25, 2018
SmallLine.h bmalloc should do partial scavenges more frequently Apr 10, 2018
SmallPage.h bmalloc should do partial scavenges more frequently Apr 10, 2018
Syscall.h bmalloc: Don't ASSERT that all syscalls succeed Oct 12, 2015
VMAllocate.h Add BPLATFORM(IOS_FAMILY) Oct 24, 2018
VMHeap.cpp bmalloc StaticMutex's constructor should be constexpr Apr 5, 2018
VMHeap.h bmalloc StaticMutex's constructor should be constexpr Apr 5, 2018
Vector.h Unreviewed, roll out r228306 (custom memcpy/memset) because the bots … Feb 16, 2018
Zone.cpp bmalloc StaticMutex's constructor should be constexpr Apr 5, 2018
Zone.h bmalloc StaticMutex's constructor should be constexpr Apr 5, 2018
bmalloc.cpp JSC should put bmalloc's scavenger into mini mode May 29, 2018
bmalloc.h
mbmalloc.cpp Bmalloc and GC should put auxiliaries (butterflies, typed array backi… Aug 2, 2017