New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an export macro #32

Closed
donny-dont opened this Issue Oct 15, 2018 · 3 comments

Comments

2 participants
@donny-dont
Copy link
Contributor

donny-dont commented Oct 15, 2018

Currently libwpe just uses __attribute__((visibility("default"))) for exports. This doesn't work on all platforms such as windows.

@donny-dont

This comment has been minimized.

Copy link
Contributor

donny-dont commented Oct 15, 2018

@masali-hp should be hitting this issue as well with https://github.com/masali-hp/WPEBackend-rdk

@aperezdc

This comment has been minimized.

Copy link
Contributor

aperezdc commented Oct 17, 2018

The visibility(…) attribute is supported by GCC/Clang but not MSVC, which I suppose is a must for Windows support. Which means that @donny-dont is right and currently it's not possible to build on Windows with MSVC.

I see that one of the commits in the masali-hp/WPEBackend-rdk repository uses this:

#ifdef _MSC_VER
__declspec(dllexport)
#else
__attribute__((visibility("default")))
#endif

We could turn this into a LIBWPE_EXPORT macro in one of the headers, and use that to export the symbols. My experience with Windows development is limited, so if somebody with more knowledge can confirm whether this would be enough, that would be great (thanks in advance!).

@aperezdc

This comment has been minimized.

Copy link
Contributor

aperezdc commented Nov 4, 2018

This was implemented in #33 by @donny-dont (thanks!), so let's close it.

@aperezdc aperezdc closed this Nov 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment