New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark client struct parameters as const in client setter functions #29

Merged
merged 1 commit into from Nov 5, 2018

Conversation

2 participants
@aperezdc
Copy link
Contributor

aperezdc commented Oct 4, 2018

The client structs are used vtables, which in shouldn't change, so the parameters to the client setter functions can be marked const.


This is in the same vein as Igalia/WPEBackend-fdo#24

@aperezdc aperezdc requested a review from zdobersek Oct 4, 2018

@aperezdc aperezdc changed the title Mark client struct parameters as const in _create() functions Mark client struct parameters as const in client setter functions Oct 4, 2018

@aperezdc aperezdc requested a review from magomez Oct 4, 2018

@aperezdc

This comment has been minimized.

Copy link
Contributor

aperezdc commented Oct 30, 2018

Ping reviewers 🔍

@aperezdc aperezdc added this to the Version 1.0.1 milestone Nov 4, 2018

@zdobersek zdobersek merged commit b6753c5 into WebPlatformForEmbedded:master Nov 5, 2018

@aperezdc aperezdc deleted the aperezdc:constify-clients branch Nov 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment