New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add export macro to support __declspec #33

Merged
merged 1 commit into from Oct 30, 2018

Conversation

2 participants
@donny-dont
Copy link
Contributor

donny-dont commented Oct 26, 2018

This replaces instances of __attribute__((visibility("default"))) with WPE_EXPORT in order to support platforms with __declspec such as Windows.

@donny-dont

This comment has been minimized.

Copy link
Contributor

donny-dont commented Oct 26, 2018

@aperezdc this fixes #32

@aperezdc
Copy link
Contributor

aperezdc left a comment

This looks just fine to me, thanks for sending it! I'll wait until tomorrow just in case @zdobersek may want to comment something before merging. Oh, and by the way, this looks much better than the naïve version I had suggested in #32 💪

@aperezdc aperezdc requested a review from zdobersek Oct 29, 2018

@aperezdc aperezdc merged commit c715991 into WebPlatformForEmbedded:master Oct 30, 2018

@aperezdc

This comment has been minimized.

Copy link
Contributor

aperezdc commented Oct 30, 2018

Žan confirmed on IRC that this PR is good to merge. Thanks @donny-dont!

@aperezdc aperezdc referenced this pull request Nov 4, 2018

Closed

Use an export macro #32

@aperezdc aperezdc added this to the Version 1.0.1 milestone Nov 4, 2018

@aperezdc aperezdc added the enhancement label Nov 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment