New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including wpe-egl.h should include also wpe.h #34

Merged
merged 1 commit into from Nov 3, 2018

Conversation

2 participants
@aperezdc
Copy link
Contributor

aperezdc commented Nov 2, 2018

This is needed to ensure that all the other needed definitions are included. One should not need to have to include both manually, even less knowing that wpe.h has to be included before wpe-egl.h.

This is particularly important now that we have the definition for WPE_EXPORT and wpe.h takes care of including the header necessary to bring its definition into scope.

Including wpe-egl.h should include also wpe.h
This is needed to ensure that all the other needed definitions are
included. One should not need to have to include both manually, even
less knowing that wpe.h has to be included before wpe-egl.h

This is particularly important now that we have the definition for
WPE_EXPORT and wpe.h takes care of including the header necessary
to bring its definition into scope.

@aperezdc aperezdc requested a review from zdobersek Nov 2, 2018

@zdobersek zdobersek merged commit 4785194 into WebPlatformForEmbedded:master Nov 3, 2018

@aperezdc aperezdc added this to the Version 1.0.1 milestone Nov 4, 2018

@aperezdc aperezdc deleted the aperezdc:fix-wpe-egl-include branch Nov 4, 2018

aperezdc added a commit to Igalia/WPEBackend-fdo that referenced this pull request Nov 4, 2018

Remove unneeded inclusion of the <wpe.h> header
The <wpe-egl.h> inclusion should take care itself of bringing in any
other headers it may need. Indeed, including <wpe.h> is not needed
after WebPlatformForEmbedded/libwpe#34 has been merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment