New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add view state API to view backend interface #36

Merged
merged 1 commit into from Nov 23, 2018

Conversation

3 participants
@carlosgcampos
Copy link
Contributor

carlosgcampos commented Nov 22, 2018

It allows to set and get the view state and the client interface
contains a new vfunc to notify about view state changes.

@carlosgcampos carlosgcampos requested review from zdobersek and aperezdc Nov 22, 2018

@aperezdc
Copy link
Contributor

aperezdc left a comment

Thanks a lot for sending the PR! 🌠

Changes LGTM; I have just a doubt and a small comment that you might want to take into account (though for me it is not something so important as to prevent merging the PR).

Show resolved Hide resolved src/view-backend.c Outdated
Show resolved Hide resolved src/view-backend.c Outdated
Show resolved Hide resolved src/view-backend.c Outdated

@carlosgcampos carlosgcampos force-pushed the cgarcia/view-state branch from 9338a94 to a6bb6b6 Nov 22, 2018

Show resolved Hide resolved include/wpe/view-backend.h Outdated

@carlosgcampos carlosgcampos force-pushed the cgarcia/view-state branch from a6bb6b6 to 91d019e Nov 23, 2018

Add view state API to view backend interface
It allows to set and get the view state and the client interface
contains a new vfunc to notify about view state changes.

@carlosgcampos carlosgcampos force-pushed the cgarcia/view-state branch from 91d019e to f9e670a Nov 23, 2018

@zdobersek zdobersek merged commit 55cd894 into master Nov 23, 2018

@carlosgcampos carlosgcampos deleted the cgarcia/view-state branch Nov 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment