New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename version API to stop using the word backend #38

Merged
merged 1 commit into from Nov 30, 2018

Conversation

6 participants
@carlosgcampos
Copy link
Contributor

carlosgcampos commented Nov 27, 2018

The library was renamed, but version API still includes backend word.
Deprecate the old API and add new one using using just WPE.

Rename version API to stop using the word backend
The library was renamed, but version API still includes backend word.
Deprecate the old API and add new one using using just WPE.

@carlosgcampos carlosgcampos requested review from aperezdc and zdobersek Nov 27, 2018

@aperezdc aperezdc added this to the Version 1.0.1 milestone Nov 27, 2018

(WPE_BACKEND_MAJOR_VERSION == (major) && WPE_BACKEND_MINOR_VERSION == (minor) && \
WPE_BACKEND_MICRO_VERSION >= (micro)))

WPE_EXPORT unsigned wpe_backend_get_major_version(void);

This comment has been minimized.

@mcatanzaro

mcatanzaro Nov 28, 2018

Contributor

__attribute__((__deprecated__))

@zdobersek zdobersek merged commit db1d590 into master Nov 30, 2018

@hwti

This comment has been minimized.

Copy link
Contributor

hwti commented Nov 30, 2018

The CMakelists.txt needs to have something to generate the version-deprecated.h, like :

configure_file(include/wpe/version-deprecated.h.cmake ${DERIVED_SOURCES_DIR}/version-deprecated.h @ONLY)

It also needs to be added to WPE_PUBLIC_HEADERS, else it isn't installed.

@psaavedra

This comment has been minimized.

Copy link
Contributor

psaavedra commented Dec 1, 2018

The CMakelists.txt needs to have something to generate the version-deprecated.h, like :

configure_file(include/wpe/version-deprecated.h.cmake ${DERIVED_SOURCES_DIR}/version-deprecated.h @ONLY)

It also needs to be added to WPE_PUBLIC_HEADERS, else it isn't installed.

#40

@carlosgcampos carlosgcampos deleted the cgarcia/wpe-version branch Dec 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment