Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Pass -Wall and check that compiler flags are supported #51

Merged
merged 1 commit into from Aug 12, 2019

Conversation

@aperezdc
Copy link
Contributor

commented Jul 26, 2019

Adds checks to ensure that command line flags passed to the C/C++ copmilers are supported before adding them to the list of flags. This also leaves to CMake the responsibility of determining which compiler flags are needed to choose C++11/C99, instead of passing -std=xyz, because different compilers might use other options for this.


Closes #49

cmake: Pass -Wall and check that compiler flags are supported
Adds checks to ensure that command line flags passed to the C/C++
copmilers are supported before adding them to the list of flags. This
also leaves to CMake the responsibility of determining which compiler
flags are needed to choose C++11/C99, instead of passing -std=xyz,
because different compilers might use other options for this.

@aperezdc aperezdc requested review from zdobersek, carlosgcampos and clopez Jul 26, 2019

@aperezdc

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2019

Ping reviewers.

@zdobersek zdobersek merged commit 9ffe8da into master Aug 12, 2019

@aperezdc aperezdc deleted the add-wall branch Aug 12, 2019

@aperezdc

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2019

Thanks @zdobersek!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.