Browsers.iOS < 4.2 wouldn't work for non-iOS browsers #116

Closed
ghost opened this Issue Jan 5, 2012 · 2 comments

Comments

Projects
None yet
0 participants
@ghost

ghost commented Jan 5, 2012

for example in function canPlayType
canPlayType: function(t) {
/*
There is a bug in iOS 4.1 or earlier where probably and maybe are switched around.
This bug was reported and fixed in iOS 4.2
*/

                if (Browsers.iOS < 4.2)
                    return this.element.canPlayType(t) == 'probably' || this.element.canPlayType(t) == 'maybe';
                else 
                    return this.element.canPlayType(t) == 'probably';
            }

If I use Android browser, Browsers.iOS is false, and Browsers.iOS < 4.2 is going to be true. But you probably want Browsers.iOS < 4.2 to be false if I'm using non-iOS browser.

@ghost

ghost commented Jan 5, 2012

something like

if (Browsers.iOS && Browsers.iOS < 4.2)

?

@ghost

ghost commented Jan 5, 2012

see issue #117

ghost closed this Jan 5, 2012

@NielsLeenheer NielsLeenheer added a commit that referenced this issue Jan 5, 2012

@NielsLeenheer NielsLeenheer Merge pull request #117 from alexyida/master
Fixes issue #116: Browsers.iOS < 4.2 wouldn't work for non-iOS browsers
e2b2f66

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment