Fix "input type=color - Field validation" test. #131

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants
@int32t

int32t commented Apr 10, 2012

A color type field never be invalid because any invalid values are sanitized to
a valid value "#000000".

Opera and WebKit will pass this test.
https://bugs.webkit.org/show_bug.cgi?id=83533

Fix "input type=color - Field validation" test.
A color type field never be invalid because any invalid values are sanitized to
a valid value "#000000".
@beverloo

This comment has been minimized.

Show comment
Hide comment
@beverloo

beverloo Apr 10, 2012

Section of the specification which describes this behavior:
http://www.whatwg.org/specs/web-apps/current-work/multipage/states-of-the-type-attribute.html#color-state-(type=color)

Will element.field.value reflect the internal change to "#000000"? If so, it's probably good practice to verify whether it's actually being changed to that when invalid values are being set.

Section of the specification which describes this behavior:
http://www.whatwg.org/specs/web-apps/current-work/multipage/states-of-the-type-attribute.html#color-state-(type=color)

Will element.field.value reflect the internal change to "#000000"? If so, it's probably good practice to verify whether it's actually being changed to that when invalid values are being set.

@int32t

This comment has been minimized.

Show comment
Hide comment
@int32t

int32t Jun 25, 2012

Will element.field.value reflect the internal change to "#000000"?

Yes. But I don't think we should verify the resultant value because the previous test "Value sanitization" should be responsible for it.

int32t commented Jun 25, 2012

Will element.field.value reflect the internal change to "#000000"?

Yes. But I don't think we should verify the resultant value because the previous test "Value sanitization" should be responsible for it.

@miketaylr

This comment has been minimized.

Show comment
Hide comment
@miketaylr

miketaylr Jul 6, 2012

+1 for @int32t's change. As is, this test doesn't make much sense.

+1 for @int32t's change. As is, this test doesn't make much sense.

@NielsLeenheer

This comment has been minimized.

Show comment
Hide comment
@NielsLeenheer

NielsLeenheer Jul 9, 2012

Collaborator

Going to remove the validation test completely in the next version (current at alpha.html5test.com)

Collaborator

NielsLeenheer commented Jul 9, 2012

Going to remove the validation test completely in the next version (current at alpha.html5test.com)

@int32t

This comment has been minimized.

Show comment
Hide comment
@int32t

int32t Jul 10, 2012

Going to remove the validation test completely in the next version (current at alpha.html5test.com)

Ok, it makes sense.

int32t commented Jul 10, 2012

Going to remove the validation test completely in the next version (current at alpha.html5test.com)

Ok, it makes sense.

@int32t int32t closed this Jul 10, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment