Add Map#clear and WeakMap#clear #4

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@eriwen

eriwen commented Nov 12, 2012

Simple impl and tests for Map#clear, according to current (10/26/12) spec draft.

@eriwen

This comment has been minimized.

Show comment
Hide comment
@eriwen

eriwen Nov 12, 2012

Nevermind, should have left it commented out as this won't work in FF :/

eriwen commented Nov 12, 2012

Nevermind, should have left it commented out as this won't work in FF :/

@eriwen eriwen closed this Nov 12, 2012

@WebReflection

This comment has been minimized.

Show comment
Hide comment
@WebReflection

WebReflection Nov 12, 2012

Owner

hey, nice ... with tests too. What is wrong with FF?

Owner

WebReflection commented Nov 12, 2012

hey, nice ... with tests too. What is wrong with FF?

@eriwen

This comment has been minimized.

Show comment
Hide comment
@eriwen

eriwen Nov 12, 2012

Tests don't pass in FF16, when I ran them. Weird because Object.isExtensible(Map) returns true. Maybe you could verify that?

eriwen commented Nov 12, 2012

Tests don't pass in FF16, when I ran them. Weird because Object.isExtensible(Map) returns true. Maybe you could verify that?

@WebReflection

This comment has been minimized.

Show comment
Hide comment
@WebReflection

WebReflection Nov 12, 2012

Owner

right ... reason is: FF 16 does not expose clear, neither iterate, nether keys ... neither is possible to use for/of or for/in so I believe it's not possible to implement clear over native FF 16 constructors :-/

Owner

WebReflection commented Nov 12, 2012

right ... reason is: FF 16 does not expose clear, neither iterate, nether keys ... neither is possible to use for/of or for/in so I believe it's not possible to implement clear over native FF 16 constructors :-/

@eriwen

This comment has been minimized.

Show comment
Hide comment
@eriwen

eriwen Nov 12, 2012

I am working on a destructive "shim" to get things working in Firefox until they implement more. Thanks for your work on this project; it's been educational :)

eriwen commented Nov 12, 2012

I am working on a destructive "shim" to get things working in Firefox until they implement more. Thanks for your work on this project; it's been educational :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment