New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to use this in typescript node project #87
Comments
I have no idea. I was hoping TypeScript would've been smarter there, as everything is defined in the extend. I don't use TS neither, so I wouldn't know how to fix this. If there's anything one could do at JSDoc level, please file a PR, otherwise this will be parked for long time. |
I modified the file
Then run again:
I got 1 less error:
That's the culprit!. |
so ... basically ... if I remove all the |
I don't use |
Are those two classes the only affected? |
Its every class that has |
Right .. my counter-argument is: I use VS Code and adding those Dropping all implements will break users expectations to date, so I am trying to understand what TS needs to be able to assume something is implementing what it says it's implementing, without bothering developers. The definition was also a PR from a TS user, so, as I am not one of those, it looks like we need to be aligned/sync'd and find the best solution that works for us all. |
P.S. quick example: reading |
I removed all
Then run again:
It now has only 32 errors:
And it has nothing todo with |
I don't know how to fix those remaining errors. |
Neither do I, nor I have time to do so, as I don't use TS.
Not going to happen here, sorry. Feel free to fork this project.
I use code and those JSDoc comments helps a lot me daily, as they do a very good job, without getting on my way, to suggest all the things. But even removing those, TS complains about internal implementation details, and this, I am afraid, is not really my problem. Closing, as this is clearly a won't fix at this point. |
As it might help someone, here is how I fixed this problem in my Typescript project. 😉 {
"compilerOptions": {
"skipLibCheck": true
}
} |
I installed it using:
npm install linkedom --save
Then I run script:
import {DOMParser, parseHTML} from 'linkedom';
I got:
The text was updated successfully, but these errors were encountered: