-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish holidays #1
Conversation
latest version uses modules instead, where any date can be actually a function that will receive the meant year to deal with ... do you mid updating this PR reflecting that change ? You can find an Italian easter example in here. Or at least it could export a module so for the time being, your country has some date to show 😉 Thanks a lot for your initial PR anyway !!! |
There are also 4 movable holdays, but there's no way to mark them right now.
Awesome. Out of curiosity, since I'm not really a catholic (or religious whatsoever) persons, wouldn't make sense to have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check my comments + functions signatures
region: [] | ||
}; | ||
|
||
function pentecost() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the signature wants Y
return date; | ||
} | ||
|
||
function corpusChristi() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the signature wants Y
Regarding religious holidays, yes, it'll most likely end up in |
@kamilogorek pentecost and pentecostMonday are now in utils.js together with other utilities ;-) |
There are also 4 movable holdays, but there's no way to mark them right now.Fixed.