Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish holidays #1

Merged
merged 2 commits into from
Aug 27, 2018
Merged

Polish holidays #1

merged 2 commits into from
Aug 27, 2018

Conversation

kamilogorek
Copy link
Contributor

@kamilogorek kamilogorek commented Aug 26, 2018

There are also 4 movable holdays, but there's no way to mark them right now.

Fixed.

@coveralls
Copy link

coveralls commented Aug 26, 2018

Pull Request Test Coverage Report for Build 35

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%

Totals Coverage Status
Change from base Build 33: 0.0%
Covered Lines:
Relevant Lines: 0

💛 - Coveralls

@WebReflection
Copy link
Owner

latest version uses modules instead, where any date can be actually a function that will receive the meant year to deal with ... do you mid updating this PR reflecting that change ?

You can find an Italian easter example in here.

Or at least it could export a module so for the time being, your country has some date to show 😉

Thanks a lot for your initial PR anyway !!!

There are also 4 movable holdays, but there's no way to mark them right now.
@WebReflection
Copy link
Owner

WebReflection commented Aug 26, 2018

Awesome. Out of curiosity, since I'm not really a catholic (or religious whatsoever) persons, wouldn't make sense to have corpusChristi and pentecost as common.js too ?

Copy link
Owner

@WebReflection WebReflection left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check my comments + functions signatures

region: []
};

function pentecost() {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the signature wants Y

return date;
}

function corpusChristi() {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the signature wants Y

@WebReflection WebReflection merged commit 8376e26 into WebReflection:master Aug 27, 2018
@kamilogorek kamilogorek deleted the patch-1 branch August 27, 2018 08:08
@kamilogorek
Copy link
Contributor Author

Regarding religious holidays, yes, it'll most likely end up in common.js sooner or later. Didn't want to move it there, as no other location is using them just yet.

@WebReflection
Copy link
Owner

@kamilogorek pentecost and pentecostMonday are now in utils.js together with other utilities ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants