Minor improvements & tests + splitViews #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 15690653660Details
💛 - Coveralls |
Owner
Author
|
on the other hand, maybe having a benchmark in here would be great to help making a decision (or decide to drop the flag at all and always use splitview in there) |
Owner
Author
|
Actually ... the benchmark would be better done on real-world use cases so it'll be in coincident. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One main thing to benchmark properly is how much splitViews could boost buffer conversion via this encoder, as opposite of pushing everything into the array to then set it again later on ... however, I think that possibility should be around to avoid changing this library in the future and let coincident/users decide what to do.