Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCAYT should require removeformat plugin or use it more carefully #2

Closed
Reinmar opened this issue Dec 19, 2012 · 3 comments

Comments

Projects
None yet
1 participant
@Reinmar
Copy link
Contributor

commented Dec 19, 2012

  1. Clone ckeditor-dev repo.
  2. Clone SCAYT inside plugins dir.
  3. Add SCAYT to extraPlugins.
  4. Open inlineall sample.

Error is thrown:

[11:53:59.145] TypeError: this._.removeFormat is undefined @ http://localhost/cksource/ckeditor-dev/plugins/removeformat/plugin.js:142

SCAYT incorrectly tests for removeFormat. It may be loaded, but not initialized yet, since SCAYT doesn't require remofeFormat. So better test is needed than:

editor.addRemoveFormatFilter && editor.addRemoveFormatFilter( scaytFilter );
@Reinmar

This comment has been minimized.

Copy link
Contributor Author

commented Dec 19, 2012

We're also considering fixing this on our side. Removeformat shouldn't expose method if it isn't able to work correctly. I'll let you know what's the decision.

@Reinmar

This comment has been minimized.

Copy link
Contributor Author

commented Dec 19, 2012

Ticket on CKEditor's dev site - http://dev.ckeditor.com/ticket/9853

@Reinmar

This comment has been minimized.

Copy link
Contributor Author

commented Dec 20, 2012

We fixed this on our side - http://github.com/ckeditor/ckeditor-dev/commit/eaa08e6

Now is enough to check whether editor#addRemoveFormatFilter exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.