Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New CKEditor skin adjustments. #37

Closed
f1ames opened this issue Aug 9, 2016 · 3 comments
Closed

New CKEditor skin adjustments. #37

f1ames opened this issue Aug 9, 2016 · 3 comments

Comments

@f1ames
Copy link
Contributor

f1ames commented Aug 9, 2016

Hello WSC team,
we are working on the new skin for CKEditor 4, which will become the default skin starting from CKEditor 4.6.0. While it only changes the look, there were a few small things to polish to make wsc plugin look good with this skin. I made some changes so everything looks smooth. Those changes concern only a new skin so the plugin will still look the same with the previous moono and other skins (in other words the plugin is visually backward compatible - if you can call it that way). The changes I introduced adds an external stylesheet to make it more flexible and to not mess the code (because in fact, these are visual changes only so should be separated anyway). I will create a PR soon, so you can review these changes.

The connected task in our bug tracker is #14790.

@f1ames
Copy link
Contributor Author

f1ames commented Aug 9, 2016

Created PR #38. If you need more information to proceed with this, do not hesitate to ask.

@f1ames
Copy link
Contributor Author

f1ames commented Sep 9, 2016

Any progress on this one?

@f1ames
Copy link
Contributor Author

f1ames commented Sep 14, 2016

I see that PR has been merged by @BogdanDidenko. That's great, thanks!

We are close to concluding the skin on our side so I will keep you updated when we are done so you can also check it.

@f1ames f1ames closed this as completed Sep 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant