Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CKEditor 5] Correcting a word doesn't work well with markers #14

Closed
Mgsy opened this issue Aug 6, 2019 · 5 comments

Comments

@Mgsy
Copy link

commented Aug 6, 2019

To reproduce this issue it's required to run the editor with the comments plugin.

Steps to reproduce

  1. Insert the word "teswt".
  2. Select it.
  3. Add a new comment thread.
  4. Hover the word.
  5. Correct it to "testa".

Current result

A part of the marker is lost.

@wsc-julia-shaptala

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

We think that this issue is related to #7 and your issue #216. It's related to the mechanism of handling text mutations by the editor.

As it was mentioned in #7, we will try to use internal CKEditor 5 input command which should handle text replacing.

But we hope that this issue and #7 will be fixed automatically after the issue #216 is resolved.

@Reinmar

This comment has been minimized.

Copy link

commented Aug 13, 2019

We don't currently have a method which could handle this in a better way. The current input command overrides the content. We'd need a new type of command which would get markers and attributes into consideration.

I'll report a followup on our side.

@wsc-julia-shaptala

This comment has been minimized.

Copy link
Member

commented Aug 15, 2019

The fix for the issue has been released. We used CKE5's API: editor.execute( 'input', { text: 'hello' } ) as a temporary solution.
@Mgsy, please confirm if the issue is solved.

@Mgsy

This comment has been minimized.

Copy link
Author

commented Aug 27, 2019

@Mgsy, please confirm if the issue is solved.

I've checked it and it's fixed.

@wsc-julia-shaptala

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

Great, thank you for the confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.