Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need for a workaround to assign the editor instance to a HTMLElement #17

Closed
mlewand opened this issue Aug 8, 2019 · 2 comments

Comments

@mlewand
Copy link

commented Aug 8, 2019

Currently the Configuring WProofreader Cloud for CKEditor 5 v12.0+ have following listing:

ClassicEditor.create(
	document.querySelector('#editor')
).then((editor) => {
	editor.ui.getEditableElement('main').editor = editor;
});

Given that CKEditor 5 now adds ckeditorInstance property there's no need for this workaround anymore.

@wsc-julia-shaptala

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

@mlewand,
This workaround is still required for the correct work with the Proofread in dialog mode. However, we do plan to replace the previous workaround with the ckeditorInstance property. This is already scheduled for the next upcoming release by the end of August.

As soon as this flow is implemented and released, we will update the docs.

@wsc-julia-shaptala

This comment has been minimized.

Copy link
Member

commented Aug 15, 2019

With today's release we start using the ckeditorInstance property. Thus, for CKEditor 5 v12.3.0 or higher, this workaround is not longer needed. Our guides are updated accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.