Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search for source strings only #2884

Closed
comradekingu opened this issue Jul 16, 2019 · 6 comments
Closed

Search for source strings only #2884

comradekingu opened this issue Jul 16, 2019 · 6 comments
Labels
bug Something is broken. ux Issues related to user experience.
Milestone

Comments

@comradekingu
Copy link
Contributor

comradekingu commented Jul 16, 2019

https://hosted.weblate.org/projects/weblate/#search

Search for "good" in source strings, partial matches

https://hosted.weblate.org/search/weblate/?checksum=&offset=&q=good&search=substring&source=on&type=all&ignored=False&date=&only_user=&exclude_user=

This returns "good" in English, from every target language. That has some utility, don't know if it also includes "good" in the target, when it isn't found in the source?

However, I would expect to only get "good" from source strings.

Searching with English as selected target language when doing source string searches is the easiest and ugliest hack I could think of.

@nijel nijel added the bug Something is broken. label Jul 16, 2019
@nijel
Copy link
Member

nijel commented Jul 16, 2019

It does search only in source string, just the highlighting is wrongly done on all content.

@nijel nijel added the ux Issues related to user experience. label Jul 16, 2019
@nijel
Copy link
Member

nijel commented Jul 16, 2019

Also related to #42

@comradekingu
Copy link
Contributor Author

comradekingu commented Dec 2, 2019

@nijel Perhaps highlighting includes more hits (?) My issue is I sometimes want to find out if a string is used upstream, without paging through all the ir/relevant hits from other languages. (Not really sure when one needs hits from all languages)

How about if these queries from the search:

  • Source strings
  • Target strings

was

  • Source strings with results for every language
  • Target strings
  • Source strings only

@nijel
Copy link
Member

nijel commented Dec 2, 2019

In 3.10 you will be able to search in source language only thanks to #2831

@nijel nijel modified the milestones: 3.11, 3.10 Dec 13, 2019
@nijel
Copy link
Member

nijel commented Dec 18, 2019

Searching is there for 3.10, let's deal with the highlighting in #42

@nijel nijel closed this as completed Dec 18, 2019
@github-actions
Copy link

Thank you for your report, the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see similar problem, please open separate issue.
  • If you are happy with the outcome, consider supporting Weblate by donating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken. ux Issues related to user experience.
Projects
None yet
Development

No branches or pull requests

2 participants