Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add alternative text for search for #80 #81

Merged
merged 1 commit into from Jan 29, 2013

Conversation

Projects
None yet
3 participants
Contributor

bitboxer commented Jan 24, 2013

This adds the possiblity to add additional texts for the search.

Collaborator

arvida commented Jan 28, 2013

Sorry for a late reply!

I like the idea. However I am a bit hesitant to replacing list.js with a custom solution. I noticed that list.js doesn't look to support data attributes, is that why you decided to add your own implementation or any other reason?

@joeljunstrom any thoughts?

Contributor

bitboxer commented Jan 29, 2013

Yes, it replaces list.js . There is no way I could add that feature without a) extending list.js or b) replacing it by a small script.

The site only uses one of the many features of list.js (search) so the replacement code is pretty small. Way smaler that the original code was ;) . I could wrap that stuff into a list.js plugin to do the searching (similar to the fuzzy search plugin), but that would make the code bigger without any additional benefit.

Collaborator

arvida commented Jan 29, 2013

Cool, sounds good! Ill merge this, thanks! 😎

@arvida arvida added a commit that referenced this pull request Jan 29, 2013

@arvida arvida Merge pull request #81 from bitboxer/master
Add alternative text for search for #80
b766d07

@arvida arvida merged commit b766d07 into WebpageFX:master Jan 29, 2013

Collaborator

joeljunstrom commented Jan 29, 2013

I'm all for it. Not that it matters much but it's ”better” if we do not traverse the dom on each search. But we can patch that later.

Collaborator

arvida commented Jan 29, 2013

💥 .. and it is deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment