Skip to content
Permalink
Browse files

! Fixed a bug with no consequences, but nasty to figure out, because …

…it implied the homepage was loaded on mobile in Ajax mode, which wasn't supposed to happen. (Yeah, whatever.) As a rule of thumb, really, please developers, avoid using redirectexit() in an Ajax page! It didn't strike me as 'obvious' that the page would be loaded this way, which is why it took me days to figure it out. It's tempting to add a failsafe in that function itself, but I don't think it's likely to happen often, and I'll probably remember it next time, eheh. (Notifications.php)

! Forgot to add the skeleton.xml file in the last commit. (skeleton.xml)

+ A tentative DCO file, for contributors to agree to when they sign-off their code. (DCO.txt)

- Unused class. (PersonalMessage.template.php)
  • Loading branch information...
Nao committed Nov 11, 2013
1 parent f04d98e commit 85b7176320fc7fe93331c376e6d1fedaa919d13c
Showing with 45 additions and 5 deletions.
  1. +38 −0 DCO.txt
  2. +2 −0 Sources/Notifications.php
  3. +3 −3 Themes/default/PersonalMessage.template.php
  4. +2 −2 Themes/default/skins/skeleton.xml
38 DCO.txt
@@ -0,0 +1,38 @@

Wedge Developer Grant and Certificate of Origin 1.0

By making a contribution to the Wedge project ("Project"),
I represent and warrant that:

(a) The contribution was created in whole or in part by me, and I
have the right to submit the contribution on my own behalf or
on behalf of a third party who has authorized me
to submit this contribution to the Project; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right and authorization to submit that
work with modifications, whether created in whole or in part
by me, under the Wedge license or a compatible license that
I have identified in the contribution; or

(c) The contribution was provided directly to me by some other
person who represented and warranted (a), (b) or (c) and
I have not modified it.

(d) I understand and agree that this Project and the contribution
are publicly known and that a record of the contribution (including all
personal information I submit with it, including my sign-off record) is
maintained indefinitely and may be redistributed consistent with
this Project or the license(s) involved.

(e) I hereby grant to the Project, and its copyright holders;
and recipients of software distributed by the Project a perpetual,
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
copyright license to reproduce, modify, prepare derivative works
of, publicly display, publicly perform, sublicense, and distribute
this contribution and such modifications and derivative works
consistent with this Project, the compatible license indicated
in the previous work or other appropriate open source license
specified by the Project and approved by the Open Source
Initiative (OSI) at http://www.opensource.org.
@@ -303,6 +303,8 @@ public static function action()
if (!empty($notifications[0]))
$notifications[0]->markAsRead();
if (AJAX)
exit();
redirectexit();
}
elseif ($sa == 'preview' && isset($_REQUEST['in']))
@@ -285,7 +285,7 @@ function loadLabelChoices()
</div>
<div class="postarea">
<div class="postheader">
<div class="keyinfo">
<div>
<h5 id="subject_', $message['id'], '">
', $message['subject'], '
</h5>';
@@ -308,11 +308,11 @@ function loadLabelChoices()
// If we're in the sent items, show who it was sent to besides the "To:" people.
if (!empty($message['recipients']['bcc']))
echo '
<div class="smalltext">&#171;&nbsp;<strong> ', $txt['pm_bcc'], ':</strong> ', implode(', ', $message['recipients']['bcc']), '&nbsp;&#187;</div>';
<div class="smalltext">« <strong> ', $txt['pm_bcc'], ':</strong> ', implode(', ', $message['recipients']['bcc']), ' »</div>';
if (!empty($message['is_replied_to']))
echo '
<div class="smalltext">&#171;&nbsp;', $message['replied_msg'], '&nbsp;&#187;</div>';
<div class="smalltext">« ', $message['replied_msg'], ' »</div>';
echo '
</div>
@@ -75,10 +75,10 @@
<msg_ignored />
<msg_body />
<msg_actionbar />
</msg_entry>
<msg_bottom>
<msg_attachments />
<msg_customfields />
</msg_entry>
<msg_bottom>
<msg_signature />
</msg_bottom>
</msg_area>

0 comments on commit 85b7176

Please sign in to comment.
You can’t perform that action at this time.