New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Foreign language like Vietnamese #146

Closed
ankitsusheel opened this Issue Oct 30, 2015 · 6 comments

Comments

Projects
None yet
3 participants
@ankitsusheel
Copy link

ankitsusheel commented Oct 30, 2015

Currently few pages which contains foreign language are working unexpectedly and some letters are not displaying in H1

https://www.stgeorge.com.au/personal/solutions/new-to-australia/vietnamese

@dominikwilkowski

This comment has been minimized.

Copy link
Contributor

dominikwilkowski commented Oct 30, 2015

Thanks for reporting @imshitu

We recommend to fallback to a font-family without the webfont so either remove the 'roboto' font string or remove the webfont itself on that page. The later is preferred if you are able to.

This is a very intriguing problem you got there though 👍

@dominikwilkowski

This comment has been minimized.

Copy link
Contributor

dominikwilkowski commented Nov 2, 2015

I added this question to the FAQs. Thanks for that again. We will updated this when new information come in.

@dominikwilkowski

This comment has been minimized.

Copy link
Contributor

dominikwilkowski commented Nov 3, 2015

We are still investigating this actually so let me reopen :)

Right now we are thinking to remove the roboto web-font all together. This would mean for body text the system font for each OS will be used. That makes sense as those font's are explicitly tuned for each system.

the font-family would then become something like:

-apple-system, ".SFNSText-Regular", "San Francisco", "Roboto", "Segoe UI", "Helvetica Neue", "Lucida Grande", sans-serif;

@oksushi

This comment has been minimized.

Copy link
Contributor

oksushi commented Nov 3, 2015

If you were to keep with the brand font, you could also create an extended version, that contained the glyphs excluded from the main set. You can then load these as required for language–specific pages, or across an entire site.

You can do this with Unicode Range Subsetting

@dominikwilkowski

This comment has been minimized.

Copy link
Contributor

dominikwilkowski commented Nov 3, 2015

Yeah that's a great idea for the brand-font. I am not sure the dragon font built for St.George even has those characters in the first place.

Let's find out. :)

@dominikwilkowski

This comment has been minimized.

Copy link
Contributor

dominikwilkowski commented Nov 3, 2015

Testing of the above mentioned font-family
-apple-system, ".SFNSText-Regular", "San Francisco", "Roboto", "Segoe UI", "Helvetica Neue", "Lucida Grande", sans-serif;

resulted in all devices supporting all font-weights with the notable exception of our own windows phone that only displays bold and normal.

In light of the usage of those devices only being inside Westpac I am inclined to disregard them. Does anyone think differently?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment