Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Any and Negation Types #827

Closed
DavePearce opened this Issue Oct 27, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@DavePearce
Copy link
Member

DavePearce commented Oct 27, 2017

(tracking issue for RFC#0020)

This is a simple proposal to remove the any type and negation types. Whilst these types are potentially useful type, there is no doubt that they make life more complex. In particular for handling the translation of backends.

  • Remove any type
  • Remove negations from source syntax
  • Replace negations with differences
  • Update Documentation (e.g. WLS)

@DavePearce DavePearce changed the title Remove Any Type Remove Any and Negation Types Oct 27, 2017

DavePearce added a commit that referenced this issue Oct 27, 2017

Remove negation types from source syntax #827
This removes negation types from the source-level syntax, though retains
them internally.

DavePearce added a commit that referenced this issue Oct 27, 2017

Fix invalid test cases #827
This fixes invalid test cases after the removal of any and negation
types.

DavePearce added a commit that referenced this issue Nov 8, 2017

Replace Type.Negation with Type.Difference #827
This replaces WhileyFile.Type.Negation with WhileyFile.Type.Difference.
All relevant code has been updated to compile and, at least
superficially, to work.  However, numerous tests are now failing which
is somehow related to type extraction.

DavePearce added a commit that referenced this issue Nov 8, 2017

Updated invalid test case outputs #827
The invalid test outputs were invalid in some cases because they
referred to negation types rather than the new difference types.  For
example, they might have included a type "(int|null)&!null" which is now
represented as "(int|null)-null".
@DavePearce

This comment has been minimized.

Copy link
Member Author

DavePearce commented Nov 8, 2017

Done!!

@DavePearce DavePearce closed this Nov 8, 2017

DavePearce added a commit that referenced this issue Nov 8, 2017

Fix for subtype unit tests #827
This is related to the removal of the any type.  In particular, all
tests involving this type were now failing (since it wasn't recognised).
Fixed by removing all lines mentioning "any".

@DavePearce DavePearce reopened this Apr 17, 2018

@DavePearce DavePearce closed this Oct 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.