-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: find platform type based on browser second argument #485
fix: find platform type based on browser second argument #485
Conversation
Thanks for your contribution. The next step is to wait for review and approval to merge it to main repository The community can help reacting with a thumb up (:thumbsup:) for approval and rocket (:rocket:) for who has tested it. To test this PR you can run the following command below:
|
Can fi be used in the pairing code? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The linter goes crazy about not changed code, idk what to do here. Let me know if I need to adjust the code somehow! |
Great Job!!!! If it is possible, what do you think in adding two more browsers: |
Add. Firefox brave tor |
Lgtm |
Is there any values for this browsers in WhatsApp proto? I didn't see it in the list Lines 533 to 557 in e24947e
I'll change the solution as @Ismananda mentioned so we can define any values that available in proto! |
adf055e
to
32533ed
Compare
What is LGTM |
Can this Working For Also For QR Code ? |
Pair code mode not working with recent change |
… pairing code)" This reverts commit 73ffb2a.
Thank you for the information! To be honest, I haven't tested it :D I've reverted the changes - we can process them later in the different PR and merge QR mode for now. |
looks good to me |
I'm qr is working but in pair its say incorrect code what I do |
@allburov This One Working On QR Code And Pair Code You Can Check Here And You Can Also Test It And You Can Make Pull Request @adiwajshing @PurpShell @Auties00 @SheIITear @whiskeysockets-bot @FERDIZ-afk you can merge that request if @allburov he make it |
Excuse me, I can see your socket configuration in the browser section |
That's my Browser Configuration and I also added in my Baileys that i added in my pair code script folder If you want browser version then you can find on google |
So maybe it was unsuccessful because of the differences in the implementation of javascript with typescript or maybe other factors. Thank you for trying my advice and apologize for trouble |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
This is not for the pairing code, this is stupid and incorrect. the second argument is the one for the browser type not the first one. Just reverse |
I tried it's working for both pairing code and qr code |
Do not fill this pr with unrelated comments. If you need help ask on the offtopic channel on the discord server. |
But it's related to this pr, I tried using the same way as the examples and it didn't work |
Still this is not the place to ask for help. Locking this pr, you can continue the conversation on the server. |
fix #481 #228
If we use
WhatsApp shows the browser's icon in Linked Devices