Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Shader doesn't compile on FPS example (Linux/Chrome) #19

Closed
jackdalton opened this issue Dec 21, 2015 · 15 comments
Closed

[Bug] Shader doesn't compile on FPS example (Linux/Chrome) #19

jackdalton opened this issue Dec 21, 2015 · 15 comments
Assignees
Labels

Comments

@jackdalton
Copy link
Member

jackdalton commented Dec 21, 2015

The FPS example is broken on several Linux distributions. Attached is a console log.

@jackdalton
Copy link
Member Author

Chrome v47.0.2526.106 (Official Build) (64-bit)

@jackdalton
Copy link
Member Author

Kubuntu 15.10 x64.

@jackdalton
Copy link
Member Author

Same happens with Arch Linux x64.

Specific error message:

error: sampler arrays indexed with non-constant expressions are forbidden in GLSL 1.30 and later

@jackdalton jackdalton assigned jackdalton and unassigned sasha240100 Dec 29, 2015
@jackdalton jackdalton added this to the TODO milestone Dec 29, 2015
@jackdalton jackdalton reopened this Dec 29, 2015
@jackdalton jackdalton changed the title FPS example broken Shader doesn't compile on FPS example (Linux/Chrome) Dec 29, 2015
@jackdalton
Copy link
Member Author

Related to mrdoob/three.js#6115.

@jackdalton
Copy link
Member Author

@sasha240100 sasha240100 changed the title Shader doesn't compile on FPS example (Linux/Chrome) [Bug] Shader doesn't compile on FPS example (Linux/Chrome) Jan 5, 2016
@jackdalton
Copy link
Member Author

Confirmed by another user here.

@jackdalton
Copy link
Member Author

mrdoob/three.js#6929

@jackdalton
Copy link
Member Author

spite's suggestion yielded nothing, composer size is set here.

@Mugen87
Copy link

Mugen87 commented Jan 30, 2016

See WebGL shader fails to initialize. The bug will be fixed with Chrome 49.

The dev-build of Chrome already contains the fix. All my test cases work properly.

@Mugen87
Copy link

Mugen87 commented Jan 30, 2016

Besides, the error doesn't occur with the latest dev version of three.js.

@sasha240100
Copy link
Member

@Mugen87 Thanks! Is that version stable now?

@Mugen87
Copy link

Mugen87 commented Jan 30, 2016

@sasha240100 No, it's just the latest build of the three.js dev branch. I don't recommend to use it in production. This commit fixes the issue. If you need a hotfix, you can implement it in a custom build of three.js.

@sasha240100
Copy link
Member

@Mugen87 Will this one support this fix?(dev channel)

@Mugen87
Copy link

Mugen87 commented Jan 30, 2016

@sasha240100 Well, if you use this version of Chrome (dev channel), you won't get the error even in older three.js revisions.

If you can't upgrade your browser, you can implement the mentioned fix for three.js. Or just wait until everything lands in production...

@jackdalton
Copy link
Member Author

@Mugen87 Thanks for taking the time to help us out with this, not being able to see some of our demos has been driving me crazy. I grabbed google-chrome-dev out of the AUR, and everything works. I've just been using google-chrome-beta, I never thought to test with Chrome's dev build.

@sasha240100 sasha240100 modified the milestones: in progress, TODO Jan 30, 2016
@sasha240100 sasha240100 modified the milestones: IN PROGRESS, DONE Sep 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants