Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSoC anon-connection-wizard project #7

Merged
merged 101 commits into from Aug 28, 2017

Conversation

Projects
None yet
2 participants
@irykoon
Copy link
Contributor

commented Jul 8, 2017

  • implemented edit mark approach

  • minor GUI changes

  • added a help button on proxy page

  • added an option on censorship circumvention tools options page

  • torrc_page has been implemented

  • switch from edit-mark approach to torrc.d

  • minor GUI changes

  • .tmp will not overwrite .torrc if no changes were made before canceling

  • remove "advance" button

  • switched from /usr/lib/python3.4 to /usr/lib/python3/dist-packages

  • default settings will be adjusted according to .torrc

  • switch from self-made .tmp file to python tmpfile

  • better instructions and UI

irykoon added some commits May 1, 2017

add a third party censorship circumvention options
minor UI improvement
minor instructions improvement
corrected
 install path
1. switch from self-made .tmp file to python tmpfile
2. polish the adjust according to .torrc feature
1. fix the situiation where an extra empty line is input to custom br…
…idge line

2. strip the '\n' out of port number

irykoon added some commits Aug 5, 2017

use "whonix-specific" as a mark
This will benifit the future work that makes anon-connection-wizard independent from Whonix.
fix "Thread termination error"
"Thread termination error: No such process" was camplained when back button was clicked after trying to start Tor.
recover Tor to the initial tor status when quiting or canceling
At the start of anon-connection-wizard, the tor_status, which will be either 'tor_enabled' or 'tor_disabled', will be recorded in Common.init_tor_status. This enable us to recover Tor to its initial status when users quit or terminate the Tor connection status.
@irykoon

This comment has been minimized.

Copy link
Contributor Author

commented Aug 9, 2017

Several termination-related problems have been fixed or improved:

  • make the consequences of clicking close button same with clicking the cancel button
  • enable close button
  • recover Tor to the initial tor status when quiting or canceling
  • fix "Thread termination error"

Other improvement include:

  • eliminate outdated code that may cause IO error
  • skip torrc_page when disable_tor option is selected

irykoon added some commits Aug 10, 2017

update the bridge help instruction
The instructions in the latest Tor launcher has removed the third way to get bridges.
Update default bridges
The default bridge used by anon-connection-wizard should be exactly the same bridges contained in bridge_prefs.js (https://gitweb.torproject.org/builders/tor-browser-bundle.git/tree/Bundle-Data/PTConfigs/bridge_prefs.js?h=7.5a3-linux) shipped with the latest stable TBB. This is because:
1. the servers hosting default bridges are set up for huge amount of traffic;
2. the servers hosting default bridges are probably audited by TPO for better security;
3. using a different set of bridges will distinguish the anon-connection-wizard bridge users from the TBB bridge users, which compromises their anonymity.
@irykoon

This comment has been minimized.

Copy link
Contributor Author

commented Aug 17, 2017

Several bridge and bridge type related changes have been made:

  • Warn unsupported bridge type in summary page
  • Update unsupported bridge type warning in summary page
  • Make bridge types case insensitive
  • Update custom bridge help instructions
  • Update default bridges

Other changes include:

  • Update the initial comments for anon-connection-wizard.torrc

irykoon added some commits Aug 25, 2017

Support input validation check
Current implementation is not using regular expression, which means it is not the perfect validation check. However, this is good enough to prevent most common input mistakes.
Support vanilla bridges when using custom bridges
In order to make a vanilla bridge usable, we need to loose the validation check cateria. A regular expression should solve the problem nicely.
Change anon-connection-wizard.torrc access permission to 644
The access permission was 600, causing a permission denied complain in whonix-check. 644 is same as the permission of the /etc/tor/torrc file shipped by Debian.

@irykoon irykoon changed the title default settings will be adjusted according to .torrc GSoC anon-connection-wizard project Aug 27, 2017

@joysn joysn merged commit 10869f3 into Whonix:master Aug 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.