Removed top-level calls to window and document to make lib work with SSR#318
Merged
WickyNilliams merged 4 commits intoWickyNilliams:masterfrom Sep 3, 2019
Merged
Removed top-level calls to window and document to make lib work with SSR#318WickyNilliams merged 4 commits intoWickyNilliams:masterfrom
WickyNilliams merged 4 commits intoWickyNilliams:masterfrom
Conversation
…f SSR environments Server side rendering might have document and window objects missing. It should be still possible to import library despite that fact.
Owner
|
Excuse the delay! Thanks for this @r00dY. I just fixed the conflicts, and this seems good to merge now. |
Owner
|
Published to npm as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Server side rendering environment might have
documentorwindowobjects missing. However, it should be still possible to import library without them.