Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed top-level calls to window and document to make lib work with SSR #318

Merged
merged 4 commits into from Sep 3, 2019

Conversation

@r00dY
Copy link
Contributor

@r00dY r00dY commented Jun 5, 2019

Server side rendering environment might have document or window objects missing. However, it should be still possible to import library without them.

r00dY and others added 4 commits Jun 5, 2019
…f SSR environments

Server side rendering might have document and window objects missing. It should be still possible to import library despite that fact.
@WickyNilliams
Copy link
Owner

@WickyNilliams WickyNilliams commented Sep 3, 2019

Excuse the delay! Thanks for this @r00dY. I just fixed the conflicts, and this seems good to merge now.

@WickyNilliams WickyNilliams merged commit 469a74c into WickyNilliams:master Sep 3, 2019
1 check passed
@WickyNilliams
Copy link
Owner

@WickyNilliams WickyNilliams commented Sep 11, 2019

Published to npm as v0.10.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants