Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incorrect calculation for "bottom" on non-window scrollers #326

Merged
merged 1 commit into from Aug 29, 2019

Conversation

@WickyNilliams
Copy link
Owner

@WickyNilliams WickyNilliams commented Aug 29, 2019

There was incorrect logic for calculating when at bottom. If your scroller was not window, the bottom class would be applied too early as the code didn't account for the possibility of other types of scroller.

This PR fixes the issue, and improves the test suite to cover this

@WickyNilliams WickyNilliams merged commit cd46a7d into master Aug 29, 2019
2 checks passed
@WickyNilliams WickyNilliams deleted the bugfix/element-scroller-bottom branch Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant