Big bag o' tweaks #330
Big bag o' tweaks #330
Conversation
| self.scroller, | ||
| self.update.bind(self) | ||
| ); | ||
| }, |
There was a problem hiding this comment.
I think I'm going to drop this asynchronous behaviour in a future version. I would have done it now, but I wanted to avoid breaking changes. Developers can always defer initialisation themselves if it matters to them.
There was a problem hiding this comment.
defer event registration to handle browser potentially restoring previous scroll position
This makes it sound like it never was supposed to be a bulletproof solution so I guess it's okay. Maybe we could add an example to the docs/readme/changelog showing how to deal with it on the new version?
There was a problem hiding this comment.
Yeah, it was never perfect. A browser may take longer than 100ms to restore scroll position on a slow connection or long page. An addition to the docs sounds like a good idea 👍
|
Completely unnecessary but do you have the numbers for Brotli compression too? |
WickyNilliams
force-pushed
the
feature/big-bag-o-tweaks
branch
from
ab27fb9
to
6e85771
Compare
|
Good call, I updated the rollup config to output brotli size :) Here's the results pulled from the travis build: |
|
I rebased this branch and dropped the changes to the jQuery/angular plugins, as they were breaking changes. They can be dealt with in a future release |
|
@WickyNilliams let me know if there's anything I can help you with! |
|
@hacknug sure thing. I don't think there's much can be done for this release, but maybe you'd like to take a stab at removing the async behaviour we discussed above? |
This PR contains a host of tweaks, improvements, fixes, file size savings 🎉
In terms of file size, we see the following changes:
Pretty good!