Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/offset top (#343). fixes #340 #343

Merged
merged 3 commits into from Sep 18, 2019

Conversation

@WickyNilliams
Copy link
Owner

commented Sep 17, 2019

v0.10 introduced a bug whereby top was considered to be scrollY === 0. Previously the logic was scrollY <= offset.

This PR fixes that bug

@WickyNilliams WickyNilliams force-pushed the bugfix/offset-top branch from fe98900 to 18c0a0b Sep 18, 2019
@WickyNilliams WickyNilliams force-pushed the bugfix/offset-top branch from 18c0a0b to 0996033 Sep 18, 2019
@WickyNilliams WickyNilliams changed the title Bugfix/offset top Bugfix/offset top (#343). fixes #340 Sep 18, 2019
@WickyNilliams WickyNilliams merged commit fb125a8 into master Sep 18, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@WickyNilliams WickyNilliams deleted the bugfix/offset-top branch Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.