Skip to content

Feature/multiple classes#357

Merged
WickyNilliams merged 6 commits intomasterfrom
feature/multiple-classes
Jan 16, 2020
Merged

Feature/multiple classes#357
WickyNilliams merged 6 commits intomasterfrom
feature/multiple-classes

Conversation

@WickyNilliams
Copy link
Owner

Rebased version of #348.

@WickyNilliams WickyNilliams merged commit 34d276d into master Jan 16, 2020
@WickyNilliams WickyNilliams deleted the feature/multiple-classes branch January 16, 2020 17:09
@WickyNilliams
Copy link
Owner Author

Thanks @hacknug!

@hacknug
Copy link
Collaborator

hacknug commented Feb 3, 2020

Thanks for this, @WickyNilliams ❤️

@WickyNilliams
Copy link
Owner Author

No problems! Really appreciate the contribution

@WickyNilliams
Copy link
Owner Author

@hacknug if you'd like to continue to help out around here, I'm more than happy to give you contributor permissions. No pressure to be super active of course. It is up to you, no worries if not :)

@hacknug
Copy link
Collaborator

hacknug commented Feb 5, 2020

@WickyNilliams don't worry, I've been quite busy for the past weeks and haven't had much time for OSS. I'll open issues and PRs first always to discuss so no need to be able to push directly 👍

@WickyNilliams
Copy link
Owner Author

I just thought it might be a nice gesture as a thank you, and recognition of the time and effort you've put in. There'd be zero obligations - I wouldn't have any expectation of you being active or doing anything really. But if you felt the need, then you could do so freely. Or close issues etc. I would prevent merge to master anyway so PRs would be necessary still.

But like I say, no worries if not, just wanted to reiterate to be clear on expectations :)

@hacknug
Copy link
Collaborator

hacknug commented Feb 6, 2020

Okay. Let's do this then haha

@WickyNilliams
Copy link
Owner Author

You should have now received an invite!

I've setup the repo so that reviews on PRs are required. I understand that this prevents pushes to master.

I don't think there's a great deal of granularity for access rights if a repo is owned by a user (versus an org), so you can pretty much do anything. Use the power wisely :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants