Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/multiple classes #357

Merged
merged 6 commits into from Jan 16, 2020
Merged

Feature/multiple classes #357

merged 6 commits into from Jan 16, 2020

Conversation

@WickyNilliams
Copy link
Owner

WickyNilliams commented Jan 16, 2020

Rebased version of #348.

@WickyNilliams WickyNilliams merged commit 34d276d into master Jan 16, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@WickyNilliams WickyNilliams deleted the feature/multiple-classes branch Jan 16, 2020
@WickyNilliams

This comment has been minimized.

Copy link
Owner Author

WickyNilliams commented Jan 16, 2020

Thanks @hacknug!

@hacknug

This comment has been minimized.

Copy link
Collaborator

hacknug commented Feb 3, 2020

Thanks for this, @WickyNilliams ❤️

@WickyNilliams

This comment has been minimized.

Copy link
Owner Author

WickyNilliams commented Feb 3, 2020

No problems! Really appreciate the contribution

@WickyNilliams

This comment has been minimized.

Copy link
Owner Author

WickyNilliams commented Feb 4, 2020

@hacknug if you'd like to continue to help out around here, I'm more than happy to give you contributor permissions. No pressure to be super active of course. It is up to you, no worries if not :)

@hacknug

This comment has been minimized.

Copy link
Collaborator

hacknug commented Feb 5, 2020

@WickyNilliams don't worry, I've been quite busy for the past weeks and haven't had much time for OSS. I'll open issues and PRs first always to discuss so no need to be able to push directly 👍

@WickyNilliams

This comment has been minimized.

Copy link
Owner Author

WickyNilliams commented Feb 5, 2020

I just thought it might be a nice gesture as a thank you, and recognition of the time and effort you've put in. There'd be zero obligations - I wouldn't have any expectation of you being active or doing anything really. But if you felt the need, then you could do so freely. Or close issues etc. I would prevent merge to master anyway so PRs would be necessary still.

But like I say, no worries if not, just wanted to reiterate to be clear on expectations :)

@hacknug

This comment has been minimized.

Copy link
Collaborator

hacknug commented Feb 6, 2020

Okay. Let's do this then haha

@WickyNilliams

This comment has been minimized.

Copy link
Owner Author

WickyNilliams commented Feb 12, 2020

You should have now received an invite!

I've setup the repo so that reviews on PRs are required. I understand that this prevents pushes to master.

I don't think there's a great deal of granularity for access rights if a repo is owned by a user (versus an org), so you can pretty much do anything. Use the power wisely :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.