Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate up/down offset values #370

Merged
merged 1 commit into from Oct 16, 2020
Merged

Separate up/down offset values #370

merged 1 commit into from Oct 16, 2020

Conversation

matthewnessworthy
Copy link
Contributor

@matthewnessworthy matthewnessworthy commented Aug 20, 2020

Similar to #297 but up-to-date with the new version

Fixes #303

@matthewnessworthy
Copy link
Contributor Author

matthewnessworthy commented Sep 12, 2020

@WickyNilliams would you mind taking a look when you get a chance please?

@WickyNilliams
Copy link
Owner

WickyNilliams commented Sep 12, 2020

Excuse the delay! PR looks great, beautifully simple. I'm away from home without computer atm, will get a chance to merge on Monday.

@matthewnessworthy
Copy link
Contributor Author

matthewnessworthy commented Oct 16, 2020

@WickyNilliams would you mind taking another look when you have a moment please?

@WickyNilliams WickyNilliams merged commit 1c93dad into WickyNilliams:master Oct 16, 2020
@WickyNilliams
Copy link
Owner

WickyNilliams commented Oct 16, 2020

Sorry about the delay! Just released as v0.12.0. Updated docs and changelog https://wicky.nillia.ms/headroom.js/#v0.12.0

@matthewnessworthy matthewnessworthy deleted the separate-up-down-offset-values branch Oct 16, 2020
@WickyNilliams
Copy link
Owner

WickyNilliams commented Oct 19, 2020

Everything working OK for you, @matthewnessworthy?

@matthewnessworthy
Copy link
Contributor Author

matthewnessworthy commented Oct 19, 2020

Everything is working great, thanks!

@WickyNilliams
Copy link
Owner

WickyNilliams commented Oct 19, 2020

Awesome, glad to hear!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Offset: different values for up and down. Same as tolerance, but for offset
2 participants