Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds tool tip for timeline toggle input field #1779

Merged
merged 2 commits into from Mar 12, 2018

Conversation

psinghal20
Copy link
Contributor

@psinghal20 psinghal20 commented Mar 10, 2018

Fixes #1765.
Adds a tooltip displaying a message about what the timeline is good for, uses I18n locales.
Screenshot:
image

Adds a tooltip displaying what the timeline is good for, uses I18n locales.
@psinghal20
Copy link
Contributor Author

psinghal20 commented Mar 10, 2018

Suggestions on the tooltip message will be appreciated. 😄

@@ -538,6 +538,7 @@ en:
timeline: Assignment Details
timeline_enabled: Timeline enabled
timeline_link: Timeline
timeline_tooltip: Timeline help you to keep track of your course by breaking the course duration in weeks which have proper agendas and tasks associated with them.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only change I would make is a grammatical one: I would say "...into weeks with agendas and tasks associated with them." It's tighter as a whole and "into" is more clear because, for example, you can break something into pieces but don't break something in pieces. Just a suggestion! @psinghal20

@@ -538,6 +538,7 @@ en:
timeline: Assignment Details
timeline_enabled: Timeline enabled
timeline_link: Timeline
timeline_tooltip: Timeline help you to keep track of your course by breaking the course duration into weeks which have proper agendas and tasks associated with them.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Enabling the Timeline will let you specify week-by-week activities and assign training modules. It is useful for Education Program courses and other long, highly structured programs."

@psinghal20
Copy link
Contributor Author

@ragesoss Updated the tooltip message. Thanks 😄

@ragesoss ragesoss merged commit 9206097 into WikiEducationFoundation:master Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants