conditionally rendered link issue#2546 #2641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwreid
reviewed
Mar 18, 2019
| @@ -328,7 +328,9 @@ const ArticleViewer = createReactClass({ | |||
| <div className="article-header"> | |||
| <p> | |||
| <span className="article-viewer-title">{trunc(this.props.article.title, 56)}</span> | |||
| <span><a className="icon-link" href={`?showArticle=${this.props.article.id}`} /></span> | |||
| {this.props.article.id === 'undefined' && ( | |||
There was a problem hiding this comment.
I don't think this would/should be able to === 'undefined' as triple equals is used for strict equality. If there is no id, the value should be undefined, not a string with the contents 'undefined'.
A perhaps simpler way to do this is to just use !this.props.article.id.
There was a problem hiding this comment.
Ah! My bad ! , that's a grave mistake on my part .
There was a problem hiding this comment.
Did you try this out? I think we were both wrong here. Instead, it should be:
this.props.article.id && ( ... )There was a problem hiding this comment.
Absolutely right !, had tested it with 'undefined' keyword , made changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Conditionally renders link in ArticleViewer , issue#2546