Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select by boundary picks incorrect boundaries #3082

Closed
SRGDamia1 opened this issue Feb 4, 2019 · 9 comments
Closed

Select by boundary picks incorrect boundaries #3082

SRGDamia1 opened this issue Feb 4, 2019 · 9 comments
Assignees
Labels

Comments

@SRGDamia1
Copy link
Member

@SRGDamia1 SRGDamia1 commented Feb 4, 2019

The select by boundary tool does not appear to be working. It seems to be selecting the boundaries from previous locations or zoom levels. The hover tip gives the wrong area name. Clicking in the area with the incorrect hover tip takes you to the area that matches the name, not the area you are hovered over.

To reproduce:
select boundary - pick any, they all seem to be wrong
move mouse around over region - look for any inconsistencies
jump to any other location using the search bar
move mouse around over region again- see more inconsistencies
click on a suspicious boundary name
be teleported to that boundary

Some MD school district in Coatesville, PA:
image
The Hudson river HUC in Philly:
image
LA county in central Missouri:
image

@SRGDamia1

This comment has been minimized.

Copy link
Member Author

@SRGDamia1 SRGDamia1 commented Feb 4, 2019

@HeatherBrooks pointed it out to me after she got the same behavior.

I'm seeing errors upon opening the application even with a freshly cleared cache. As I move around, the errors seem to multiply.

I'm seeing it in both firefox and chrome.

@darscott

@rajadain rajadain added queue + and removed 1 labels Feb 15, 2019
@rajadain rajadain self-assigned this Feb 15, 2019
@rajadain rajadain added in progress and removed queue labels Feb 18, 2019
@rajadain

This comment has been minimized.

Copy link
Member

@rajadain rajadain commented Feb 18, 2019

Hi Sara, I just started taking a look at this. I do see the errors if I enable a boundary, then zoom out and back in to another part of the country. I also see it if I enable a boundary, then search for a new location and try there. If I load the boundaries after selecting my viewing area, they work correctly.

Are any of the examples above of the boundaries being mistaken on a fresh load / moving the map first and selecting a boundary second? I haven't been able to reproduce that, and would appreciate any direction you could point me towards.

@SRGDamia1

This comment has been minimized.

Copy link
Member Author

@SRGDamia1 SRGDamia1 commented Feb 18, 2019

I have it happen on a fresh load as soon as I open the app.

@rajadain

This comment has been minimized.

Copy link
Member

@rajadain rajadain commented Feb 18, 2019

Thanks for confirming, Sara. I've so far been unable to reproduce that:

2019-02-18 17 28 58

but will keep trying.

@rajadain rajadain mentioned this issue Feb 20, 2019
0 of 2 tasks complete
@rajadain rajadain mentioned this issue Jun 26, 2019
2 of 2 tasks complete
rajadain added a commit that referenced this issue Jun 27, 2019
Upgrade Windshaft

Co-authored-by: Hector Castro <hectcastro@gmail.com>

Connects #3091
Connects #3082
@rajadain

This comment has been minimized.

Copy link
Member

@rajadain rajadain commented Jul 8, 2019

Hi @SRGDamia1, we've fixed this issue and deployed it on Staging: https://staging.modelmywatershed.org/. Could you please take a look there when you get the chance and let us know if it now works as it should? Thank you.

@SRGDamia1

This comment has been minimized.

Copy link
Member Author

@SRGDamia1 SRGDamia1 commented Jul 8, 2019

It's looking good to me.

There is some lag when I change the boundary type, switch locations via search, or select a region - the map takes a few seconds to redraw - but all of the boundary tool-tips and the actual boundary selected seem to be correct.

@rajadain

This comment has been minimized.

Copy link
Member

@rajadain rajadain commented Jul 8, 2019

Thanks for taking a look!

the map takes a few seconds to redraw

We've upgraded the underlying tile generation infrastructure in #3091, which will need new tiles to be generated and cached. Once enough new tiles are cached, the switching should be much faster. But I'll take a look at that and make sure there's no other reason.

@rajadain rajadain mentioned this issue Jul 8, 2019
3 of 3 tasks complete
@SRGDamia1

This comment has been minimized.

Copy link
Member Author

@SRGDamia1 SRGDamia1 commented Jul 8, 2019

Great. I was guessing the slowness was related to caching or the fact that it's the staging server.

@rajadain

This comment has been minimized.

Copy link
Member

@rajadain rajadain commented Jul 25, 2019

Fixed in #3091.

@rajadain rajadain closed this Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.