Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HydroShare Export: Allow Open With Behavior #2664

Merged
merged 1 commit into from Feb 19, 2018
Merged

HydroShare Export: Allow Open With Behavior #2664

merged 1 commit into from Feb 19, 2018

Conversation

rajadain
Copy link
Member

Overview

To indicate to HydroShare that a given resource can be opened in MMW, add extra metadata to that effect. HydroShare currently does not have this functionality implemented, but we add the metadata all the same in the interim so that when HydroShare is ready it opens it in MMW.

Connects #2558

Demo

image

Notes

HydroShare may ask us to use a different key than webapp. I'll update the PR in that case.

Testing Instructions

  • Check out this branch, and go to :8000/
  • Export a project to HydroShare
  • Go to the resource in HydroShare, scroll down, inspect the Extra Metadata and ensure it has an entry with webapp as the key and model-my-watershed as the value

@rajadain rajadain force-pushed the tt/hydroshare-export-mmw-extended-metadata branch from 3493fde to 23f48da Compare February 19, 2018 15:20
@rajadain
Copy link
Member Author

Updated metadata key from webapp to appkey upon recommendation from HydroShare team.

@rajadain
Add extended metadata to signify openability
da4afc9 
To indicate to HydroShare that a given resource can be
opened in MMW, add extra metadata to that effect. HydroShare
currently does not have this functionality implemented, but
we add the metadata all the same in the interim so that when
HydroShare is ready it opens it in MMW.
@rajadain rajadain force-pushed the tt/hydroshare-export-mmw-extended-metadata branch from 23f48da to da4afc9 Compare February 19, 2018 15:21
arottersman
arottersman approved these changes Feb 19, 2018
View reviewed changes
Copy link

@arottersman arottersman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@arottersman arottersman assigned rajadain and unassigned arottersman Feb 19, 2018
@rajadain rajadain merged commit 69c94fb into develop Feb 19, 2018
@rajadain rajadain deleted the tt/hydroshare-export-mmw-extended-metadata branch February 19, 2018 18:01
@rajadain
Copy link
Member Author

Thanks for taking a look! ⚖️

@rajadain rajadain mentioned this pull request Mar 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arottersman arottersman arottersman approved these changes

Assignees

@rajadain rajadain

Labels
HydroShare Export
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rajadain @arottersman @hectcastro