Fix DRB Point Source Listing #2839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we would compare a shape against a high-resolution GeoJSON of the DRB. This would sometimes fail for shapes that fell on the edges, causing minor coordinate variations to say that those shapes were not in the DRB, when in fact they are. By comparing against a simplified, buffered DRB shape (already used elsewhere), we ensure that all true shapes are correctly deemed eligible. Furthermore, since the shape is significantly simpler, the comparison is much quicker, speedening up general execution as well. Refs #2812
Valid GeoJSON requires all Features to have a properties key, which is always an object. It cannot be null. This linting allows simpler importing of these files into services such as http://geojson.io/
Since the Java versions update often and need to be changed, we switch to a more generic Java specification that should catch all instances and not need to be updated as often.
Latest Kombu renamed async to asynchronous celery/kombu#839 breaking Celery, which has a PR to fix this celery/celery#4679 but the changes haven't been released yet celery/celery#4387 so we use this in the interim.
caseycesari
approved these changes
May 22, 2018
|
Thanks for taking a look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
For some edge cases, the query for whether it was "within" the DRB or not would fail. In order to ensure we capture all of them correctly, we now test against the simplified perimeter instead.
Green is White Clay Creek HUC-10. Red is the DRB boundary. Blue is a simplified, buffered DRB boundary.
In this PR, we switch from comparing the green against the red to comparing the green against the blue.
Connects #2812
Demo
Testing Instructions
Check out this branch and restart Celery
Analyze White Clay Creek HUC-10, or Upper Schuylkill HUC-10, or any other shape on the edge of the DRB. Go to the Point Sources tab. Turn on the related layer. Ensure the points on the map match those in the table.
Analyze some shape outside of the DRB. Ensure it works as before.