Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PublicSubnets -> PublicSubnetCIDRRanges in VPC stack #3117

merged 1 commit into from Jul 8, 2019


Copy link

rbreslow commented Jul 3, 2019


This PR renames the PublicSubnets input to the VPC stack, which was overloaded, to PublicSubnetCIDRRanges.

I also updated the default.yml file, as well as the staging.yml file on CI.

Testing Instructions

  • Apply this diff:
diff --git a/deployment/cfn/ b/deployment/cfn/
index da44c9e7..38daed73 100644
--- a/deployment/cfn/
+++ b/deployment/cfn/
@@ -51,6 +51,10 @@ def build_graph(mmw_config, aws_profile, **kwargs):

     global_config = GlobalConfigNode(**mmw_config)
     vpc = VPC(globalconfig=global_config, aws_profile=aws_profile)
+    vpc.set_up_stack()
+    print(vpc.to_json())
     s3_vpc_endpoint = S3VPCEndpoint(globalconfig=global_config, VPC=vpc,
     private_hosted_zone = PrivateHostedZone(globalconfig=global_config,
@@ -85,16 +89,16 @@ def build_stacks(mmw_config, aws_profile, **kwargs):
         application_graph, worker_graph, \
         public_hosted_zone_graph = build_graph(mmw_config, aws_profile,
-    s3_vpc_endpoint_graph.go()
-    data_plane_graph.go()
+    # s3_vpc_endpoint_graph.go()
+    # data_plane_graph.go()

-    if kwargs['stack_color'] is not None:
-        tiler_graph.go()
-        application_graph.go()
-        worker_graph.go()
+    # if kwargs['stack_color'] is not None:
+    #     tiler_graph.go()
+    #     application_graph.go()
+    #     worker_graph.go()

-    if kwargs['activate_dns']:
-        public_hosted_zone_graph.go()
+    # if kwargs['activate_dns']:
+    #     public_hosted_zone_graph.go()
  • Generate a new VPC stack template.json:
./ launch-stacks --aws-profile mmw-stg --mmw-config-path ~/mmw-staging.yml --mmw-profile staging > ~/template-vpc.json
  • See that there are no changes when you try to apply the update the VPC stack in the AWS Console.
@rbreslow rbreslow requested a review from hectcastro Jul 3, 2019
@rbreslow rbreslow self-assigned this Jul 3, 2019
Copy link

hectcastro left a comment


@rbreslow rbreslow merged commit 8390e94 into develop Jul 8, 2019
1 check was pending
1 check was pending
default Build started for merge commit.
@rbreslow rbreslow deleted the feature/jrb/fix-parameter-meaning branch Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.