Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade HydroShare Rest Client to 1.3.4 #3134

Merged
merged 1 commit into from Aug 5, 2019
Merged

Conversation

@rajadain
Copy link
Member

rajadain commented Aug 2, 2019

Overview

This version fixes problems with deleting HydroShare resources, as discussed in hydroshare/hs_restclient#111.

Connects #3119

Testing Instructions

  • Check out this branch and reprovision app and worker:

    $ vagrant reload app worker --provision
    
  • Find and edit the HydroShare OAuth MMW Beta entry in LastPass, and copy the client-secret from the Notes section into MMW_HYDROSHARE_SECRET_KEY:

    $ vagrant ssh app -c 'sudo vim /etc/mmw.d/env/MMW_HYDROSHARE_SECRET_KEY'
    $ vagrant ssh worker -c 'sudo vim /etc/mmw.d/env/MMW_HYDROSHARE_SECRET_KEY'
    
  • Restart the app and Celery services:

    $ vagrant ssh app -c 'sudo service mmw-app restart'
    $ vagrant ssh worker -c 'sudo service celeryd restart'
    
  • Go to :8000/ and log in to an account

  • Make a project and save it

  • Click on "Share" and enable HydroShare sharing

  • Log in to HydroShare using the credentials for HydroShare OAuth MMW Beta in LastPass

    • Ensure that the project is created in HydroShare. It may take a few minutes.
  • Make some changes to the project. Open the Share box again. Click "Export Now" to re-share to HydroShare.

    • Ensure this update goes through correctly. Keep it open in its tab.
  • Open the Share modal again, and now turn off HydroShare. Accept the consequences in the warning modal.

    • Ensure this completes successfully (i.e. no server side errors in the MMW back-end)
    • Ensure the project is gone from HydroShare by refreshing the tab open from one of the previous exports
This version fixes problems with deleting HydroShare
resources, as discussed in hydroshare/hs_restclient#111.

Refs #3119
@rajadain rajadain added the NSF label Aug 2, 2019
@rajadain rajadain requested a review from caseycesari Aug 2, 2019
Copy link
Member

caseycesari left a comment

Working as described!

@caseycesari caseycesari assigned rajadain and unassigned caseycesari Aug 5, 2019
@rajadain

This comment has been minimized.

Copy link
Member Author

rajadain commented Aug 5, 2019

Thanks for taking a look!

@rajadain rajadain merged commit 4926093 into develop Aug 5, 2019
2 checks passed
2 checks passed
default Build finished.
Details
model-my-watershed-pull-requests Build #4076 succeeded in 9 min 52 sec
Details
@rajadain rajadain deleted the tt/upgrade-hs-restclient branch Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.