Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --print-json flag for VPC and DataPlane stacks #3148

Merged
merged 2 commits into from Aug 22, 2019

Conversation

@rbreslow
Copy link
Member

rbreslow commented Aug 21, 2019

Overview

  • Do not update DataPlane stack as a part of a launch-stacks run
  • Add --vpc and --data-plane flag which allow us to conditionally update these stacks
  • Add --print-json flag which prints stack JSON

These changes will allow us to update the VPC and DataPlane stacks by hand using CloudFormation change sets (which provide an increase in visibility).

Connects #3114

Testing Instructions

Setup the virtualenv for majorkirby:

python2 -m virtualenv ./env
source ./env/bin/activate
pip install -r requirements.txt

Verify that valid JSON is returned for both stacks:

./mmw_stack.py launch-stacks \
    --aws-profile mmw-stg \
    --mmw-config-path default.yml \
    --mmw-profile staging \
    --vpc \
    --print-json
./mmw_stack.py launch-stacks \
    --aws-profile mmw-stg \
    --mmw-config-path default.yml \
    --mmw-profile staging \
    --data-plane \
    --print-json
@rbreslow rbreslow requested a review from hectcastro Aug 21, 2019
@rbreslow rbreslow self-assigned this Aug 21, 2019
Copy link
Contributor

hectcastro left a comment

Might be good to add a note about this functionality in the deployment README as well. 👍

@rbreslow rbreslow merged commit a561f86 into develop Aug 22, 2019
@rbreslow rbreslow deleted the feature/jrb/json-stacks branch Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.