Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Upgrade Node #3180
Upgrades Node to 12. This was originally done in anticipation of a new build process for the front-end, which has since been deemed extraneous. Yet, our node version is quite out of date and this upgrade has been a long time coming.
This aims to be a minimally disruptive update that gets us to the most current version without changing too much. It also fixes the Testem not exiting issue of #3110.
CI seems to be failing because it has an older version of Ansible installed that doesn't support recursive copying of a directory under the
I'll change that to explicitly copying specific files.
The old version was not compatible with new node. The latest version of Testem uses the configuration JSON to set the browsers rather than command line arguments, so we move "Firefox" from test.sh and testem.json The `beforeEach` behavior was subtly changed so it only runs every time for `it`s at the same level, but if they are nested within `describe`s it only runs for each `describe`, so some were nested out one level to restore the `beforeEach` behavior. There were some subtle numerical calculation changes to some tests under `turfArea`, even though `turfArea` itself was not upgraded, but they are upgraded to match the new numbers. Testem also removed embeded frameworks in v1.0.0, so we now copy over the `mocha` files from node_modules to the static directory so the custom test page has access to it. For details see: - https://github.com/testem/testem/releases/tag/v1.0.0 - testem/testem#706
This is a transitive dependency via Ulmo, which unfortunately doesn't specify the versions of its dependencies in its requirements.txt file, causing the latest to be pulled down, sometimes resulting in breakage of our provisioning.