Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust curve number calculation. #3210

Merged
merged 1 commit into from Dec 12, 2019
Merged

Adjust curve number calculation. #3210

merged 1 commit into from Dec 12, 2019

Conversation

@lossyrob
Copy link
Member

lossyrob commented Dec 12, 2019

Overview

Adjusts the curve number calculations as per #3188.

Connects #3188

Checklist

  • All JavaScript tests pass ./scripts/testem.sh
Refs #3188
@lossyrob lossyrob requested a review from rajadain Dec 12, 2019
@lossyrob

This comment has been minimized.

Copy link
Member Author

lossyrob commented Dec 12, 2019

@rajadain just to be sure - the issues says "Change the numbers here: ... to be half", but

1.7969 / 2 != 1.3985.

Copy link
Member

rajadain left a comment

+1 looks good!

@rajadain rajadain added the PA DEP label Dec 12, 2019
@lossyrob lossyrob merged commit 730eca6 into develop Dec 12, 2019
2 checks passed
2 checks passed
default Build finished.
Details
model-my-watershed-pull-requests Build #4119 succeeded in 9 min 10 sec
Details
@rajadain rajadain deleted the rde/fix/3188 branch Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.