Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARA output to Analyze Land tab #3220

Merged
merged 1 commit into from Dec 31, 2019
Merged

Add ARA output to Analyze Land tab #3220

merged 1 commit into from Dec 31, 2019

Conversation

@rajadain
Copy link
Member

rajadain commented Dec 30, 2019

Overview

The output, shown in square km, will be shown in the Analyze Land tab if the area of interest is within the ARA Perimeter.

In the code, we inspect all the values for ARA for all the land types. If some of them are NULL we treat it as 0, and still sum up all the values to a total. The value will be shown even if it is 0.

Only when all the values are NULL that we take it as a signal that the AoI must be outside the ARA Perimeter, in which case the entire line is hidden.

Connects #3202

Demo

Within ARA Perimeter:

image

Within ARA Perimeter avoiding ARA values:

image

Within ARA Perimeter for small AoIs, using smaller units:

image

Outside ARA Perimeter:

image

Notes

We are showing totals for data layer that has a corresponding visual layer. Usually, the entire Analyze tab is dedicated to a single layer, and has controls for turning on the related layers at the top.

The ARA line added to the bottom doesn't have the significance to deserve a top-level addition of the ARA layer for the chart and the table, yet it feels like something is missing. I'm not sure on the best way to proceed, and this may likely be a larger design conversation with Stroud and #design.

As such I'd rather defer this to a later card.

Testing Instructions

  • Check out this branch and $ ./scripts/bundle.sh --debug
  • Analyze a shape within the ARA perimeter
    • Ensure you see an "Active river area" line item at the bottom of the NLCD table
  • Analyze a shape outside the ARA perimeter
    • Ensure you see no such line
The output, shown in square km, will be shown in the
Analyze Land tab if the area of interest is within
the ARA Perimeter.

In the code, we inspect all the values for ARA for
all the land types. If some of them are NULL we treat
it as 0, and still sum up all the values to a total.
The value will be shown even if it is 0.

Only when all the values are NULL that we take it as
a signal that the AoI must be outside the ARA Perimeter,
in which case the entire line is hidden.
@rajadain rajadain added the OSI label Dec 30, 2019
@rajadain rajadain requested a review from mmcfarland Dec 30, 2019
Copy link
Member

mmcfarland left a comment

Tested the various scenarios and the ARA display was correct in each 👍

@mmcfarland mmcfarland assigned rajadain and unassigned mmcfarland Dec 31, 2019
@rajadain rajadain merged commit 87afb86 into develop Dec 31, 2019
2 checks passed
2 checks passed
default Build finished.
Details
model-my-watershed-pull-requests Build #4133 succeeded in 8 min 48 sec
Details
@rajadain rajadain deleted the tt/ara-add-front-end branch Dec 31, 2019
@rajadain

This comment has been minimized.

Copy link
Member Author

rajadain commented Dec 31, 2019

Thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.